From: Krzysztof Kozlowski <krzk@kernel.org>
To: George Stark <gnstark@salutedevices.com>,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
neil.armstrong@linaro.org, khilman@baylibre.com,
jbrunet@baylibre.com, martin.blumenstingl@googlemail.com,
hkallweit1@gmail.com, broonie@kernel.org, glaroque@baylibre.com,
rafael@kernel.org, daniel.lezcano@linaro.org,
rui.zhang@intel.com, lukasz.luba@arm.com, b.galvani@gmail.com,
mmkurbanov@sberdevices.ru
Cc: linux-i2c@vger.kernel.org, linux-spi@vger.kernel.org,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel@salutedevices.com
Subject: Re: [PATCH 1/4] dt-bindings: spi: amlogic,a1-spifc: make power-domains required
Date: Mon, 8 Jul 2024 21:51:44 +0200 [thread overview]
Message-ID: <6add148f-efe7-4444-82b3-20b1198c6d07@kernel.org> (raw)
In-Reply-To: <20240708194808.1819185-2-gnstark@salutedevices.com>
On 08/07/2024 21:48, George Stark wrote:
> SPI Flash Controller has dedicated power domain so make the
> corresponding property required.
That's an ABI break. Being part of power domain does not necessarily
mean it must be required, so your commit msg lacks rationale. Especially
on the ABI part.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-07-08 19:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-08 19:48 [PATCH 0/4] amlogic SoC's power-domains fixes George Stark
2024-07-08 19:48 ` [PATCH 1/4] dt-bindings: spi: amlogic,a1-spifc: make power-domains required George Stark
2024-07-08 19:51 ` Krzysztof Kozlowski [this message]
2024-07-10 16:23 ` George Stark
2024-07-10 16:38 ` neil.armstrong
2024-07-08 21:48 ` Rob Herring (Arm)
2024-07-08 19:48 ` [PATCH 2/4] dt-bindings: i2c: amlogic,meson6-i2c: add optional power-domains George Stark
2024-07-09 8:56 ` neil.armstrong
2024-07-09 16:31 ` Rob Herring (Arm)
2024-07-08 19:48 ` [PATCH 3/4] dt-bindings: thermal: amlogic,thermal: add power-domains George Stark
2024-07-08 19:52 ` Krzysztof Kozlowski
2024-07-08 19:48 ` [PATCH 4/4] arm64: dts: meson: a1: bind power domain to temperature sensor George Stark
2024-07-09 8:53 ` neil.armstrong
2024-07-09 8:56 ` [PATCH 0/4] amlogic SoC's power-domains fixes neil.armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6add148f-efe7-4444-82b3-20b1198c6d07@kernel.org \
--to=krzk@kernel.org \
--cc=b.galvani@gmail.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=glaroque@baylibre.com \
--cc=gnstark@salutedevices.com \
--cc=hkallweit1@gmail.com \
--cc=jbrunet@baylibre.com \
--cc=kernel@salutedevices.com \
--cc=khilman@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=mmkurbanov@sberdevices.ru \
--cc=neil.armstrong@linaro.org \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).