* [PATCH] phy: qcom: qmp-ufs: add missing offsets to sm8150 configuration
@ 2023-07-31 11:10 Dmitry Baryshkov
2023-07-31 11:15 ` Konrad Dybcio
2023-08-11 8:30 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Dmitry Baryshkov @ 2023-07-31 11:10 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Vinod Koul,
Kishon Vijay Abraham I, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: Philipp Zabel, Johan Hovold, linux-arm-msm, linux-phy, devicetree
The conversion commit 7559e7572c03 ("phy: Explicitly include correct DT
includes") misses offsets configuration for sm8150 (most likely it was
developed separately from the series adding HS G4 support and was not
adapted for the sm8150/sm8250 configuration split).
Add missing offsets to sm8150_ufsphy_cfg.
Fixes: 7559e7572c03 ("phy: Explicitly include correct DT includes")
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
drivers/phy/qualcomm/phy-qcom-qmp-ufs.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c b/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c
index 03cd47faf3fd..3927eba8e468 100644
--- a/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c
+++ b/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c
@@ -1009,6 +1009,8 @@ static const struct qmp_phy_cfg sm7150_ufsphy_cfg = {
static const struct qmp_phy_cfg sm8150_ufsphy_cfg = {
.lanes = 2,
+ .offsets = &qmp_ufs_offsets,
+
.tbls = {
.serdes = sm8150_ufsphy_serdes,
.serdes_num = ARRAY_SIZE(sm8150_ufsphy_serdes),
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] phy: qcom: qmp-ufs: add missing offsets to sm8150 configuration
2023-07-31 11:10 [PATCH] phy: qcom: qmp-ufs: add missing offsets to sm8150 configuration Dmitry Baryshkov
@ 2023-07-31 11:15 ` Konrad Dybcio
2023-08-11 8:30 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Konrad Dybcio @ 2023-07-31 11:15 UTC (permalink / raw)
To: Dmitry Baryshkov, Andy Gross, Bjorn Andersson, Vinod Koul,
Kishon Vijay Abraham I, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: Philipp Zabel, Johan Hovold, linux-arm-msm, linux-phy, devicetree
On 31.07.2023 13:10, Dmitry Baryshkov wrote:
> The conversion commit 7559e7572c03 ("phy: Explicitly include correct DT
> includes") misses offsets configuration for sm8150 (most likely it was
> developed separately from the series adding HS G4 support and was not
> adapted for the sm8150/sm8250 configuration split).
>
> Add missing offsets to sm8150_ufsphy_cfg.
>
> Fixes: 7559e7572c03 ("phy: Explicitly include correct DT includes")
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] phy: qcom: qmp-ufs: add missing offsets to sm8150 configuration
2023-07-31 11:10 [PATCH] phy: qcom: qmp-ufs: add missing offsets to sm8150 configuration Dmitry Baryshkov
2023-07-31 11:15 ` Konrad Dybcio
@ 2023-08-11 8:30 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2023-08-11 8:30 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio,
Kishon Vijay Abraham I, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Dmitry Baryshkov
Cc: Philipp Zabel, Johan Hovold, linux-arm-msm, linux-phy, devicetree
On Mon, 31 Jul 2023 14:10:09 +0300, Dmitry Baryshkov wrote:
> The conversion commit 7559e7572c03 ("phy: Explicitly include correct DT
> includes") misses offsets configuration for sm8150 (most likely it was
> developed separately from the series adding HS G4 support and was not
> adapted for the sm8150/sm8250 configuration split).
>
> Add missing offsets to sm8150_ufsphy_cfg.
>
> [...]
Applied, thanks!
[1/1] phy: qcom: qmp-ufs: add missing offsets to sm8150 configuration
commit: b102ce6d847a715732174cfe7119a350f69f3511
Best regards,
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-08-11 8:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-31 11:10 [PATCH] phy: qcom: qmp-ufs: add missing offsets to sm8150 configuration Dmitry Baryshkov
2023-07-31 11:15 ` Konrad Dybcio
2023-08-11 8:30 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).