From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5466BC38142 for ; Fri, 27 Jan 2023 16:10:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234519AbjA0QK2 (ORCPT ); Fri, 27 Jan 2023 11:10:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38280 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234621AbjA0QKX (ORCPT ); Fri, 27 Jan 2023 11:10:23 -0500 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F151C24C81 for ; Fri, 27 Jan 2023 08:10:18 -0800 (PST) Received: by mail-wr1-x433.google.com with SMTP id z5so5406858wrt.6 for ; Fri, 27 Jan 2023 08:10:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=c5c1eedNjG2GtgvM7btwPNhYOwNRimSFdJYoD2846dk=; b=vnyG2N7BkeFCq1NOoffzeAQTOuKZslMEMR5Q3TJ9vmmrorqaKr7pwMRiUSw2e4iCCC j9AMFbrYb54DJJUr8V6aT9WZ8gHVrc3IznywBBaoQ0+HHE7+H+g5+MF4O5mjotIa5zdi fet/sywe0/BhWHPnE4jh1D0NtNSEqCzyxrNz6PZwbnrEu3dVC6qq5CAr6eWCyryV5EX/ letUfNSsTcZDMyjaFulOLpGHebkKkpIQqZedsOcle+nJAz7QYaR2bASHFsXttnu/9K4T axFTwSV8QblZvUgU/a/Zg0ulDkbWpEkASBtQrmKYPYIM1TAJXIPmQJoH7ne6ZdRoD/K8 22kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=c5c1eedNjG2GtgvM7btwPNhYOwNRimSFdJYoD2846dk=; b=MbZ/0DC1EHLu/dm4gH/G174WHhPYTH9xqv5eWSSZzJh4Txh1oe+JVE4MWgIcaN/phh rmKP++YD4jsnGxaK69QieVFRL8NvbWvE4IjO+B+vuLgYdklD9DscRxaZOragT1k51FNt QBG1WhVoX6Q59aEvaGvpTNVvMIFzQTIxhd+I0JnwL+eQ3Aqx7Fac+smYCveHopbvObBa exosZZavSFktHCsie1X0ZvxKe8e8PKjUtkCRvjMX4LqSOz/9q8WCcXYs4+34XkG8VX9F RoPz4DrghklOR9eZgszh50j9OblZeC4TqECRe9YqeG9y5uAJoLAk4Vw1/s6h+1up0vPb Mo1A== X-Gm-Message-State: AO0yUKVGebz5440D9h0+2MebaHOtev/Xtdz+An8Mmhf4SIiwWNxbR9CW XuIDVWmpN4N0HTxmmYyRqxItlw== X-Google-Smtp-Source: AK7set9fC9KDLzGG5uo35qWPcOMhPWvuhV8kzWwn2bTk49e9kuY/12RAcoiVciK7zU73a00qjeojCg== X-Received: by 2002:a5d:5541:0:b0:2bf:c0e4:1bc5 with SMTP id g1-20020a5d5541000000b002bfc0e41bc5mr6984696wrw.56.1674835817538; Fri, 27 Jan 2023 08:10:17 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id n9-20020a5d67c9000000b00294176c2c01sm4307168wrw.86.2023.01.27.08.10.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Jan 2023 08:10:17 -0800 (PST) Message-ID: <6b5e20a3-69ba-aceb-5402-853729e73266@linaro.org> Date: Fri, 27 Jan 2023 17:10:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2 1/2] dt-bindings: pinctrl: describe sa8775p-tlmm Content-Language: en-US To: Bartosz Golaszewski , Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski Cc: linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski References: <20230127154426.173863-1-brgl@bgdev.pl> <20230127154426.173863-2-brgl@bgdev.pl> From: Krzysztof Kozlowski In-Reply-To: <20230127154426.173863-2-brgl@bgdev.pl> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 27/01/2023 16:44, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Add DT bindings for the TLMM controller on sa8775p platforms. > > Signed-off-by: Bartosz Golaszewski Thank you for your patch. There is something to discuss/improve. > + reg: > + maxItems: 1 > + > + interrupts: true > + interrupt-controller: true > + "#interrupt-cells": true > + gpio-controller: true > + "#gpio-cells": true > + gpio-ranges: true Blank line here. > + gpio-reserved-ranges: > + minItems: 1 > + maxItems: 74 Blank line. > + gpio-line-names: > + maxItems: 148 Your GPIO pattern suggests you have 149 GPIOs. Something has to be fixed. If this is 149, then reserved ranges is up to 75. > + > +required: > + - compatible > + - reg > + Best regards, Krzysztof