From: m.brock@vanmierlo.com
To: Manikanta Guntupalli <manikanta.guntupalli@amd.com>
Cc: gregkh@linuxfoundation.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, michal.simek@xilinx.com,
linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, jirislaby@kernel.org,
linux-arm-kernel@lists.infradead.org, michal.simek@amd.com,
git@amd.com, radhey.shyam.pandey@amd.com,
shubhrajyoti.datta@amd.com, srinivas.goud@amd.com,
manion05gk@gmail.com
Subject: Re: [PATCH 0/2] Add rs485 support to uartps driver
Date: Thu, 04 May 2023 14:22:13 +0200 [thread overview]
Message-ID: <6b72c56e79a44fec348de26d14d9dce0@vanmierlo.com> (raw)
In-Reply-To: <1682512187-8828-1-git-send-email-manikanta.guntupalli@amd.com>
Manikanta Guntupalli wrote 2023-04-26 14:29:
> Add optional gpio property to uartps node to support rs485
> Add rs485 support to uartps driver
>
> Manikanta Guntupalli (2):
> dt-bindings: Add optional gpio property to uartps node to support
> rs485
> tty: serial: uartps: Add rs485 support to uartps driver
>
> .../devicetree/bindings/serial/cdns,uart.yaml | 5 +
> drivers/tty/serial/xilinx_uartps.c | 96 ++++++++++++++++++-
> 2 files changed, 100 insertions(+), 1 deletion(-)
Why would you want to use a GPIO and not RTS for choosing the direction
as is more common in this case?
And have you thought about configuring the polarity?
How long will the signal be active before the real transmission begins
so the driver can settle?
Maarten
next prev parent reply other threads:[~2023-05-04 12:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-26 12:29 [PATCH 0/2] Add rs485 support to uartps driver Manikanta Guntupalli
2023-04-26 12:29 ` [PATCH 1/2] dt-bindings: Add optional gpio property to uartps node to support rs485 Manikanta Guntupalli
2023-04-27 16:43 ` Rob Herring
2023-05-02 10:14 ` Guntupalli, Manikanta
2023-05-02 10:19 ` Krzysztof Kozlowski
2023-05-02 10:57 ` Michal Simek
2023-05-02 11:10 ` Krzysztof Kozlowski
2023-05-04 12:14 ` m.brock
2023-04-26 12:29 ` [PATCH 2/2] tty: serial: uartps: Add rs485 support to uartps driver Manikanta Guntupalli
2023-05-04 12:22 ` m.brock [this message]
2023-05-10 16:26 ` [PATCH 0/2] " Guntupalli, Manikanta
2023-05-11 7:26 ` Michal Simek
2023-05-14 11:01 ` m.brock
2023-05-15 6:35 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b72c56e79a44fec348de26d14d9dce0@vanmierlo.com \
--to=m.brock@vanmierlo.com \
--cc=devicetree@vger.kernel.org \
--cc=git@amd.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=manikanta.guntupalli@amd.com \
--cc=manion05gk@gmail.com \
--cc=michal.simek@amd.com \
--cc=michal.simek@xilinx.com \
--cc=radhey.shyam.pandey@amd.com \
--cc=robh+dt@kernel.org \
--cc=shubhrajyoti.datta@amd.com \
--cc=srinivas.goud@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).