From: skakit@codeaurora.org
To: Matthias Kaehlcke <mka@chromium.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, kgunda@codeaurora.org
Subject: Re: [PATCH V2 1/5] arm64: dts: qcom: pm7325: Add PMIC peripherals for pm7325
Date: Wed, 07 Apr 2021 20:59:26 +0530 [thread overview]
Message-ID: <6b85273758e5c667e1952b41fe901b8a@codeaurora.org> (raw)
In-Reply-To: <YGeAHKOq65WBr9Yr@google.com>
On 2021-04-03 02:05, Matthias Kaehlcke wrote:
> On Fri, Apr 02, 2021 at 10:35:54AM -0700, Matthias Kaehlcke wrote:
>> On Thu, Apr 01, 2021 at 02:43:12PM +0530, satya priya wrote:
>>
>> > subject: arm64: dts: qcom: pm7325: Add PMIC peripherals for pm7325
>>
>> nit: maybe just 'arm64: dts: qcom: Add pm7325 support/.dtsi' or
>> similar?
>>
>> > Add temp-alarm and GPIO support for pm7325.
>>
>> nit: it's more than that, you are adding the .dtsi for the PMIC
>> itself.
>>
>> > Signed-off-by: satya priya <skakit@codeaurora.org>
>> > ---
>> > arch/arm64/boot/dts/qcom/pm7325.dtsi | 53 ++++++++++++++++++++++++++++++++++++
>> > 1 file changed, 53 insertions(+)
>> > create mode 100644 arch/arm64/boot/dts/qcom/pm7325.dtsi
>> >
>> > diff --git a/arch/arm64/boot/dts/qcom/pm7325.dtsi b/arch/arm64/boot/dts/qcom/pm7325.dtsi
>> > new file mode 100644
>> > index 0000000..1e0848a
>> > --- /dev/null
>> > +++ b/arch/arm64/boot/dts/qcom/pm7325.dtsi
>> > @@ -0,0 +1,53 @@
>> > +// SPDX-License-Identifier: BSD-3-Clause
>> > +// Copyright (c) 2021, The Linux Foundation. All rights reserved.
>> > +
>> > +#include <dt-bindings/interrupt-controller/irq.h>
>> > +#include <dt-bindings/spmi/spmi.h>
>> > +
>> > +&spmi_bus {
>> > + pm7325: pmic@1 {
>> > + compatible = "qcom,pm7325", "qcom,spmi-pmic";
>>
>> I saw the patches that add the compatible strings for the GPIOs, but
>> can't find those that add the strings for the PMICs themselves. Could
>> you provide a link if they have been sent already?
>>
>> > + reg = <0x1 SPMI_USID>;
>> > + #address-cells = <1>;
>> > + #size-cells = <0>;
>> > +
>> > + pm7325_temp_alarm: temp-alarm@a00 {
>> > + compatible = "qcom,spmi-temp-alarm";
>> > + reg = <0xa00>;
>> > + interrupts = <0x1 0xa 0x0 IRQ_TYPE_EDGE_BOTH>;
>> > + #thermal-sensor-cells = <0>;
>> > + };
>> > +
>> > + pm7325_gpios: gpios@8800 {
>> > + compatible = "qcom,pm7325-gpio", "qcom,spmi-gpio";
>> > + reg = <0x8800>;
>> > + gpio-controller;
>> > + gpio-ranges = <&pm7325_gpios 0 0 10>;
>
> The GPIO enumeration is a bit confusing. The pm7325 has GPIO_01 to
> GPIO_10, however IIUC they are mapped such that under Linux
> enumeration starts with 0. I guess it makes sense to start with 0 and
> it's done consistently for 'qcom,spmi-gpio', but it's something that
> must
> be taken into account when using/configuring those GPIOs.
Sure, will take care of this while configuring the GPIOs.
next prev parent reply other threads:[~2021-04-07 15:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 9:13 [PATCH V2 0/5] Add PMIC DT files for sc7280 satya priya
2021-04-01 9:13 ` [PATCH V2 1/5] arm64: dts: qcom: pm7325: Add PMIC peripherals for pm7325 satya priya
2021-04-02 17:35 ` Matthias Kaehlcke
2021-04-02 20:35 ` Matthias Kaehlcke
2021-04-07 15:29 ` skakit [this message]
2021-04-07 15:24 ` skakit
2021-04-01 9:13 ` [PATCH V2 2/5] arm64: dts: qcom: pm8350c: Add PMIC peripherals for pm8350c satya priya
2021-04-01 9:13 ` [PATCH V2 3/5] arm64: dts: qcom: pmk8350: Add PMIC peripherals for pmk8350 satya priya
2021-04-02 18:45 ` Matthias Kaehlcke
2021-04-07 15:28 ` skakit
2021-04-01 9:13 ` [PATCH V2 4/5] arm64: dts: qcom: pmr735a: Add PMIC peripherals for pmr735a satya priya
2021-04-02 19:26 ` Matthias Kaehlcke
2021-04-07 15:29 ` skakit
2021-04-01 9:13 ` [PATCH V2 5/5] arm64: dts: sc7280: Include PMIC DT files for sc7280 satya priya
2021-04-04 17:41 ` [PATCH V2 0/5] Add " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b85273758e5c667e1952b41fe901b8a@codeaurora.org \
--to=skakit@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=kgunda@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).