From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Andreas Kemnade <andreas@kemnade.info>,
lee@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
bcousson@baylibre.com, tony@atomide.com, mturquette@baylibre.com,
sboyd@kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
linux-clk@vger.kernel.org
Subject: Re: [PATCH v2 1/5] dt-bindings: mfd: convert twl-family.tx to json-schema
Date: Thu, 31 Aug 2023 08:26:32 +0200 [thread overview]
Message-ID: <6baf47b2-6244-c6a5-ff43-1514f7f74f4b@linaro.org> (raw)
In-Reply-To: <20230830182038.878265-2-andreas@kemnade.info>
On 30/08/2023 20:20, Andreas Kemnade wrote:
> Convert the TWL[46]030 binding to DT schema format. To do it as a step by
> step work, do not include / handle nodes for subdevices yet, just convert
> things with minimal corrections. There are already some bindings for its
> subdevices in the tree.
>
...
> +properties:
> + compatible:
> + description:
> + TWL4030 for integrated power-management/audio CODEC device used in OMAP3
> + based boards
> + TWL6030/32 for integrated power-management used in OMAP4 based boards
> + enum:
> + - ti,twl4030
> + - ti,twl6030
> + - ti,twl6032
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + interrupt-controller: true
> +
> + "#interrupt-cells":
> + const: 1
> +
> +additionalProperties: true
No, this must be false. example-schema and all device bindings require
this to be false. Having it true makes the schema basically no-op, so
why do you need it?
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-08-31 6:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-30 18:20 [PATCH v2 0/5] ARM: omap: omap4-embt2ws: 32K clock for WLAN Andreas Kemnade
2023-08-30 18:20 ` [PATCH v2 1/5] dt-bindings: mfd: convert twl-family.tx to json-schema Andreas Kemnade
2023-08-30 21:25 ` Rob Herring
2023-08-31 6:26 ` Krzysztof Kozlowski [this message]
2023-09-05 6:42 ` Tony Lindgren
2023-08-30 18:20 ` [PATCH v2 2/5] dt-bindings: mfd: ti,twl: Add clock provider properties Andreas Kemnade
2023-08-31 15:55 ` Conor Dooley
2023-08-30 18:20 ` [PATCH v2 3/5] mfd: twl-core: Add a clock subdevice for the TWL6032 Andreas Kemnade
2023-08-30 18:20 ` [PATCH v2 4/5] clk: twl: add clock driver for TWL6032 Andreas Kemnade
2023-08-30 18:20 ` [PATCH v2 5/5] ARM: dts: omap4-embt2ws: enable 32K clock on WLAN Andreas Kemnade
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6baf47b2-6244-c6a5-ff43-1514f7f74f4b@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andreas@kemnade.info \
--cc=bcousson@baylibre.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).