From: Liu Ying <victor.liu@nxp.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: devicetree@vger.kernel.org, David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org, Rob Herring <robh+dt@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>
Subject: Re: [PATCH] dt-bindings: display: panel-simple: Allow optional 'ports' property
Date: Tue, 10 Nov 2020 17:17:29 +0800 [thread overview]
Message-ID: <6bd2d6da04c4ab9b95152cda66ab8026068de1b0.camel@nxp.com> (raw)
In-Reply-To: <20201110055324.GA1993169@ravnborg.org>
On Tue, 2020-11-10 at 06:53 +0100, Sam Ravnborg wrote:
> Hi Liu Ying,
> On Tue, Nov 10, 2020 at 10:37:27AM +0800, Liu Ying wrote:
> > Hi Sam,
> >
> > On Wed, 2020-11-04 at 11:47 +0100, Sam Ravnborg wrote:
> > > Hi Liu Ying
> > >
> > > On Wed, Nov 04, 2020 at 04:03:37PM +0800, Liu Ying wrote:
> > > > Some simple panels have dual LVDS interfaces which receive even
> > > > and
> > > > odd
> > > > pixels respectively, like 'nlt,nl192108ac18-02d' and
> > > > 'koe,tx26d202vm0bwa'.
> > > > So, let's allow optional 'ports' property so that pixel order
> > > > can
> > > > be got
> > > > via drm_of_lvds_get_dual_link_pixel_order() if it's child
> > > > nodes
> > > > 'port@0'
> > > > and 'port@1' contain 'dual-lvds-even-pixels' and 'dual-lvds-
> > > > odd-
> > > > pixels'
> > > > properties respectively.
> > >
> > > A panel with dual LVDS interfaces is no longer in the "simple"
> > > category.
> > > The panel-simple binding shall be limited to the simple pnales
> > > only.
> > >
> > > This is also why we have for example panel-simple-dsi binding.
> > >
> > > Please consider either a binding dedicated for the dual port
> > > displays
> > > or
> >
> > Thanks for your review.
> >
> > Does a new 'panel-simple-lvds-dual-ports.yaml' binding look ok?
> > I assume it would inherit all properties of panel-simple.yaml and
> > all
> > existing compatibles of LVDS panels with dual ports in
> > panel-simple.yaml can be moved to it.
>
> Yes, that would be fine. If possible we shall have similar panels
> described by the same binding.
>
> Try to send out the binding for review early before starting to move
> too
> much around - so we can get an early look at it at see if this is
> indeed
> the right direction to go.
Yes. I've sent out one for review:
https://lists.freedesktop.org/archives/dri-devel/2020-November/286482.html
>
> Sam
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Liu Ying
prev parent reply other threads:[~2020-11-10 9:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-04 8:03 [PATCH] dt-bindings: display: panel-simple: Allow optional 'ports' property Liu Ying
2020-11-04 10:47 ` Sam Ravnborg
2020-11-10 2:37 ` Liu Ying
2020-11-10 5:53 ` Sam Ravnborg
2020-11-10 9:17 ` Liu Ying [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6bd2d6da04c4ab9b95152cda66ab8026068de1b0.camel@nxp.com \
--to=victor.liu@nxp.com \
--cc=airlied@linux.ie \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).