From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 736C930C602 for ; Thu, 6 Nov 2025 09:51:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762422670; cv=none; b=r0Us+Q3yVeH1oDMjlz5Ce04HrVd6t7JVqSvmLZF7ZowFR+dtZcdfu/GtWZwdYqx1jssR6iy3p4ZiYn5g7uhr4MXBIE86/9AixzkNUloaL/6HzQcNVD/KneewlW0ogeU70jozHkzvwAAwQTTCY5KO8RZgvOiGl+C0Soe7/IJk5Q4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762422670; c=relaxed/simple; bh=nXSRMf9/aZ7Q9VqSPsWiKmuE1hBg/kBZqOFH3xssUmw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TbJCO2y2VeZqmmd/lBRKNJPdo7lE1SRtRpeTgkptD1dlZbEoaDlCbKWScZzkg+7v2Gj5KtUaK4hekh670TVApa6f3HqZ6xds5Iba7GGud9dntnNR+6bxND5xpCAPdxuCZdHzhFn9RMsmiTnaTzBByO1RA51lnvoUML90KXnqkYo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=TNlZMLsb; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=IhbnKY5Z; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="TNlZMLsb"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="IhbnKY5Z" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5A66OhLY1738321 for ; Thu, 6 Nov 2025 09:51:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= tZsRCzXp9F2PQY4ggZIqyN7UEW8FExIqJdOsCcIvnqU=; b=TNlZMLsbj7CDm8hw biToZd0J9wQhXAyeUjAmL/EB4ts6sHqw54l1TTgkCeIWG1YDdcPAXRDZuPbb5Aac 7v7dBAklyq36/LWH7D+pho6m7X7TOnYDrEYKmetg57G8akLonrVw2LN8WctArYIY doZI5SvBHzgIXCSQJbVmUI7d+0gv00jrqKbnuef4qIM1xjaI+hCjDiE/NNLQHAdg gj1ZpebOTriQfd4AKZqMt6CVHtPEOFZwpbCcnjH0zWbzSmqs9R4GqxU1SRuOMZFp TVdYTI2u85qzVPhI1AvSoJc7K7uqLE6fxy3OsHP9jo8Xp4dmq4K7LSRqqiwp5mXa bStvEg== Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4a8an3tmb4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 06 Nov 2025 09:51:07 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-8800dd3de99so339526d6.0 for ; Thu, 06 Nov 2025 01:51:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1762422666; x=1763027466; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=tZsRCzXp9F2PQY4ggZIqyN7UEW8FExIqJdOsCcIvnqU=; b=IhbnKY5Z6QkhfIinFeCRgWJkWhkP1aqh5WPk98e1n6mgyuUcI+WmbcUoixsDyuKrKW xqsApusLJKYqXdvGPl13ltD9W0c26cloqAtsbb/ZarmP3SkPuqB9WpUMPkQCRVz3EuB0 K6mIXxjcI9f8NO9IxFXxrgzDqBRnGbLfZeTSrq+kvB3dU8RhZOp3HlN2UIvzPKgtazrx UENzEjDOky6VxFkwLjYfG9s+G4EUcDxKVIwnMQAszonIBx1vV44shny0vI82WivC1g5a P/pN30l4a3YPSvYPCBZXff05MzFqcQDD9udgLGTDvtFm1kZSp3vFXsOrwlwA/WsgJ5b4 Utzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762422666; x=1763027466; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tZsRCzXp9F2PQY4ggZIqyN7UEW8FExIqJdOsCcIvnqU=; b=iXdWPi/yH7G9tShK4SKCIyjXVCigrQvSPlG3wn+h+Fh0bqOqFyqAIebuu79bY36Mu/ 2HSy7lbMa//NW1912862gg078txfmUYiDAk2Q1HQVaAsv1V0r3/XW74vL1D7PPxhVrOX GVfDGbD0+ofSBIw/sP2UJfDzrGo0mryiH5KUq7qjHrG6Wv1NtFm/4OHUZDyE9gIUtUw/ SkfRN/L+rm9wqhGrHvT/18hesPH3+0fy3vxfKghYGwTdRmVdZ0+GZU0dS3P3pJ+nlf/3 12S9Fa+b44SJsKIzWA99UIES9Dlm39rzMCBeBDMBCUEpAL9CV73tW8tNXifW7hQjlhhD 50hw== X-Forwarded-Encrypted: i=1; AJvYcCXcqRRfoRnhHKJ6dCA8xkmwlNIb7TmTrkLbl8xHvFfdMaDR1gz/kocsn38ckXIZCqPJGeAly65TW06N@vger.kernel.org X-Gm-Message-State: AOJu0Yz+NZJ43YDn1V+nYVNhBAspV0Feis1aRRSgVIWZ6KbcYUlbGPNB 6lrO1HF2k71C0XDWvGj+pMfG+o51g93wB5sGzTO1Ra+L5ToBU8yBNymRos+MhvvmX+Z0BYyOMkl IXnls4lmkcMMgdmGfho2zmNSfwIpfkK4s+RpcnBP+JlGPkuULvC6hBw+rwAIUAqOF X-Gm-Gg: ASbGncvcAtTdthHY6iALT7xWENQTgyhbXB01GG5YMTsI3v/+wRJtQE+ipGZA4j7VGA8 8xvCBrl/oPsqscd9J+KWA5UEqyN4htqrHzrHR6rWOmxIdfj5od3vButwrgOA9JSZFA+amPQuxCk HetTIvgELgfvA7ejM+n1YKhcxNLmATGNeeLAB71EUVw9AC/75jsip5vwyHdr4xjZbpC2XwtSn3x 4kHyaKFSNJpvLhX0x3Kp860ks7EEa1SD077ouktACBMa5zQvvyTlouCRB6NsfcYGq0FLNXvjlU8 SXiY7RI4c5ofMo33layeZFnFXfeGar1s2W5+lFKlIuyL7jD+qMSh7jrCkutzVnxpOW8TdOQd5ap ZStY31gO1KXawJjIxFTbTWdnfHN4PmF58Z731ph1lb3N6tk8KyPU3SsW8 X-Received: by 2002:ad4:5f86:0:b0:87c:2360:d41f with SMTP id 6a1803df08f44-88082f23ee9mr18251096d6.3.1762422666543; Thu, 06 Nov 2025 01:51:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IHPT/BAVfUWlvYl6K4WhBqXTZmQpbLXz9xtVoeJwcK31/pU4lMp/uDh04+Fm7fJy69yKEsuhw== X-Received: by 2002:ad4:5f86:0:b0:87c:2360:d41f with SMTP id 6a1803df08f44-88082f23ee9mr18250936d6.3.1762422666082; Thu, 06 Nov 2025 01:51:06 -0800 (PST) Received: from [192.168.119.202] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b7289334257sm182354966b.6.2025.11.06.01.51.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Nov 2025 01:51:05 -0800 (PST) Message-ID: <6bd38ab5-cf60-48b3-a27c-a33de9762cf0@oss.qualcomm.com> Date: Thu, 6 Nov 2025 10:51:03 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/5] dt-bindings: firmware: qcom,scm: Document reboot mode To: Loic Poulain Cc: Bjorn Andersson , konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, sre@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org References: <20251103182006.1158383-1-loic.poulain@oss.qualcomm.com> <20251103182006.1158383-4-loic.poulain@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=W981lBWk c=1 sm=1 tr=0 ts=690c6f8b cx=c_pps a=UgVkIMxJMSkC9lv97toC5g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=VwQbUJbxAAAA:8 a=U3JJaeWcYHlj1SPvQKAA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=1HOtulTD9v-eNWfpl4qZ:22 X-Proofpoint-GUID: rvbtj2UifgD6h3ys6Y7_FyBBTr0R1Qov X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTA2MDA3OCBTYWx0ZWRfX7zwUr3/ycJ1K WOBzgra+lOOgt/52IfNBYEAqgALLPpAHPs5pwvacEupZK7iQg63yaX9XUy6vi4nlFx/POk5CS15 QdfVnwd7HohhTZoWbddp4PbLvZADDqcuBRWja3/pb4kXjQHgeTCZMzc9rhBqBNZXht4a160hMHw uKr5h+gWqsRzwFmrpJHb4gRvNV+BZXBzaGyvZeNLEjXOqL6JdsM/pXqO/ZwXiCLJzwor6HauBZs eCCHG0ItlaDOfY7jHhS5towO3LiXhhMn+lJVyt5WOvU8QTjb5eb/8bhmPTkeFuXEI4cn+Pw9qey irMEp9HFiEoRLm0ZUE7MilbwhgtaCvNsxmZJ2XHYff+o3QR2061AWDw/uwSTbKpLTzIxmbKlzcZ Ys8mecL/Ik+GC/6cdk919VAc1/jMjQ== X-Proofpoint-ORIG-GUID: rvbtj2UifgD6h3ys6Y7_FyBBTr0R1Qov X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-06_02,2025-11-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 adultscore=0 spamscore=0 impostorscore=0 bulkscore=0 lowpriorityscore=0 priorityscore=1501 malwarescore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511060078 On 11/5/25 9:17 PM, Loic Poulain wrote: > On Wed, Nov 5, 2025 at 10:44 AM Konrad Dybcio > wrote: >> >> On 11/4/25 10:19 PM, Loic Poulain wrote: >>> On Tue, Nov 4, 2025 at 3:12 AM Bjorn Andersson wrote: >>>> >>>> On Mon, Nov 03, 2025 at 07:20:04PM +0100, Loic Poulain wrote: >>>>> SCM can be used to support reboot mode such as Emergency Recovery Mode. >>>> >>>> "such as"? Do we have any other useful bits in here? >>> >>> I heard we may have different EDL modes supported like USB or SD >>> based EDL, but I don't know much about the details. >>> >>>> >>>>> >>>>> Signed-off-by: Loic Poulain >>>>> --- >>>>> Documentation/devicetree/bindings/firmware/qcom,scm.yaml | 4 ++++ >>>>> 1 file changed, 4 insertions(+) >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml >>>>> index b913192219e4..c8bb7dacd900 100644 >>>>> --- a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml >>>>> +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml >>>>> @@ -121,6 +121,10 @@ properties: >>>>> - description: offset of the download mode control register >>>>> description: TCSR hardware block >>>>> >>>>> +patternProperties: >>>>> + "^mode-.*$": >>>> >>>> I'd only ever expect mode-edl = <1>. Do we have additional modes that >>>> warrant the generic nature of this? >>> >>> We may extend this to mode-ramdump if it makes sense, but as of now >>> it's indeed only edl, will fix it. >> >> Would adding ramdump here be a matter of: >> >> + mode-ramdump = <0xmagic> > > Not in its current form, I’ll need to slightly adjust the qcom,scm > driver mask for the reboot mode and also prevent the dload inhibit > during reboot. I can include these changes in v2 if that would be > helpful. Let's do it incrementally, as changing the scope usually ends up causing chaos Konrad