From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EEC0EB64DD for ; Mon, 7 Aug 2023 06:23:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229735AbjHGGXz (ORCPT ); Mon, 7 Aug 2023 02:23:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229584AbjHGGXy (ORCPT ); Mon, 7 Aug 2023 02:23:54 -0400 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E34811700 for ; Sun, 6 Aug 2023 23:23:52 -0700 (PDT) Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-3fe1e1142caso41475195e9.0 for ; Sun, 06 Aug 2023 23:23:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1691389431; x=1691994231; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3A446E/kT3GEJ5OdOfp6vlTjEoG2ufXKFcEfUJuKEMI=; b=wY2Bp5xhxoMYp9AWapejnTHfg+ixw+U4HdSL7LFDfxm1JL3Sd3BL4myGDItmJgB6/s zV5taHSANXkoO8LH9RME+CUJLq4IgqsXy6oZRYJjWa7b+FLh+ec28dPyngJlywQwWSST Rfj+3Hujx0jViEih2fanVRArvPyRS348FK6ZIXEydCv7x0nvC7JTz3h5ggDqtScEpfYh sI/YoU6nhDalj3uqCPbhdKZ+v3FBy5xJp8Hy3hd7AckJJxUMGa6yqx+paVcadbX/FxO5 PklfjvLiwNpWgZ11q/yhX3nh9dXdHsMitzgLHwl/3lej+1dFTGXN7CELuu2MU89O/th1 +aww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691389431; x=1691994231; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3A446E/kT3GEJ5OdOfp6vlTjEoG2ufXKFcEfUJuKEMI=; b=QNrcJSlp2Ay+C5BLRc0pmjEFWf367ak9N3/QSfqxMXQFErPTfX/3Ki12L13YV4rfvY dPixrDSkSOWV5fQ9LsKojx5XKuzrV6zKDgEJHUvPrB0GxH4Qj2kx1tSva1DbTIHd4UIF 5N593L67RdmK7h4KfaxGnqurfL3HElD15XVSlIYw90uuN22XCXmT0UMkL/m+SEKWqGR7 pEni/Qx57Spv0+z2k2eO9JN4A2nAeqrv3iaxZHJ2hqJnUUllkrZwi9X2cnzNSC5gw+YX 5tA3r1HlIUOsjSV2QGGeXHCbJE/5SfCe61fL18lD+iUMIfkGd1gZKgZFhJa4hxxw08Gq hjww== X-Gm-Message-State: AOJu0YxS3iGNq9qAZn3Mp5H279NtRVvxf5SjRGb4wvvRmT6YlZmGoXgk AY4ouGV9SVhIog7s4rb7Zd3HqA== X-Google-Smtp-Source: AGHT+IG0HwQnerR7/Jt+ZlEFWrzo/YHVAHF7jx+cIf1OJDRkcHOwo7Ixn6i8JDQMCLC5UL0HXqh+Aw== X-Received: by 2002:a05:600c:2286:b0:3fa:8c68:4aba with SMTP id 6-20020a05600c228600b003fa8c684abamr6193638wmf.25.1691389430634; Sun, 06 Aug 2023 23:23:50 -0700 (PDT) Received: from [192.168.1.20] ([178.197.222.113]) by smtp.gmail.com with ESMTPSA id t25-20020a1c7719000000b003fe2b6d64c8sm13923548wmi.21.2023.08.06.23.23.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 06 Aug 2023 23:23:50 -0700 (PDT) Message-ID: <6bf91ced-076f-ecc1-f626-f531f7d991bd@linaro.org> Date: Mon, 7 Aug 2023 08:23:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH 4/9] regulator: dt-bindings: mediatek: Add MT6366 PMIC Content-Language: en-US To: Chen-Yu Tsai , Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Mark Brown Cc: Zhiyong Tao , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20230803074249.3065586-1-wenst@chromium.org> <20230803074249.3065586-5-wenst@chromium.org> From: Krzysztof Kozlowski In-Reply-To: <20230803074249.3065586-5-wenst@chromium.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 03/08/2023 09:42, Chen-Yu Tsai wrote: > From: Zhiyong Tao > > The MediaTek MT6366 PMIC is similar to the MT6358 PMIC. It is designed > to be paired with the MediaTek MT8186 SoC. It has 9 buck regulators and > 29 LDO regulators, not counting ones that feed internally and basically > have no controls. The regulators are named after their intended usage > for the SoC and system design, thus not named generically as ldoX or > dcdcX, but as vcn33 or vgpu. > > Add a binding document describing all the regulators and their supplies. > > Signed-off-by: Zhiyong Tao > [wens@chromium.org: major rework and added commit message] > Signed-off-by: Chen-Yu Tsai > --- > Changes since Zhiyong's last version (v4) [1]: > - simplified regulator names > - added descriptions to regulators > - removed bogus regulators (*_sshub) > - merged vcn33-wifi and vcn33-bt as vcn33 > - added missing regulators (vm18, vmddr, vsram-core) > - cut down examples to a handful of cases and made them complete > - expanded commit message a lot > > [1] https://lore.kernel.org/linux-arm-kernel/20220823123745.14061-1-zhiyong.tao@mediatek.com/ > > .../regulator/mediatek,mt6366-regulator.yaml | 154 ++++++++++++++++++ > 1 file changed, 154 insertions(+) > create mode 100644 Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.yaml > > diff --git a/Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.yaml b/Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.yaml > new file mode 100644 > index 000000000000..715c6ffcb3ab > --- /dev/null > +++ b/Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.yaml > @@ -0,0 +1,154 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/regulator/mediatek,mt6366-regulator.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MT6366 Regulator from MediaTek Integrated > + > +maintainers: > + - Zhiyong Tao > + > +description: | > + Regulator part of the MT6366 PMIC. This node should be under the PMIC's > + device node. > + > +properties: > + compatible: > + const: mediatek,mt6366-regulator > + > + vsys_ldo1-supply: Don't use underscores in property names. Only hyphens, if needed. > + description: Supply for LDOs vfe28, vxo22, vcn28, vaux18, vaud28, vsim1, vusb, vbif28 > + vsys_ldo2-supply: Best regards, Krzysztof