devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Marc Gonzalez <mgonzalez@freebox.fr>,
	Bjorn Andersson <andersson@kernel.org>,
	Jeffrey Hugo <quic_jhugo@quicinc.com>,
	Stanimir Varbanov <stanimir.k.varbanov@gmail.com>,
	Vikash Garodia <quic_vgarodia@quicinc.com>,
	Bryan O Donoghue <bryan.odonoghue@linaro.org>
Cc: MSM <linux-arm-msm@vger.kernel.org>,
	linux-media <linux-media@vger.kernel.org>,
	DT <devicetree@vger.kernel.org>,
	Pierre-Hugues Husson <phhusson@freebox.fr>,
	Arnaud Vrac <avrac@freebox.fr>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>
Subject: Re: [PATCH v1 1/3] dt-bindings: media: add qcom,msm8998-venus
Date: Tue, 30 Apr 2024 12:16:02 +0200	[thread overview]
Message-ID: <6bf981a3-2613-4b5e-aa5f-3a83f9bfaf47@linaro.org> (raw)
In-Reply-To: <9655f9ca-91e5-42c5-9a08-cb342179dc4c@linaro.org>

On 30.04.2024 9:54 AM, Krzysztof Kozlowski wrote:
> On 29/04/2024 18:15, Marc Gonzalez wrote:
>> Add YAML binding for Qualcomm MSM8998 Venus HW video encode and decode.
>> (Based on qcom,msm8996-venus.yaml)
>>
>> Signed-off-by: Marc Gonzalez <mgonzalez@freebox.fr>
>> ---

[...]

>> +
>> +    required:
>> +      - compatible
>> +      - clocks
>> +      - clock-names
>> +      - power-domains
>> +
>> +    additionalProperties: false
> 
> In nested blocks, put it after the type:object, for readability.
> 
>> +
> 
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

https://lore.kernel.org/linux-arm-msm/ba40de82-b308-67b1-5751-bb2d95f2b8a5@linaro.org/

We've since established that the video-encoder/decoder subnodes are bogus

Konrad

  reply	other threads:[~2024-04-30 10:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-29 16:14 [PATCH v1 0/3] Add support for qcom msm8998-venus (HW vdec / venc) Marc Gonzalez
2024-04-29 16:15 ` [PATCH v1 1/3] dt-bindings: media: add qcom,msm8998-venus Marc Gonzalez
2024-04-29 23:06   ` Bryan O'Donoghue
2024-04-30  7:54   ` Krzysztof Kozlowski
2024-04-30 10:16     ` Konrad Dybcio [this message]
2024-04-29 16:17 ` [PATCH v1 2/3] arm64: dts: qcom: msm8998: add venus node Marc Gonzalez
2024-04-29 23:16   ` Bryan O'Donoghue
2024-04-29 16:19 ` [PATCH v1 3/3] media: venus: add MSM8998 support Marc Gonzalez
2024-04-29 23:19   ` Bryan O'Donoghue
2024-04-30 14:14     ` Marc Gonzalez
2024-04-30 15:53 ` [PATCH v1 0/3] Add support for qcom msm8998-venus (HW vdec / venc) Marc Gonzalez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6bf981a3-2613-4b5e-aa5f-3a83f9bfaf47@linaro.org \
    --to=konrad.dybcio@linaro.org \
    --cc=andersson@kernel.org \
    --cc=avrac@freebox.fr \
    --cc=bryan.odonoghue@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mgonzalez@freebox.fr \
    --cc=phhusson@freebox.fr \
    --cc=quic_jhugo@quicinc.com \
    --cc=quic_vgarodia@quicinc.com \
    --cc=robh+dt@kernel.org \
    --cc=stanimir.k.varbanov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).