From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f54.google.com (mail-oa1-f54.google.com [209.85.160.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C67D1EA6F for ; Thu, 14 Nov 2024 14:47:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731595662; cv=none; b=TzBuBYs8PgB+Mt1lBoM+/fYPUYbXL5sqHwq7cxb5TEze9u1WCM4+UwRJF0eBi6Ntz5J9EWQ6dYNMa5drTBMw+LDGkYnlWMWhFXqS4vFUoXj/gv0tcoEpq9dmxewsW6M0693AW0/28wjRL4+vG0P1nGhHiJVpTm9QvS7CrQuuI9o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731595662; c=relaxed/simple; bh=D87S/2iSrjHxhqbhQk/BOfUi6afFT8Obf1Ai+4fFrJg=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=KDmlA0v5mfcqigkQsr2usMlSwXW3E+mlaDY2wGKjqexVCJq/wqzmpBkvffn4/GkNGYTz5vuO1vdbMWoC/jFrqZH6GKhR1Ng0FVWZ6KO94tYAc72s61UtiAPPnLJ10U9WttoMDyl7h/w3kllshiUt29oJjUFXGsQHiGi3xgtQ4TU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=rllvoBDo; arc=none smtp.client-ip=209.85.160.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="rllvoBDo" Received: by mail-oa1-f54.google.com with SMTP id 586e51a60fabf-296252514c2so46645fac.3 for ; Thu, 14 Nov 2024 06:47:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1731595658; x=1732200458; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=cLiPIwku9aoV6FsuTm9hcLzf19Zpgfkgh5a8Q3+4iME=; b=rllvoBDowtvMqUajVenWBtI6Kk8TXpIzLTMwdi5NrHAcJN7a0uZEbfEi0va+PA/ppW uB2PkItf9GOp4KKSb4rfcA22I0m7fb+s6I9QMV2ELkJeOGvb70VHdwoF0umMtNBb4u1L eqrpHE1/ooKJyFYDvDQpS8filBbTD4IeX8KCKQVjvHehdKq8UgjLNK/ceGQdPfsphtDy lzaukoeYQmaPvx/ctYaSjc2YEsiBm5BXlPa6AgC8lzBYr7EyKSYdAfzUR6b6eIPMoJLf t9z6B4uhzzezr2uURl3lSvWWz3KzGWMzYCtzLjxSOfINfEOk7I4FgY4lAcGyJQvEnTbr KhpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731595658; x=1732200458; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cLiPIwku9aoV6FsuTm9hcLzf19Zpgfkgh5a8Q3+4iME=; b=OAz6q8a+B9rhU44fmu0ZIp0Fnf2wKW/HTbuHbonjk8zWQ6dVWS0QGQ1uVU+uZAkjxt wKIslDjnJCbq7NJAZzrW10Sut/rsObSzjmupvpKCrGNzpPZsXQXDR7J6gfQmqtYNeuof AK5/i7Yv4qzC51tltGvNm5mgqxnESzD9QEpDwyJ0/2DTU57QRhq/Str/WtJHz9wq2prL TVlm+048jJsGNauCv0Mn+wpQyoVhPQJwVAbXTUNi/8f/JGTIJaP+anMUi47NSOnKNjhK hNmp2DHgjM0NGZKtdrm1kFuyeAUS9ZL53MkeRZgZW9w9aqC1okmVcPTcnZHwhZ0q2/Sl pAGg== X-Forwarded-Encrypted: i=1; AJvYcCWd8daPTf+cN3x9wdlM2h/IxaiKozz+YIRnTQYjQrE6gqhvDvFuKWqpLwkMkrVsBTAtmoGxj3mIGB39@vger.kernel.org X-Gm-Message-State: AOJu0YyVx1mFwJZ2Z3NGfQH3C+dlGwjYjhR7FVgYPB5Pz5DZw200iMC7 ShE8fE6XmSxOvtEYf6Um1fa8gAIL9IuiFR3liPTn5QBOGFuYHK+LdbS6Ov4A6eYmyby1nADfNvd n X-Google-Smtp-Source: AGHT+IHBm+MOajtqOgOa+JMdH4SOD2OUJSIzHMmwYlCDI8AZFsAhsMFjNqy7TNSKark8sXQo5dShXg== X-Received: by 2002:a05:6870:bac8:b0:288:64a4:fbea with SMTP id 586e51a60fabf-295e9042896mr8021848fac.42.1731595658412; Thu, 14 Nov 2024 06:47:38 -0800 (PST) Received: from [192.168.0.142] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-5eea0230e35sm347718eaf.33.2024.11.14.06.47.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Nov 2024 06:47:37 -0800 (PST) Message-ID: <6c034f2c-1f07-4dfb-8e65-dbf41e803f01@baylibre.com> Date: Thu, 14 Nov 2024 08:47:36 -0600 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 8/8] iio: adc: ad4851: add ad485x driver To: "Miclaus, Antoniu" , "jic23@kernel.org" , "robh@kernel.org" , "conor+dt@kernel.org" , "linux-iio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-pwm@vger.kernel.org" References: <20241111121203.3699-1-antoniu.miclaus@analog.com> <20241111121203.3699-9-antoniu.miclaus@analog.com> <4b48ae8e-4eba-4d86-af8b-2b749c53639f@baylibre.com> Content-Language: en-US From: David Lechner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/14/24 4:39 AM, Miclaus, Antoniu wrote: >> On 11/11/24 6:12 AM, Antoniu Miclaus wrote: >>> Add support for the AD485X a fully buffered, 8-channel simultaneous >>> sampling, 16/20-bit, 1 MSPS data acquisition system (DAS) with >>> differential, wide common-mode range inputs. >>> >>> Signed-off-by: Antoniu Miclaus >>> --- >>> changes in v6 (implemented most of the review comments in v5): >> What is the plan for addressing the rest of the comments? > For the rest of the comments I think I replied inline in the previous series. > I didn't look very close yet, but at a quick glance, I saw that all scan_type are still only signed, there is no unsigned for when the channels are used as single-ended. And the scan_index ordering is still wrong. This makes me doubt that buffered reads are working correctly for all configurations.