From: Dylan Van Assche <me@dylanvanassche.be>
To: Chen-Yu Tsai <wens@csie.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Maxime Ripard <mripard@kernel.org>,
Jernej Skrabec <jernej.skrabec@siol.net>,
devicetree <devicetree@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm64: dts: sun50i-a64-pinephone: add 'pine64, pinephone' to the compatible list
Date: Wed, 30 Dec 2020 11:41:56 +0100 [thread overview]
Message-ID: <6c27906cf7f67a4fc39f2d3898fb843005f1e4e6.camel@dylanvanassche.be> (raw)
In-Reply-To: <CAGb2v67C+hQyqjrx9A9MiyjEQdeVv+9BgrzxcuiHwf2e8JTswg@mail.gmail.com>
Hi,
Good point!
I will send a new version of the patch soon.
Kind regards,
Dylan Van Assche
On Wed, 2020-12-30 at 17:38 +0800, Chen-Yu Tsai wrote:
> On Tue, Dec 29, 2020 at 11:42 PM Dylan Van Assche <
> me@dylanvanassche.be> wrote:
> > All revisions of the PinePhone share most of the hardware.
> > This patch makes it easier to detect PinePhone hardware without
> > having to check for each possible revision.
>
> Sounds good.
>
> > Signed-off-by: Dylan Van Assche <me@dylanvanassche.be>
> > ---
> > arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.0.dts | 2 +-
> > arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.1.dts | 2 +-
> > arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.2.dts | 2 +-
>
> Please also update the DT binding file:
>
> Documentation/devicetree/bindings/arm/sunxi.yaml
>
> ChenYu
prev parent reply other threads:[~2020-12-30 10:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-29 15:41 [PATCH] arm64: dts: sun50i-a64-pinephone: add 'pine64, pinephone' to the compatible list Dylan Van Assche
2020-12-30 9:38 ` Chen-Yu Tsai
2020-12-30 10:41 ` Dylan Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c27906cf7f67a4fc39f2d3898fb843005f1e4e6.camel@dylanvanassche.be \
--to=me@dylanvanassche.be \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@siol.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mripard@kernel.org \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).