From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: hui liu <quic_huliu@quicinc.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] arm64: dts: qcom: qcm6490-idp: Add definition for three LEDs
Date: Mon, 15 Jan 2024 11:26:29 +0100 [thread overview]
Message-ID: <6c29ce72-e303-406a-bb75-5b36b0cd8ee4@linaro.org> (raw)
In-Reply-To: <e16f5ff1-9b12-4f90-89d5-f95cbfb859e7@quicinc.com>
On 15/01/2024 11:18, hui liu wrote:
>
>
> On 1/15/2024 5:56 PM, Dmitry Baryshkov wrote:
>> On Mon, 15 Jan 2024 at 11:48, Hui Liu via B4 Relay
>> <devnull+quic_huliu.quicinc.com@kernel.org> wrote:
>>>
>>> From: Hui Liu <quic_huliu@quicinc.com>
>>>
>>> Add definition for three LEDs to make sure they can
>>> be enabled base on QCOM LPG LED driver.
>>
>> The "function" property is still placed incorrectly. Posting the next
>> iteration before concluding the discussion on the previous one is not
>> the best idea.
> Do you mean I should update it as below? Seems there is no consumer to
> use the function config, do we need to add now?
Paste the output of dtbs_check for your board (or CHECK_DTBS=y for your
Makefile target).
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-01-15 10:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-15 9:48 [PATCH v5] arm64: dts: qcom: qcm6490-idp: Add definition for three LEDs Hui Liu via B4 Relay
2024-01-15 9:56 ` Dmitry Baryshkov
2024-01-15 10:18 ` hui liu
2024-01-15 10:26 ` Krzysztof Kozlowski [this message]
2024-01-17 3:02 ` hui liu
2024-01-17 3:41 ` Dmitry Baryshkov
2024-01-18 2:06 ` hui liu
2024-01-22 5:42 ` hui liu
2024-01-22 6:25 ` hui liu
2024-01-22 13:37 ` Dmitry Baryshkov
2024-01-29 2:06 ` hui liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c29ce72-e303-406a-bb75-5b36b0cd8ee4@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_huliu@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).