* [PATCH v5] arm64: dts: qcom: qcm6490-idp: Add definition for three LEDs @ 2024-01-15 9:48 Hui Liu via B4 Relay 2024-01-15 9:56 ` Dmitry Baryshkov 0 siblings, 1 reply; 11+ messages in thread From: Hui Liu via B4 Relay @ 2024-01-15 9:48 UTC (permalink / raw) To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley Cc: linux-arm-msm, devicetree, linux-kernel, Hui Liu From: Hui Liu <quic_huliu@quicinc.com> Add definition for three LEDs to make sure they can be enabled base on QCOM LPG LED driver. Signed-off-by: Hui Liu <quic_huliu@quicinc.com> --- Changes in v5: - Rephrased commit text, replaced qcs6490-idp to qcm6490-idp. - Removed the unnecessary full. - Link to v4: https://lore.kernel.org/r/20240112-lpg-v4-1-c4004026686b@quicinc.com Changes in v4: - Removed "label" definition and added "function" definition. - Link to v3: https://lore.kernel.org/r/20231215-lpg-v3-1-4e2db0c6df5f@quicinc.com Changes in v3: - Rephrased commit text and updated the nodes to qcm6490-idp board file. - Link to v2: https://lore.kernel.org/all/20231110-qcom_leds-v2-1-3cad1fbbc65a@quicinc.com/ Changes in v2: - Rephrased commit text and updated the nodes to board file. - Link to v1: https://lore.kernel.org/r/20231108-qcom_leds-v1-1-c3e1c8572cb0@quicinc.com --- arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts index 37c91fdf3ab9..8268fad505e7 100644 --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts @@ -5,6 +5,7 @@ /dts-v1/; +#include <dt-bindings/leds/common.h> #include <dt-bindings/regulator/qcom,rpmh-regulator.h> #include "sc7280.dtsi" #include "pm7325.dtsi" @@ -414,6 +415,28 @@ vreg_bob_3p296: bob { }; }; +&pm8350c_pwm { + function = LED_FUNCTION_STATUS; + #address-cells = <1>; + #size-cells = <0>; + status = "okay"; + + led@1 { + reg = <1>; + color = <LED_COLOR_ID_RED>; + }; + + led@2 { + reg = <2>; + color = <LED_COLOR_ID_GREEN>; + }; + + led@3 { + reg = <3>; + color = <LED_COLOR_ID_BLUE>; + }; +}; + &qupv3_id_0 { status = "okay"; }; --- base-commit: 17cb8a20bde66a520a2ca7aad1063e1ce7382240 change-id: 20231215-lpg-4aadd374811a Best regards, -- Hui Liu <quic_huliu@quicinc.com> ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH v5] arm64: dts: qcom: qcm6490-idp: Add definition for three LEDs 2024-01-15 9:48 [PATCH v5] arm64: dts: qcom: qcm6490-idp: Add definition for three LEDs Hui Liu via B4 Relay @ 2024-01-15 9:56 ` Dmitry Baryshkov 2024-01-15 10:18 ` hui liu 0 siblings, 1 reply; 11+ messages in thread From: Dmitry Baryshkov @ 2024-01-15 9:56 UTC (permalink / raw) To: quic_huliu Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree, linux-kernel On Mon, 15 Jan 2024 at 11:48, Hui Liu via B4 Relay <devnull+quic_huliu.quicinc.com@kernel.org> wrote: > > From: Hui Liu <quic_huliu@quicinc.com> > > Add definition for three LEDs to make sure they can > be enabled base on QCOM LPG LED driver. The "function" property is still placed incorrectly. Posting the next iteration before concluding the discussion on the previous one is not the best idea. > > Signed-off-by: Hui Liu <quic_huliu@quicinc.com> > --- > Changes in v5: > - Rephrased commit text, replaced qcs6490-idp to qcm6490-idp. > - Removed the unnecessary full. > - Link to v4: https://lore.kernel.org/r/20240112-lpg-v4-1-c4004026686b@quicinc.com > > Changes in v4: > - Removed "label" definition and added "function" definition. > - Link to v3: https://lore.kernel.org/r/20231215-lpg-v3-1-4e2db0c6df5f@quicinc.com > > Changes in v3: > - Rephrased commit text and updated the nodes to qcm6490-idp board file. > - Link to v2: https://lore.kernel.org/all/20231110-qcom_leds-v2-1-3cad1fbbc65a@quicinc.com/ > > Changes in v2: > - Rephrased commit text and updated the nodes to board file. > - Link to v1: https://lore.kernel.org/r/20231108-qcom_leds-v1-1-c3e1c8572cb0@quicinc.com > --- > arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 23 +++++++++++++++++++++++ > 1 file changed, 23 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts > index 37c91fdf3ab9..8268fad505e7 100644 > --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts > +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts > @@ -5,6 +5,7 @@ > > /dts-v1/; > > +#include <dt-bindings/leds/common.h> > #include <dt-bindings/regulator/qcom,rpmh-regulator.h> > #include "sc7280.dtsi" > #include "pm7325.dtsi" > @@ -414,6 +415,28 @@ vreg_bob_3p296: bob { > }; > }; > > +&pm8350c_pwm { > + function = LED_FUNCTION_STATUS; > + #address-cells = <1>; > + #size-cells = <0>; > + status = "okay"; > + > + led@1 { > + reg = <1>; > + color = <LED_COLOR_ID_RED>; > + }; > + > + led@2 { > + reg = <2>; > + color = <LED_COLOR_ID_GREEN>; > + }; > + > + led@3 { > + reg = <3>; > + color = <LED_COLOR_ID_BLUE>; > + }; > +}; > + > &qupv3_id_0 { > status = "okay"; > }; > > --- > base-commit: 17cb8a20bde66a520a2ca7aad1063e1ce7382240 > change-id: 20231215-lpg-4aadd374811a > > Best regards, > -- > Hui Liu <quic_huliu@quicinc.com> > > -- With best wishes Dmitry ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v5] arm64: dts: qcom: qcm6490-idp: Add definition for three LEDs 2024-01-15 9:56 ` Dmitry Baryshkov @ 2024-01-15 10:18 ` hui liu 2024-01-15 10:26 ` Krzysztof Kozlowski 0 siblings, 1 reply; 11+ messages in thread From: hui liu @ 2024-01-15 10:18 UTC (permalink / raw) To: Dmitry Baryshkov Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree, linux-kernel On 1/15/2024 5:56 PM, Dmitry Baryshkov wrote: > On Mon, 15 Jan 2024 at 11:48, Hui Liu via B4 Relay > <devnull+quic_huliu.quicinc.com@kernel.org> wrote: >> >> From: Hui Liu <quic_huliu@quicinc.com> >> >> Add definition for three LEDs to make sure they can >> be enabled base on QCOM LPG LED driver. > > The "function" property is still placed incorrectly. Posting the next > iteration before concluding the discussion on the previous one is not > the best idea. Do you mean I should update it as below? Seems there is no consumer to use the function config, do we need to add now? pm8350c_pwm { + function = LED_FUNCTION_STATUS; + #address-cells = <1>; + #size-cells = <0>; + status = "okay"; + + led@1 { + reg = <1>; + color = <LED_COLOR_ID_RED>; + function = LED_FUNCTION_STATUS; + }; + ... > >> >> Signed-off-by: Hui Liu <quic_huliu@quicinc.com> >> --- >> Changes in v5: >> - Rephrased commit text, replaced qcs6490-idp to qcm6490-idp. >> - Removed the unnecessary full. >> - Link to v4: https://lore.kernel.org/r/20240112-lpg-v4-1-c4004026686b@quicinc.com >> >> Changes in v4: >> - Removed "label" definition and added "function" definition. >> - Link to v3: https://lore.kernel.org/r/20231215-lpg-v3-1-4e2db0c6df5f@quicinc.com >> >> Changes in v3: >> - Rephrased commit text and updated the nodes to qcm6490-idp board file. >> - Link to v2: https://lore.kernel.org/all/20231110-qcom_leds-v2-1-3cad1fbbc65a@quicinc.com/ >> >> Changes in v2: >> - Rephrased commit text and updated the nodes to board file. >> - Link to v1: https://lore.kernel.org/r/20231108-qcom_leds-v1-1-c3e1c8572cb0@quicinc.com >> --- >> arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 23 +++++++++++++++++++++++ >> 1 file changed, 23 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts >> index 37c91fdf3ab9..8268fad505e7 100644 >> --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts >> +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts >> @@ -5,6 +5,7 @@ >> >> /dts-v1/; >> >> +#include <dt-bindings/leds/common.h> >> #include <dt-bindings/regulator/qcom,rpmh-regulator.h> >> #include "sc7280.dtsi" >> #include "pm7325.dtsi" >> @@ -414,6 +415,28 @@ vreg_bob_3p296: bob { >> }; >> }; >> >> +&pm8350c_pwm { >> + function = LED_FUNCTION_STATUS; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + status = "okay"; >> + >> + led@1 { >> + reg = <1>; >> + color = <LED_COLOR_ID_RED>; >> + }; >> + >> + led@2 { >> + reg = <2>; >> + color = <LED_COLOR_ID_GREEN>; >> + }; >> + >> + led@3 { >> + reg = <3>; >> + color = <LED_COLOR_ID_BLUE>; >> + }; >> +}; >> + >> &qupv3_id_0 { >> status = "okay"; >> }; >> >> --- >> base-commit: 17cb8a20bde66a520a2ca7aad1063e1ce7382240 >> change-id: 20231215-lpg-4aadd374811a >> >> Best regards, >> -- >> Hui Liu <quic_huliu@quicinc.com> >> >> > > ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v5] arm64: dts: qcom: qcm6490-idp: Add definition for three LEDs 2024-01-15 10:18 ` hui liu @ 2024-01-15 10:26 ` Krzysztof Kozlowski 2024-01-17 3:02 ` hui liu 0 siblings, 1 reply; 11+ messages in thread From: Krzysztof Kozlowski @ 2024-01-15 10:26 UTC (permalink / raw) To: hui liu, Dmitry Baryshkov Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree, linux-kernel On 15/01/2024 11:18, hui liu wrote: > > > On 1/15/2024 5:56 PM, Dmitry Baryshkov wrote: >> On Mon, 15 Jan 2024 at 11:48, Hui Liu via B4 Relay >> <devnull+quic_huliu.quicinc.com@kernel.org> wrote: >>> >>> From: Hui Liu <quic_huliu@quicinc.com> >>> >>> Add definition for three LEDs to make sure they can >>> be enabled base on QCOM LPG LED driver. >> >> The "function" property is still placed incorrectly. Posting the next >> iteration before concluding the discussion on the previous one is not >> the best idea. > Do you mean I should update it as below? Seems there is no consumer to > use the function config, do we need to add now? Paste the output of dtbs_check for your board (or CHECK_DTBS=y for your Makefile target). Best regards, Krzysztof ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v5] arm64: dts: qcom: qcm6490-idp: Add definition for three LEDs 2024-01-15 10:26 ` Krzysztof Kozlowski @ 2024-01-17 3:02 ` hui liu 2024-01-17 3:41 ` Dmitry Baryshkov 0 siblings, 1 reply; 11+ messages in thread From: hui liu @ 2024-01-17 3:02 UTC (permalink / raw) To: Krzysztof Kozlowski, Dmitry Baryshkov Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree, linux-kernel, quic_fenglinw On 1/15/2024 6:26 PM, Krzysztof Kozlowski wrote: > On 15/01/2024 11:18, hui liu wrote: >> >> >> On 1/15/2024 5:56 PM, Dmitry Baryshkov wrote: >>> On Mon, 15 Jan 2024 at 11:48, Hui Liu via B4 Relay >>> <devnull+quic_huliu.quicinc.com@kernel.org> wrote: >>>> >>>> From: Hui Liu <quic_huliu@quicinc.com> >>>> >>>> Add definition for three LEDs to make sure they can >>>> be enabled base on QCOM LPG LED driver. >>> >>> The "function" property is still placed incorrectly. Posting the next >>> iteration before concluding the discussion on the previous one is not >>> the best idea. >> Do you mean I should update it as below? Seems there is no consumer to >> use the function config, do we need to add now? > > Paste the output of dtbs_check for your board (or CHECK_DTBS=y for your > Makefile target). I checked the dt-binding file of LPG LED, I will update the dts as below, if you think it's correct, I will push v6. +&pm8350c_pwm { + #address-cells = <1>; + #size-cells = <0>; + status = "okay"; + + led@1 { + reg = <1>; + color = <LED_COLOR_ID_RED>; + function = LED_FUNCTION_STATUS; + }; + + led@2 { + reg = <2>; + color = <LED_COLOR_ID_GREEN>; + function = LED_FUNCTION_STATUS; + }; + + led@3 { + reg = <3>; + color = <LED_COLOR_ID_BLUE>; + function = LED_FUNCTION_STATUS; + }; +}; + Thanks, Hui > > Best regards, > Krzysztof > ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v5] arm64: dts: qcom: qcm6490-idp: Add definition for three LEDs 2024-01-17 3:02 ` hui liu @ 2024-01-17 3:41 ` Dmitry Baryshkov 2024-01-18 2:06 ` hui liu 0 siblings, 1 reply; 11+ messages in thread From: Dmitry Baryshkov @ 2024-01-17 3:41 UTC (permalink / raw) To: hui liu Cc: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree, linux-kernel, quic_fenglinw On Wed, 17 Jan 2024 at 05:02, hui liu <quic_huliu@quicinc.com> wrote: > > > > On 1/15/2024 6:26 PM, Krzysztof Kozlowski wrote: > > On 15/01/2024 11:18, hui liu wrote: > >> > >> > >> On 1/15/2024 5:56 PM, Dmitry Baryshkov wrote: > >>> On Mon, 15 Jan 2024 at 11:48, Hui Liu via B4 Relay > >>> <devnull+quic_huliu.quicinc.com@kernel.org> wrote: > >>>> > >>>> From: Hui Liu <quic_huliu@quicinc.com> > >>>> > >>>> Add definition for three LEDs to make sure they can > >>>> be enabled base on QCOM LPG LED driver. > >>> > >>> The "function" property is still placed incorrectly. Posting the next > >>> iteration before concluding the discussion on the previous one is not > >>> the best idea. > >> Do you mean I should update it as below? Seems there is no consumer to > >> use the function config, do we need to add now? > > > > Paste the output of dtbs_check for your board (or CHECK_DTBS=y for your > > Makefile target). > I checked the dt-binding file of LPG LED, I will update the dts as > below, if you think it's correct, I will push v6. Is there any reason why you are defining three different LEDs instead of multi-led with three components? > > +&pm8350c_pwm { > + #address-cells = <1>; > + #size-cells = <0>; > + status = "okay"; > + > + led@1 { > + reg = <1>; > + color = <LED_COLOR_ID_RED>; > + function = LED_FUNCTION_STATUS; > + }; > + > + led@2 { > + reg = <2>; > + color = <LED_COLOR_ID_GREEN>; > + function = LED_FUNCTION_STATUS; > + }; > + > + led@3 { > + reg = <3>; > + color = <LED_COLOR_ID_BLUE>; > + function = LED_FUNCTION_STATUS; > + }; > +}; -- With best wishes Dmitry ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v5] arm64: dts: qcom: qcm6490-idp: Add definition for three LEDs 2024-01-17 3:41 ` Dmitry Baryshkov @ 2024-01-18 2:06 ` hui liu 2024-01-22 5:42 ` hui liu 0 siblings, 1 reply; 11+ messages in thread From: hui liu @ 2024-01-18 2:06 UTC (permalink / raw) To: Dmitry Baryshkov Cc: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree, linux-kernel, quic_fenglinw On 1/17/2024 11:41 AM, Dmitry Baryshkov wrote: > On Wed, 17 Jan 2024 at 05:02, hui liu <quic_huliu@quicinc.com> wrote: >> >> >> >> On 1/15/2024 6:26 PM, Krzysztof Kozlowski wrote: >>> On 15/01/2024 11:18, hui liu wrote: >>>> >>>> >>>> On 1/15/2024 5:56 PM, Dmitry Baryshkov wrote: >>>>> On Mon, 15 Jan 2024 at 11:48, Hui Liu via B4 Relay >>>>> <devnull+quic_huliu.quicinc.com@kernel.org> wrote: >>>>>> >>>>>> From: Hui Liu <quic_huliu@quicinc.com> >>>>>> >>>>>> Add definition for three LEDs to make sure they can >>>>>> be enabled base on QCOM LPG LED driver. >>>>> >>>>> The "function" property is still placed incorrectly. Posting the next >>>>> iteration before concluding the discussion on the previous one is not >>>>> the best idea. >>>> Do you mean I should update it as below? Seems there is no consumer to >>>> use the function config, do we need to add now? >>> >>> Paste the output of dtbs_check for your board (or CHECK_DTBS=y for your >>> Makefile target). >> I checked the dt-binding file of LPG LED, I will update the dts as >> below, if you think it's correct, I will push v6. > > Is there any reason why you are defining three different LEDs instead > of multi-led with three components? In the HW design, they are three seprete LEDs, there are three LEDs on device. why do we need to add for multi-led? Thanks, Hui > >> >> +&pm8350c_pwm { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + status = "okay"; >> + >> + led@1 { >> + reg = <1>; >> + color = <LED_COLOR_ID_RED>; >> + function = LED_FUNCTION_STATUS; >> + }; >> + >> + led@2 { >> + reg = <2>; >> + color = <LED_COLOR_ID_GREEN>; >> + function = LED_FUNCTION_STATUS; >> + }; >> + >> + led@3 { >> + reg = <3>; >> + color = <LED_COLOR_ID_BLUE>; >> + function = LED_FUNCTION_STATUS; >> + }; >> +}; > > > ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v5] arm64: dts: qcom: qcm6490-idp: Add definition for three LEDs 2024-01-18 2:06 ` hui liu @ 2024-01-22 5:42 ` hui liu 2024-01-22 6:25 ` hui liu 0 siblings, 1 reply; 11+ messages in thread From: hui liu @ 2024-01-22 5:42 UTC (permalink / raw) To: Dmitry Baryshkov Cc: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree, linux-kernel, quic_fenglinw On 1/18/2024 10:06 AM, hui liu wrote: > > > On 1/17/2024 11:41 AM, Dmitry Baryshkov wrote: >> On Wed, 17 Jan 2024 at 05:02, hui liu <quic_huliu@quicinc.com> wrote: >>> >>> >>> >>> On 1/15/2024 6:26 PM, Krzysztof Kozlowski wrote: >>>> On 15/01/2024 11:18, hui liu wrote: >>>>> >>>>> >>>>> On 1/15/2024 5:56 PM, Dmitry Baryshkov wrote: >>>>>> On Mon, 15 Jan 2024 at 11:48, Hui Liu via B4 Relay >>>>>> <devnull+quic_huliu.quicinc.com@kernel.org> wrote: >>>>>>> >>>>>>> From: Hui Liu <quic_huliu@quicinc.com> >>>>>>> >>>>>>> Add definition for three LEDs to make sure they can >>>>>>> be enabled base on QCOM LPG LED driver. >>>>>> >>>>>> The "function" property is still placed incorrectly. Posting the next >>>>>> iteration before concluding the discussion on the previous one is not >>>>>> the best idea. >>>>> Do you mean I should update it as below? Seems there is no consumer to >>>>> use the function config, do we need to add now? >>>> >>>> Paste the output of dtbs_check for your board (or CHECK_DTBS=y for your >>>> Makefile target). >>> I checked the dt-binding file of LPG LED, I will update the dts as >>> below, if you think it's correct, I will push v6. >> >> Is there any reason why you are defining three different LEDs instead >> of multi-led with three components? > Hi Dmitry, If there is no other issue, can I push the V6? Thanks, Hui > In the HW design, they are three seprete LEDs, there are three LEDs on > device. why do we need to add for multi-led? > > Thanks, > Hui >> >>> >>> +&pm8350c_pwm { >>> + #address-cells = <1>; >>> + #size-cells = <0>; >>> + status = "okay"; >>> + >>> + led@1 { >>> + reg = <1>; >>> + color = <LED_COLOR_ID_RED>; >>> + function = LED_FUNCTION_STATUS; >>> + }; >>> + >>> + led@2 { >>> + reg = <2>; >>> + color = <LED_COLOR_ID_GREEN>; >>> + function = LED_FUNCTION_STATUS; >>> + }; >>> + >>> + led@3 { >>> + reg = <3>; >>> + color = <LED_COLOR_ID_BLUE>; >>> + function = LED_FUNCTION_STATUS; >>> + }; >>> +}; >> >> >> ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v5] arm64: dts: qcom: qcm6490-idp: Add definition for three LEDs 2024-01-22 5:42 ` hui liu @ 2024-01-22 6:25 ` hui liu 2024-01-22 13:37 ` Dmitry Baryshkov 0 siblings, 1 reply; 11+ messages in thread From: hui liu @ 2024-01-22 6:25 UTC (permalink / raw) To: Dmitry Baryshkov Cc: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree, linux-kernel, quic_fenglinw On 1/22/2024 1:42 PM, hui liu wrote: > > > On 1/18/2024 10:06 AM, hui liu wrote: >> >> >> On 1/17/2024 11:41 AM, Dmitry Baryshkov wrote: >>> On Wed, 17 Jan 2024 at 05:02, hui liu <quic_huliu@quicinc.com> wrote: >>>> >>>> >>>> >>>> On 1/15/2024 6:26 PM, Krzysztof Kozlowski wrote: >>>>> On 15/01/2024 11:18, hui liu wrote: >>>>>> >>>>>> >>>>>> On 1/15/2024 5:56 PM, Dmitry Baryshkov wrote: >>>>>>> On Mon, 15 Jan 2024 at 11:48, Hui Liu via B4 Relay >>>>>>> <devnull+quic_huliu.quicinc.com@kernel.org> wrote: >>>>>>>> >>>>>>>> From: Hui Liu <quic_huliu@quicinc.com> >>>>>>>> >>>>>>>> Add definition for three LEDs to make sure they can >>>>>>>> be enabled base on QCOM LPG LED driver. >>>>>>> >>>>>>> The "function" property is still placed incorrectly. Posting the >>>>>>> next >>>>>>> iteration before concluding the discussion on the previous one is >>>>>>> not >>>>>>> the best idea. >>>>>> Do you mean I should update it as below? Seems there is no >>>>>> consumer to >>>>>> use the function config, do we need to add now? >>>>> >>>>> Paste the output of dtbs_check for your board (or CHECK_DTBS=y for >>>>> your >>>>> Makefile target). >>>> I checked the dt-binding file of LPG LED, I will update the dts as >>>> below, if you think it's correct, I will push v6. >>> >>> Is there any reason why you are defining three different LEDs instead >>> of multi-led with three components? > >> In the HW design, they are three seprete LEDs, there are three LEDs on >> device. why do we need to add for multi-led? >> >> Thanks, >> Hui I double confirmed the HW design, for IDP devcie, we should set it to multi led, for another similar device(RB3-GEN2, I will push LED change for this device later), it should be set to seperate LED. They are different, so I will push V6 to set it for multi-led for QCM6490-IDP device. Thanks for your review. >>> >>>> >>>> +&pm8350c_pwm { >>>> + #address-cells = <1>; >>>> + #size-cells = <0>; >>>> + status = "okay"; >>>> + >>>> + led@1 { >>>> + reg = <1>; >>>> + color = <LED_COLOR_ID_RED>; >>>> + function = LED_FUNCTION_STATUS; >>>> + }; >>>> + >>>> + led@2 { >>>> + reg = <2>; >>>> + color = <LED_COLOR_ID_GREEN>; >>>> + function = LED_FUNCTION_STATUS; >>>> + }; >>>> + >>>> + led@3 { >>>> + reg = <3>; >>>> + color = <LED_COLOR_ID_BLUE>; >>>> + function = LED_FUNCTION_STATUS; >>>> + }; >>>> +}; >>> >>> >>> ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v5] arm64: dts: qcom: qcm6490-idp: Add definition for three LEDs 2024-01-22 6:25 ` hui liu @ 2024-01-22 13:37 ` Dmitry Baryshkov 2024-01-29 2:06 ` hui liu 0 siblings, 1 reply; 11+ messages in thread From: Dmitry Baryshkov @ 2024-01-22 13:37 UTC (permalink / raw) To: hui liu Cc: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree, linux-kernel, quic_fenglinw On Mon, 22 Jan 2024 at 08:26, hui liu <quic_huliu@quicinc.com> wrote: > > > > On 1/22/2024 1:42 PM, hui liu wrote: > > > > > > On 1/18/2024 10:06 AM, hui liu wrote: > >> > >> > >> On 1/17/2024 11:41 AM, Dmitry Baryshkov wrote: > >>> On Wed, 17 Jan 2024 at 05:02, hui liu <quic_huliu@quicinc.com> wrote: > >>>> > >>>> > >>>> > >>>> On 1/15/2024 6:26 PM, Krzysztof Kozlowski wrote: > >>>>> On 15/01/2024 11:18, hui liu wrote: > >>>>>> > >>>>>> > >>>>>> On 1/15/2024 5:56 PM, Dmitry Baryshkov wrote: > >>>>>>> On Mon, 15 Jan 2024 at 11:48, Hui Liu via B4 Relay > >>>>>>> <devnull+quic_huliu.quicinc.com@kernel.org> wrote: > >>>>>>>> > >>>>>>>> From: Hui Liu <quic_huliu@quicinc.com> > >>>>>>>> > >>>>>>>> Add definition for three LEDs to make sure they can > >>>>>>>> be enabled base on QCOM LPG LED driver. > >>>>>>> > >>>>>>> The "function" property is still placed incorrectly. Posting the > >>>>>>> next > >>>>>>> iteration before concluding the discussion on the previous one is > >>>>>>> not > >>>>>>> the best idea. > >>>>>> Do you mean I should update it as below? Seems there is no > >>>>>> consumer to > >>>>>> use the function config, do we need to add now? > >>>>> > >>>>> Paste the output of dtbs_check for your board (or CHECK_DTBS=y for > >>>>> your > >>>>> Makefile target). > >>>> I checked the dt-binding file of LPG LED, I will update the dts as > >>>> below, if you think it's correct, I will push v6. > >>> > >>> Is there any reason why you are defining three different LEDs instead > >>> of multi-led with three components? > > > >> In the HW design, they are three seprete LEDs, there are three LEDs on > >> device. why do we need to add for multi-led? > >> > >> Thanks, > >> Hui > > I double confirmed the HW design, for IDP devcie, we should set it to > multi led, for another similar device(RB3-GEN2, I will push LED change > for this device later), it should be set to seperate LED. > They are different, so I will push V6 to set it for multi-led for > QCM6490-IDP device. Thanks for your review. Ack, thank you. > > >>> > >>>> > >>>> +&pm8350c_pwm { > >>>> + #address-cells = <1>; > >>>> + #size-cells = <0>; > >>>> + status = "okay"; > >>>> + > >>>> + led@1 { > >>>> + reg = <1>; > >>>> + color = <LED_COLOR_ID_RED>; > >>>> + function = LED_FUNCTION_STATUS; > >>>> + }; > >>>> + > >>>> + led@2 { > >>>> + reg = <2>; > >>>> + color = <LED_COLOR_ID_GREEN>; > >>>> + function = LED_FUNCTION_STATUS; > >>>> + }; > >>>> + > >>>> + led@3 { > >>>> + reg = <3>; > >>>> + color = <LED_COLOR_ID_BLUE>; > >>>> + function = LED_FUNCTION_STATUS; > >>>> + }; > >>>> +}; > >>> > >>> > >>> -- With best wishes Dmitry ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v5] arm64: dts: qcom: qcm6490-idp: Add definition for three LEDs 2024-01-22 13:37 ` Dmitry Baryshkov @ 2024-01-29 2:06 ` hui liu 0 siblings, 0 replies; 11+ messages in thread From: hui liu @ 2024-01-29 2:06 UTC (permalink / raw) To: Dmitry Baryshkov Cc: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree, linux-kernel, quic_fenglinw On 1/22/2024 9:37 PM, Dmitry Baryshkov wrote: > On Mon, 22 Jan 2024 at 08:26, hui liu <quic_huliu@quicinc.com> wrote: >> >> >> >> On 1/22/2024 1:42 PM, hui liu wrote: >>> >>> >>> On 1/18/2024 10:06 AM, hui liu wrote: >>>> >>>> >>>> On 1/17/2024 11:41 AM, Dmitry Baryshkov wrote: >>>>> On Wed, 17 Jan 2024 at 05:02, hui liu <quic_huliu@quicinc.com> wrote: >>>>>> >>>>>> >>>>>> >>>>>> On 1/15/2024 6:26 PM, Krzysztof Kozlowski wrote: >>>>>>> On 15/01/2024 11:18, hui liu wrote: >>>>>>>> >>>>>>>> >>>>>>>> On 1/15/2024 5:56 PM, Dmitry Baryshkov wrote: >>>>>>>>> On Mon, 15 Jan 2024 at 11:48, Hui Liu via B4 Relay >>>>>>>>> <devnull+quic_huliu.quicinc.com@kernel.org> wrote: >>>>>>>>>> >>>>>>>>>> From: Hui Liu <quic_huliu@quicinc.com> >>>>>>>>>> >>>>>>>>>> Add definition for three LEDs to make sure they can >>>>>>>>>> be enabled base on QCOM LPG LED driver. >>>>>>>>> >>>>>>>>> The "function" property is still placed incorrectly. Posting the >>>>>>>>> next >>>>>>>>> iteration before concluding the discussion on the previous one is >>>>>>>>> not >>>>>>>>> the best idea. >>>>>>>> Do you mean I should update it as below? Seems there is no >>>>>>>> consumer to >>>>>>>> use the function config, do we need to add now? >>>>>>> >>>>>>> Paste the output of dtbs_check for your board (or CHECK_DTBS=y for >>>>>>> your >>>>>>> Makefile target). >>>>>> I checked the dt-binding file of LPG LED, I will update the dts as >>>>>> below, if you think it's correct, I will push v6. >>>>> >>>>> Is there any reason why you are defining three different LEDs instead >>>>> of multi-led with three components? >>> >>>> In the HW design, they are three seprete LEDs, there are three LEDs on >>>> device. why do we need to add for multi-led? >>>> >>>> Thanks, >>>> Hui >> >> I double confirmed the HW design, for IDP devcie, we should set it to >> multi led, for another similar device(RB3-GEN2, I will push LED change >> for this device later), it should be set to seperate LED. >> They are different, so I will push V6 to set it for multi-led for >> QCM6490-IDP device. Thanks for your review. > > Ack, thank you. Hi Dmitry, Could you give the approval for V6? https://lore.kernel.org/all/20240126-lpg-v6-1-f879cecbce69@quicinc.com/ Thanks, Hui > >> >>>>> >>>>>> >>>>>> +&pm8350c_pwm { >>>>>> + #address-cells = <1>; >>>>>> + #size-cells = <0>; >>>>>> + status = "okay"; >>>>>> + >>>>>> + led@1 { >>>>>> + reg = <1>; >>>>>> + color = <LED_COLOR_ID_RED>; >>>>>> + function = LED_FUNCTION_STATUS; >>>>>> + }; >>>>>> + >>>>>> + led@2 { >>>>>> + reg = <2>; >>>>>> + color = <LED_COLOR_ID_GREEN>; >>>>>> + function = LED_FUNCTION_STATUS; >>>>>> + }; >>>>>> + >>>>>> + led@3 { >>>>>> + reg = <3>; >>>>>> + color = <LED_COLOR_ID_BLUE>; >>>>>> + function = LED_FUNCTION_STATUS; >>>>>> + }; >>>>>> +}; >>>>> >>>>> >>>>> > > > ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2024-01-29 2:07 UTC | newest] Thread overview: 11+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-01-15 9:48 [PATCH v5] arm64: dts: qcom: qcm6490-idp: Add definition for three LEDs Hui Liu via B4 Relay 2024-01-15 9:56 ` Dmitry Baryshkov 2024-01-15 10:18 ` hui liu 2024-01-15 10:26 ` Krzysztof Kozlowski 2024-01-17 3:02 ` hui liu 2024-01-17 3:41 ` Dmitry Baryshkov 2024-01-18 2:06 ` hui liu 2024-01-22 5:42 ` hui liu 2024-01-22 6:25 ` hui liu 2024-01-22 13:37 ` Dmitry Baryshkov 2024-01-29 2:06 ` hui liu
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).