public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Mirela Rabulea <mirela.rabulea@nxp.com>,
	linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
	Hans Verkuil <hverkuil-cisco@xs4all.nl>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
	Laurentiu Palcu <laurentiu.palcu@nxp.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Robert Chiras <robert.chiras@nxp.com>,
	Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Alain Volmat <alain.volmat@foss.st.com>,
	Alexander Stein <alexander.stein@ew.tq-group.com>,
	Alice Yuan <alice.yuan@nxp.com>,
	Conor Dooley <conor+dt@kernel.org>,
	Dave Stevenson <dave.stevenson@raspberrypi.com>,
	Fabio Estevam <festevam@denx.de>,
	Hans de Goede <hdegoede@redhat.com>,
	Julien Vuillaumier <julien.vuillaumier@nxp.com>,
	Kieran Bingham <kieran.bingham@ideasonboard.com>,
	LnxRevLi@nxp.com, Mikhail Rudenko <mike.rudenko@gmail.com>,
	Umang Jain <umang.jain@ideasonboard.com>,
	Zhi Mao <zhi.mao@mediatek.com>
Subject: Re: [PATCH v3 2/4] media: ox05b1s: Add omnivision OX05B1S raw sensor driver
Date: Mon, 3 Feb 2025 14:45:09 +0100	[thread overview]
Message-ID: <6c32c1e8-0950-4bba-ac32-3284d144b142@web.de> (raw)
In-Reply-To: <20250124001243.446511-3-mirela.rabulea@nxp.com>

…
> +++ b/drivers/media/i2c/ox05b1s/ox05b1s_mipi.c
> @@ -0,0 +1,939 @@
> +static int ox05b1s_get_frame_desc(struct v4l2_subdev *sd, unsigned int pad,
> +				  struct v4l2_mbus_frame_desc *fd)
> +{
> +	/* get sensor current code*/
> +	mutex_lock(&sensor->lock);
> +	fd->entry[0].pixelcode = sensor->mode->code;
> +	mutex_unlock(&sensor->lock);
…

Under which circumstances would you become interested to apply a statement
like “guard(mutex)(&sensor->lock);”?
https://elixir.bootlin.com/linux/v6.13.1/source/include/linux/mutex.h#L201

Regards,
Markus

  parent reply	other threads:[~2025-02-03 13:45 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-24  0:12 [PATCH v3 0/4] media: i2c: Add OX05B1S camera sensor driver Mirela Rabulea
2025-01-24  0:12 ` [PATCH v3 1/4] dt-bindings: media: i2c: Add OX05B1S sensor Mirela Rabulea
2025-01-24  8:02   ` Krzysztof Kozlowski
2025-01-24  0:12 ` [PATCH v3 2/4] media: ox05b1s: Add omnivision OX05B1S raw sensor driver Mirela Rabulea
2025-01-24  6:56   ` Christophe JAILLET
2025-01-24  8:07   ` Krzysztof Kozlowski
2025-02-03 13:32     ` Laurent Pinchart
2025-02-03 13:45   ` Markus Elfring [this message]
2025-01-24  0:12 ` [PATCH v3 3/4] MAINTAINERS: Add entry for OX05B1S " Mirela Rabulea
2025-01-24  0:12 ` [PATCH v3 4/4] media: ox05b1s: Add support for Omnivision OS08A20 raw sensor Mirela Rabulea
2025-01-24  7:03   ` Christophe JAILLET
2025-01-24  8:09   ` Krzysztof Kozlowski
2025-02-03  8:43     ` Mirela Rabulea
2025-02-03 11:36       ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6c32c1e8-0950-4bba-ac32-3284d144b142@web.de \
    --to=markus.elfring@web.de \
    --cc=LnxRevLi@nxp.com \
    --cc=alain.volmat@foss.st.com \
    --cc=alexander.stein@ew.tq-group.com \
    --cc=alice.yuan@nxp.com \
    --cc=bryan.odonoghue@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=dave.stevenson@raspberrypi.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@denx.de \
    --cc=hdegoede@redhat.com \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=julien.vuillaumier@nxp.com \
    --cc=kieran.bingham@ideasonboard.com \
    --cc=krzk+dt@kernel.org \
    --cc=laurent.pinchart+renesas@ideasonboard.com \
    --cc=laurentiu.palcu@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=mike.rudenko@gmail.com \
    --cc=mirela.rabulea@nxp.com \
    --cc=robert.chiras@nxp.com \
    --cc=robh@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=umang.jain@ideasonboard.com \
    --cc=zhi.mao@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox