* [PATCH 0/2] PCI: brcmstb: Use "num-lanes" DT property if present
@ 2025-05-30 22:40 Jim Quinlan
2025-05-30 22:40 ` [PATCH 1/2] dt-bindings: PCI: brcm,stb-pcie: Add num-lanes property Jim Quinlan
` (2 more replies)
0 siblings, 3 replies; 16+ messages in thread
From: Jim Quinlan @ 2025-05-30 22:40 UTC (permalink / raw)
To: linux-pci, Nicolas Saenz Julienne, Bjorn Helgaas,
Lorenzo Pieralisi, bcm-kernel-feedback-list, jim2101024,
james.quinlan
Cc: Rob Herring,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE,
open list,
moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE
v2:
-- DT bindings: Add default, maximum values for 'num-lanes' (Rob)
-- Add 'if' clause to clamp maximum requested num-lanes
v1: original
Jim Quinlan (2):
dt-bindings: PCI: brcm,stb-pcie: Add num-lanes property
PCI: brcmstb: Use "num-lanes" DT property if present
.../bindings/pci/brcm,stb-pcie.yaml | 4 +++
drivers/pci/controller/pcie-brcmstb.c | 26 ++++++++++++++++++-
2 files changed, 29 insertions(+), 1 deletion(-)
base-commit: 01f95500a162fca88cefab9ed64ceded5afabc12
--
2.43.0
^ permalink raw reply [flat|nested] 16+ messages in thread* [PATCH 1/2] dt-bindings: PCI: brcm,stb-pcie: Add num-lanes property
2025-05-30 22:40 [PATCH 0/2] PCI: brcmstb: Use "num-lanes" DT property if present Jim Quinlan
@ 2025-05-30 22:40 ` Jim Quinlan
2025-05-30 23:32 ` Florian Fainelli
2025-06-05 22:41 ` Rob Herring (Arm)
2025-05-30 23:34 ` [PATCH 0/2] PCI: brcmstb: Use "num-lanes" DT property if present Florian Fainelli
2025-06-23 11:53 ` Manivannan Sadhasivam
2 siblings, 2 replies; 16+ messages in thread
From: Jim Quinlan @ 2025-05-30 22:40 UTC (permalink / raw)
To: linux-pci, Nicolas Saenz Julienne, Bjorn Helgaas,
Lorenzo Pieralisi, bcm-kernel-feedback-list, jim2101024,
james.quinlan
Cc: Florian Fainelli, Lorenzo Pieralisi, Krzysztof Wilczyński,
Manivannan Sadhasivam, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE,
moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Add optional num-lanes property Broadcom STB PCIe host controllers.
Signed-off-by: Jim Quinlan <james.quinlan@broadcom.com>
---
Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
index 29f0e1eb5096..cba227b19a5f 100644
--- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
@@ -107,6 +107,10 @@ properties:
- const: bridge
- const: swinit
+ num-lanes:
+ default: 1
+ maximum: 4
+
required:
- compatible
- reg
--
2.43.0
^ permalink raw reply related [flat|nested] 16+ messages in thread* Re: [PATCH 1/2] dt-bindings: PCI: brcm,stb-pcie: Add num-lanes property
2025-05-30 22:40 ` [PATCH 1/2] dt-bindings: PCI: brcm,stb-pcie: Add num-lanes property Jim Quinlan
@ 2025-05-30 23:32 ` Florian Fainelli
2025-06-03 16:24 ` Florian Fainelli
2025-06-05 22:41 ` Rob Herring (Arm)
1 sibling, 1 reply; 16+ messages in thread
From: Florian Fainelli @ 2025-05-30 23:32 UTC (permalink / raw)
To: Jim Quinlan, linux-pci, Nicolas Saenz Julienne, Bjorn Helgaas,
Lorenzo Pieralisi, bcm-kernel-feedback-list, jim2101024
Cc: Lorenzo Pieralisi, Krzysztof Wilczyński,
Manivannan Sadhasivam, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE,
moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
On 5/30/25 15:40, Jim Quinlan wrote:
> Add optional num-lanes property Broadcom STB PCIe host controllers.
>
> Signed-off-by: Jim Quinlan <james.quinlan@broadcom.com>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
--
Florian
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 1/2] dt-bindings: PCI: brcm,stb-pcie: Add num-lanes property
2025-05-30 23:32 ` Florian Fainelli
@ 2025-06-03 16:24 ` Florian Fainelli
2025-06-03 17:16 ` Jim Quinlan
0 siblings, 1 reply; 16+ messages in thread
From: Florian Fainelli @ 2025-06-03 16:24 UTC (permalink / raw)
To: Jim Quinlan, linux-pci, Nicolas Saenz Julienne, Bjorn Helgaas,
Lorenzo Pieralisi, bcm-kernel-feedback-list, jim2101024
Cc: Lorenzo Pieralisi, Krzysztof Wilczyński,
Manivannan Sadhasivam, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE,
moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
On 5/30/25 16:32, Florian Fainelli wrote:
> On 5/30/25 15:40, Jim Quinlan wrote:
>> Add optional num-lanes property Broadcom STB PCIe host controllers.
>>
>> Signed-off-by: Jim Quinlan <james.quinlan@broadcom.com>
>
> Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Sorry I take that back, I think this should be:
num-lanes:
enum: [ 1, 2, 4 ]
We are basically documenting the allowed values, not specifying that we
can repeat the num-lames property between 1 and 4 times.
--
Florian
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 1/2] dt-bindings: PCI: brcm,stb-pcie: Add num-lanes property
2025-06-03 16:24 ` Florian Fainelli
@ 2025-06-03 17:16 ` Jim Quinlan
2025-06-03 17:17 ` Florian Fainelli
0 siblings, 1 reply; 16+ messages in thread
From: Jim Quinlan @ 2025-06-03 17:16 UTC (permalink / raw)
To: Florian Fainelli
Cc: linux-pci, Nicolas Saenz Julienne, Bjorn Helgaas,
Lorenzo Pieralisi, bcm-kernel-feedback-list, jim2101024,
Lorenzo Pieralisi, Krzysztof Wilczyński,
Manivannan Sadhasivam, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE,
moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
[-- Attachment #1: Type: text/plain, Size: 719 bytes --]
On Tue, Jun 3, 2025 at 12:24 PM Florian Fainelli
<florian.fainelli@broadcom.com> wrote:
>
> On 5/30/25 16:32, Florian Fainelli wrote:
> > On 5/30/25 15:40, Jim Quinlan wrote:
> >> Add optional num-lanes property Broadcom STB PCIe host controllers.
> >>
> >> Signed-off-by: Jim Quinlan <james.quinlan@broadcom.com>
> >
> > Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
>
> Sorry I take that back, I think this should be:
>
> num-lanes:
> enum: [ 1, 2, 4 ]
>
> We are basically documenting the allowed values, not specifying that we
> can repeat the num-lames property between 1 and 4 times.
num-lanes is already defined as
enum: [ 1, 2, 4, 8, 16, 32 ]
> --
> Florian
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4197 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH 1/2] dt-bindings: PCI: brcm,stb-pcie: Add num-lanes property
2025-06-03 17:16 ` Jim Quinlan
@ 2025-06-03 17:17 ` Florian Fainelli
2025-06-03 17:24 ` Jim Quinlan
2025-06-05 22:36 ` Rob Herring
0 siblings, 2 replies; 16+ messages in thread
From: Florian Fainelli @ 2025-06-03 17:17 UTC (permalink / raw)
To: Jim Quinlan
Cc: linux-pci, Nicolas Saenz Julienne, Bjorn Helgaas,
Lorenzo Pieralisi, bcm-kernel-feedback-list, jim2101024,
Lorenzo Pieralisi, Krzysztof Wilczyński,
Manivannan Sadhasivam, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE,
moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
On 6/3/25 10:16, Jim Quinlan wrote:
> On Tue, Jun 3, 2025 at 12:24 PM Florian Fainelli
> <florian.fainelli@broadcom.com> wrote:
>>
>> On 5/30/25 16:32, Florian Fainelli wrote:
>>> On 5/30/25 15:40, Jim Quinlan wrote:
>>>> Add optional num-lanes property Broadcom STB PCIe host controllers.
>>>>
>>>> Signed-off-by: Jim Quinlan <james.quinlan@broadcom.com>
>>>
>>> Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
>>
>> Sorry I take that back, I think this should be:
>>
>> num-lanes:
>> enum: [ 1, 2, 4 ]
>>
>> We are basically documenting the allowed values, not specifying that we
>> can repeat the num-lames property between 1 and 4 times.
>
> num-lanes is already defined as
>
> enum: [ 1, 2, 4, 8, 16, 32 ]
Right, but then we need to re-define it with our own specific
constraints, still, don't we?
--
Florian
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 1/2] dt-bindings: PCI: brcm,stb-pcie: Add num-lanes property
2025-06-03 17:17 ` Florian Fainelli
@ 2025-06-03 17:24 ` Jim Quinlan
2025-06-05 22:36 ` Rob Herring
1 sibling, 0 replies; 16+ messages in thread
From: Jim Quinlan @ 2025-06-03 17:24 UTC (permalink / raw)
To: Florian Fainelli
Cc: linux-pci, Nicolas Saenz Julienne, Bjorn Helgaas,
Lorenzo Pieralisi, bcm-kernel-feedback-list, jim2101024,
Lorenzo Pieralisi, Krzysztof Wilczyński,
Manivannan Sadhasivam, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE,
moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
[-- Attachment #1: Type: text/plain, Size: 1220 bytes --]
On Tue, Jun 3, 2025 at 1:17 PM Florian Fainelli
<florian.fainelli@broadcom.com> wrote:
>
> On 6/3/25 10:16, Jim Quinlan wrote:
> > On Tue, Jun 3, 2025 at 12:24 PM Florian Fainelli
> > <florian.fainelli@broadcom.com> wrote:
> >>
> >> On 5/30/25 16:32, Florian Fainelli wrote:
> >>> On 5/30/25 15:40, Jim Quinlan wrote:
> >>>> Add optional num-lanes property Broadcom STB PCIe host controllers.
> >>>>
> >>>> Signed-off-by: Jim Quinlan <james.quinlan@broadcom.com>
> >>>
> >>> Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
> >>
> >> Sorry I take that back, I think this should be:
> >>
> >> num-lanes:
> >> enum: [ 1, 2, 4 ]
> >>
> >> We are basically documenting the allowed values, not specifying that we
> >> can repeat the num-lames property between 1 and 4 times.
> >
> > num-lanes is already defined as
> >
> > enum: [ 1, 2, 4, 8, 16, 32 ]
>
> Right, but then we need to re-define it with our own specific
> constraints, still, don't we?
We do; there is the provided enum and we provide the maximum and minimum.
The AND-ing of all constraints yields [1, 2, 4].
Also, I'm not sure one can redefine an existing property or would want to.
> --
> Florian
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4197 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 1/2] dt-bindings: PCI: brcm,stb-pcie: Add num-lanes property
2025-06-03 17:17 ` Florian Fainelli
2025-06-03 17:24 ` Jim Quinlan
@ 2025-06-05 22:36 ` Rob Herring
2025-06-05 22:42 ` Florian Fainelli
1 sibling, 1 reply; 16+ messages in thread
From: Rob Herring @ 2025-06-05 22:36 UTC (permalink / raw)
To: Florian Fainelli
Cc: Jim Quinlan, linux-pci, Nicolas Saenz Julienne, Bjorn Helgaas,
Lorenzo Pieralisi, bcm-kernel-feedback-list, jim2101024,
Lorenzo Pieralisi, Krzysztof Wilczyński,
Manivannan Sadhasivam, Krzysztof Kozlowski, Conor Dooley,
moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE,
moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
On Tue, Jun 03, 2025 at 10:17:26AM -0700, Florian Fainelli wrote:
> On 6/3/25 10:16, Jim Quinlan wrote:
> > On Tue, Jun 3, 2025 at 12:24 PM Florian Fainelli
> > <florian.fainelli@broadcom.com> wrote:
> > >
> > > On 5/30/25 16:32, Florian Fainelli wrote:
> > > > On 5/30/25 15:40, Jim Quinlan wrote:
> > > > > Add optional num-lanes property Broadcom STB PCIe host controllers.
> > > > >
> > > > > Signed-off-by: Jim Quinlan <james.quinlan@broadcom.com>
> > > >
> > > > Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
> > >
> > > Sorry I take that back, I think this should be:
> > >
> > > num-lanes:
> > > enum: [ 1, 2, 4 ]
> > >
> > > We are basically documenting the allowed values, not specifying that we
> > > can repeat the num-lames property between 1 and 4 times.
Are you confused with maxItems?
> >
> > num-lanes is already defined as
> >
> > enum: [ 1, 2, 4, 8, 16, 32 ]
>
> Right, but then we need to re-define it with our own specific constraints,
> still, don't we?
It is correct as-is.
Rob
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 1/2] dt-bindings: PCI: brcm,stb-pcie: Add num-lanes property
2025-06-05 22:36 ` Rob Herring
@ 2025-06-05 22:42 ` Florian Fainelli
0 siblings, 0 replies; 16+ messages in thread
From: Florian Fainelli @ 2025-06-05 22:42 UTC (permalink / raw)
To: Rob Herring
Cc: Jim Quinlan, linux-pci, Nicolas Saenz Julienne, Bjorn Helgaas,
Lorenzo Pieralisi, bcm-kernel-feedback-list, jim2101024,
Lorenzo Pieralisi, Krzysztof Wilczyński,
Manivannan Sadhasivam, Krzysztof Kozlowski, Conor Dooley,
moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE,
moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
On 6/5/25 15:36, Rob Herring wrote:
> On Tue, Jun 03, 2025 at 10:17:26AM -0700, Florian Fainelli wrote:
>> On 6/3/25 10:16, Jim Quinlan wrote:
>>> On Tue, Jun 3, 2025 at 12:24 PM Florian Fainelli
>>> <florian.fainelli@broadcom.com> wrote:
>>>>
>>>> On 5/30/25 16:32, Florian Fainelli wrote:
>>>>> On 5/30/25 15:40, Jim Quinlan wrote:
>>>>>> Add optional num-lanes property Broadcom STB PCIe host controllers.
>>>>>>
>>>>>> Signed-off-by: Jim Quinlan <james.quinlan@broadcom.com>
>>>>>
>>>>> Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
>>>>
>>>> Sorry I take that back, I think this should be:
>>>>
>>>> num-lanes:
>>>> enum: [ 1, 2, 4 ]
>>>>
>>>> We are basically documenting the allowed values, not specifying that we
>>>> can repeat the num-lames property between 1 and 4 times.
>
> Are you confused with maxItems?
Yes I am.
>
>>>
>>> num-lanes is already defined as
>>>
>>> enum: [ 1, 2, 4, 8, 16, 32 ]
>>
>> Right, but then we need to re-define it with our own specific constraints,
>> still, don't we?
>
> It is correct as-is.
Thanks!
--
Florian
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 1/2] dt-bindings: PCI: brcm,stb-pcie: Add num-lanes property
2025-05-30 22:40 ` [PATCH 1/2] dt-bindings: PCI: brcm,stb-pcie: Add num-lanes property Jim Quinlan
2025-05-30 23:32 ` Florian Fainelli
@ 2025-06-05 22:41 ` Rob Herring (Arm)
1 sibling, 0 replies; 16+ messages in thread
From: Rob Herring (Arm) @ 2025-06-05 22:41 UTC (permalink / raw)
To: Jim Quinlan
Cc: Manivannan Sadhasivam, Nicolas Saenz Julienne, linux-arm-kernel,
linux-rpi-kernel, jim2101024, Florian Fainelli, Lorenzo Pieralisi,
devicetree, linux-kernel, Conor Dooley, Krzysztof Kozlowski,
bcm-kernel-feedback-list, Krzysztof Wilczyński,
Lorenzo Pieralisi, linux-pci, Bjorn Helgaas
On Fri, 30 May 2025 18:40:32 -0400, Jim Quinlan wrote:
> Add optional num-lanes property Broadcom STB PCIe host controllers.
>
> Signed-off-by: Jim Quinlan <james.quinlan@broadcom.com>
> ---
> Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 0/2] PCI: brcmstb: Use "num-lanes" DT property if present
2025-05-30 22:40 [PATCH 0/2] PCI: brcmstb: Use "num-lanes" DT property if present Jim Quinlan
2025-05-30 22:40 ` [PATCH 1/2] dt-bindings: PCI: brcm,stb-pcie: Add num-lanes property Jim Quinlan
@ 2025-05-30 23:34 ` Florian Fainelli
2025-06-23 11:53 ` Manivannan Sadhasivam
2 siblings, 0 replies; 16+ messages in thread
From: Florian Fainelli @ 2025-05-30 23:34 UTC (permalink / raw)
To: Jim Quinlan, linux-pci, Nicolas Saenz Julienne, Bjorn Helgaas,
Lorenzo Pieralisi, bcm-kernel-feedback-list, jim2101024
Cc: Rob Herring,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE,
open list,
moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE
On 5/30/25 15:40, Jim Quinlan wrote:
> v2:
> -- DT bindings: Add default, maximum values for 'num-lanes' (Rob)
> -- Add 'if' clause to clamp maximum requested num-lanes
Subjects should have been "PATCH v2", FWIW.
--
Florian
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 0/2] PCI: brcmstb: Use "num-lanes" DT property if present
2025-05-30 22:40 [PATCH 0/2] PCI: brcmstb: Use "num-lanes" DT property if present Jim Quinlan
2025-05-30 22:40 ` [PATCH 1/2] dt-bindings: PCI: brcm,stb-pcie: Add num-lanes property Jim Quinlan
2025-05-30 23:34 ` [PATCH 0/2] PCI: brcmstb: Use "num-lanes" DT property if present Florian Fainelli
@ 2025-06-23 11:53 ` Manivannan Sadhasivam
2 siblings, 0 replies; 16+ messages in thread
From: Manivannan Sadhasivam @ 2025-06-23 11:53 UTC (permalink / raw)
To: linux-pci, Nicolas Saenz Julienne, Bjorn Helgaas,
bcm-kernel-feedback-list, jim2101024, Lorenzo Pieralisi,
Jim Quinlan
Cc: Rob Herring, devicetree, linux-arm-kernel, linux-kernel,
linux-rpi-kernel
On Fri, 30 May 2025 18:40:31 -0400, Jim Quinlan wrote:
> v2:
> -- DT bindings: Add default, maximum values for 'num-lanes' (Rob)
> -- Add 'if' clause to clamp maximum requested num-lanes
>
>
> v1: original
>
> [...]
Applied, thanks!
[1/2] dt-bindings: PCI: brcm,stb-pcie: Add num-lanes property
commit: dbb1258daf75f2b98e465ba5a0e26073eda6e539
[2/2] PCI: brcmstb: Use "num-lanes" DT property if present
commit: a364d10ffe361fb34c3838d33604da493045de1e
Best regards,
--
Manivannan Sadhasivam <mani@kernel.org>
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 0/2] PCI: brcmstb: Use "num-lanes" DT property if present
@ 2025-05-09 22:28 Jim Quinlan
2025-05-09 22:28 ` [PATCH 1/2] dt-bindings: PCI: brcm,stb-pcie: Add num-lanes property Jim Quinlan
0 siblings, 1 reply; 16+ messages in thread
From: Jim Quinlan @ 2025-05-09 22:28 UTC (permalink / raw)
To: linux-pci, Nicolas Saenz Julienne, Bjorn Helgaas,
Lorenzo Pieralisi, bcm-kernel-feedback-list, jim2101024,
james.quinlan
Cc: Rob Herring,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE,
open list,
moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE
If present, grok the "num-lanes" DT property for Broadcom STB chips and
configure accordingly.
Jim Quinlan (2):
dt-bindings: PCI: brcm,stb-pcie: Add num-lanes property
PCI: brcmstb: Use "num-lanes" DT property if present
.../bindings/pci/brcm,stb-pcie.yaml | 2 ++
drivers/pci/controller/pcie-brcmstb.c | 26 ++++++++++++++++++-
2 files changed, 27 insertions(+), 1 deletion(-)
base-commit: 01f95500a162fca88cefab9ed64ceded5afabc12
--
2.43.0
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 1/2] dt-bindings: PCI: brcm,stb-pcie: Add num-lanes property
2025-05-09 22:28 Jim Quinlan
@ 2025-05-09 22:28 ` Jim Quinlan
2025-05-12 14:54 ` Florian Fainelli
2025-05-12 15:00 ` Rob Herring
0 siblings, 2 replies; 16+ messages in thread
From: Jim Quinlan @ 2025-05-09 22:28 UTC (permalink / raw)
To: linux-pci, Nicolas Saenz Julienne, Bjorn Helgaas,
Lorenzo Pieralisi, bcm-kernel-feedback-list, jim2101024,
james.quinlan
Cc: Florian Fainelli, Lorenzo Pieralisi, Krzysztof Wilczyński,
Manivannan Sadhasivam, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE,
moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Add optional num-lanes property Broadcom STB PCIe host controllers.
Signed-off-by: Jim Quinlan <james.quinlan@broadcom.com>
---
Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
index 29f0e1eb5096..f31d654ac3a0 100644
--- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
@@ -107,6 +107,8 @@ properties:
- const: bridge
- const: swinit
+ num-lanes: true
+
required:
- compatible
- reg
--
2.43.0
^ permalink raw reply related [flat|nested] 16+ messages in thread* Re: [PATCH 1/2] dt-bindings: PCI: brcm,stb-pcie: Add num-lanes property
2025-05-09 22:28 ` [PATCH 1/2] dt-bindings: PCI: brcm,stb-pcie: Add num-lanes property Jim Quinlan
@ 2025-05-12 14:54 ` Florian Fainelli
2025-05-12 15:00 ` Rob Herring
1 sibling, 0 replies; 16+ messages in thread
From: Florian Fainelli @ 2025-05-12 14:54 UTC (permalink / raw)
To: Jim Quinlan, linux-pci, Nicolas Saenz Julienne, Bjorn Helgaas,
Lorenzo Pieralisi, bcm-kernel-feedback-list, jim2101024
Cc: Lorenzo Pieralisi, Krzysztof Wilczyński,
Manivannan Sadhasivam, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE,
moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
On 5/10/2025 12:28 AM, Jim Quinlan wrote:
> Add optional num-lanes property Broadcom STB PCIe host controllers.
>
> Signed-off-by: Jim Quinlan <james.quinlan@broadcom.com>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
--
Florian
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 1/2] dt-bindings: PCI: brcm,stb-pcie: Add num-lanes property
2025-05-09 22:28 ` [PATCH 1/2] dt-bindings: PCI: brcm,stb-pcie: Add num-lanes property Jim Quinlan
2025-05-12 14:54 ` Florian Fainelli
@ 2025-05-12 15:00 ` Rob Herring
2025-05-16 21:51 ` Jim Quinlan
1 sibling, 1 reply; 16+ messages in thread
From: Rob Herring @ 2025-05-12 15:00 UTC (permalink / raw)
To: Jim Quinlan
Cc: linux-pci, Nicolas Saenz Julienne, Bjorn Helgaas,
Lorenzo Pieralisi, bcm-kernel-feedback-list, jim2101024,
Florian Fainelli, Lorenzo Pieralisi, Krzysztof Wilczyński,
Manivannan Sadhasivam, Krzysztof Kozlowski, Conor Dooley,
moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE,
moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
On Fri, May 9, 2025 at 5:28 PM Jim Quinlan <james.quinlan@broadcom.com> wrote:
>
> Add optional num-lanes property Broadcom STB PCIe host controllers.
>
> Signed-off-by: Jim Quinlan <james.quinlan@broadcom.com>
> ---
> Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> index 29f0e1eb5096..f31d654ac3a0 100644
> --- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> @@ -107,6 +107,8 @@ properties:
> - const: bridge
> - const: swinit
>
> + num-lanes: true
Why do you need this? It is already allowed by the referenced schemas.
Though maybe you don't support 16 lanes and need to limit this to
something less? I would also set 'default' if you do that.
Rob
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 1/2] dt-bindings: PCI: brcm,stb-pcie: Add num-lanes property
2025-05-12 15:00 ` Rob Herring
@ 2025-05-16 21:51 ` Jim Quinlan
0 siblings, 0 replies; 16+ messages in thread
From: Jim Quinlan @ 2025-05-16 21:51 UTC (permalink / raw)
To: Rob Herring
Cc: linux-pci, Nicolas Saenz Julienne, Bjorn Helgaas,
Lorenzo Pieralisi, bcm-kernel-feedback-list, jim2101024,
Florian Fainelli, Lorenzo Pieralisi, Krzysztof Wilczyński,
Manivannan Sadhasivam, Krzysztof Kozlowski, Conor Dooley,
moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE,
moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
[-- Attachment #1: Type: text/plain, Size: 1391 bytes --]
On Mon, May 12, 2025 at 11:01 AM Rob Herring <robh@kernel.org> wrote:
>
> On Fri, May 9, 2025 at 5:28 PM Jim Quinlan <james.quinlan@broadcom.com> wrote:
> >
> > Add optional num-lanes property Broadcom STB PCIe host controllers.
> >
> > Signed-off-by: Jim Quinlan <james.quinlan@broadcom.com>
> > ---
> > Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> > index 29f0e1eb5096..f31d654ac3a0 100644
> > --- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> > +++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> > @@ -107,6 +107,8 @@ properties:
> > - const: bridge
> > - const: swinit
> >
> > + num-lanes: true
>
> Why do you need this? It is already allowed by the referenced schemas.
> Though maybe you don't support 16 lanes and need to limit this to
> something less? I would also set 'default' if you do that.
I just thought that if our driver actually did something with
"num-lanes" -- most drivers do not -- then it should be mentioned in
the YAML, even if "num-lanes" is pre-defined.
At any rate we cannot handle 16 lanes so I will add a "default" and "maximum".
Regards,
Jim Quinlan
Broadcom STB
>
>
> Rob
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4197 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2025-06-23 11:53 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-30 22:40 [PATCH 0/2] PCI: brcmstb: Use "num-lanes" DT property if present Jim Quinlan
2025-05-30 22:40 ` [PATCH 1/2] dt-bindings: PCI: brcm,stb-pcie: Add num-lanes property Jim Quinlan
2025-05-30 23:32 ` Florian Fainelli
2025-06-03 16:24 ` Florian Fainelli
2025-06-03 17:16 ` Jim Quinlan
2025-06-03 17:17 ` Florian Fainelli
2025-06-03 17:24 ` Jim Quinlan
2025-06-05 22:36 ` Rob Herring
2025-06-05 22:42 ` Florian Fainelli
2025-06-05 22:41 ` Rob Herring (Arm)
2025-05-30 23:34 ` [PATCH 0/2] PCI: brcmstb: Use "num-lanes" DT property if present Florian Fainelli
2025-06-23 11:53 ` Manivannan Sadhasivam
-- strict thread matches above, loose matches on Subject: below --
2025-05-09 22:28 Jim Quinlan
2025-05-09 22:28 ` [PATCH 1/2] dt-bindings: PCI: brcm,stb-pcie: Add num-lanes property Jim Quinlan
2025-05-12 14:54 ` Florian Fainelli
2025-05-12 15:00 ` Rob Herring
2025-05-16 21:51 ` Jim Quinlan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).