devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: "LH.Kuo" <lhjeff911@gmail.com>,
	p.zabel@pengutronix.de, daniel.thompson@linaro.org,
	lee.jones@linaro.org, u.kleine-koenig@pengutronix.de,
	ulf.hansson@linaro.org, robh+dt@kernel.org,
	linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
	devicetree@vger.kernel.org
Cc: qinjian@cqplus1.com, wells.lu@sunplus.com, "LH.Kuo" <lh.kuo@sunplus.com>
Subject: Re: [PATCH v2 1/2] mmc: Add SD/SDIO driver for Sunplus SP7021
Date: Tue, 9 Nov 2021 18:33:05 -0800	[thread overview]
Message-ID: <6c5c6e83-8176-8b4a-9c2c-f01a262de5de@infradead.org> (raw)
In-Reply-To: <1636444705-17883-2-git-send-email-lh.kuo@sunplus.com>

Hi--

On 11/8/21 11:58 PM, LH.Kuo wrote:
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index 5af8494..2aba9eb 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -1091,5 +1091,15 @@ config MMC_OWL
>   	  This selects support for the SD/MMC Host Controller on
>   	  Actions Semi Owl SoCs.
>   
> +config MMC_SP_SDV2
> +	tristate "Sunplus SP7021 SD/SDIO Controller"
> +	depends on SOC_SP7021
> +	help
> +		If you say yes here, you will get support for SD/SDIO host interface
> +		on sunplus Socs.

		   Sunplus SoCs.

> +		If you have a controller with this interface, say Y or M here.
> +		If unsure, say N.

All 4 lines of help text should be indented only with one tab + 2 spaces,
not 2 tabs, per coding-style.rst.


> +                Sunplus  SD/SDIO Host Controller support"

I am thinking that this last line should not be here at all... ???


thanks.
-- 
~Randy

  reply	other threads:[~2021-11-10  2:33 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-29  5:57 [PATCH 0/2] Add SD/SDIO control driver for Sunplus SP7021 SoC LH.Kuo
2021-10-29  5:57 ` [PATCH 1/2] mmc: Add SD/SDIO driver for Sunplus SP7021 LH.Kuo
2021-10-30  0:00   ` Randy Dunlap
2021-11-02 14:34   ` Philipp Zabel
2021-10-29  5:57 ` [PATCH 2/2] devicetree bindings mmc Add bindings doc " LH.Kuo
2021-11-09  7:58 ` [PATCH v2 0/2] Add SD/SDIO control driver for Sunplus SP7021 SoC LH.Kuo
2021-11-09  7:58   ` [PATCH v2 1/2] mmc: Add SD/SDIO driver for Sunplus SP7021 LH.Kuo
2021-11-10  2:33     ` Randy Dunlap [this message]
     [not found]       ` <d25f2bff024b40fd9691960221c0bebe@sphcmbx02.sunplus.com.tw>
2021-11-10  5:44         ` Randy Dunlap
2021-11-09  7:58   ` [PATCH v2 2/2] devicetree bindings mmc Add bindings doc " LH.Kuo
2021-11-29  1:37     ` Rob Herring
     [not found]       ` <f5607fa7ad9c49a7bfcce02eac834838@sphcmbx02.sunplus.com.tw>
2021-11-29 16:29         ` Rob Herring
     [not found]           ` <1eb97e1aca9c4c8d8f1e17c51f2792ac@sphcmbx02.sunplus.com.tw>
2022-01-04 20:31             ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6c5c6e83-8176-8b4a-9c2c-f01a262de5de@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=daniel.thompson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=lh.kuo@sunplus.com \
    --cc=lhjeff911@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=qinjian@cqplus1.com \
    --cc=robh+dt@kernel.org \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=ulf.hansson@linaro.org \
    --cc=wells.lu@sunplus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).