From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB30EC77B70 for ; Tue, 11 Apr 2023 13:16:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230388AbjDKNQ2 (ORCPT ); Tue, 11 Apr 2023 09:16:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54764 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230251AbjDKNQ1 (ORCPT ); Tue, 11 Apr 2023 09:16:27 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 509303AB6 for ; Tue, 11 Apr 2023 06:16:24 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id i26so10720380lfc.6 for ; Tue, 11 Apr 2023 06:16:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681218982; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=CcUTTOUcMW0dZnIqgtsXXko3U+fcNkeoSkY3ZJOPmXE=; b=LYUd4gN0uvXVwbiLe+XaMSfZYrd+SwcY14tzEW5bLYbnCvbOjB/IB4sP6F1LfgFC7q BSefua8JuXbOq7EDzM3b9LBcTQGaMqZAjneiOHp8G/rdIR43GAt4B6ZchiceXSFwWa07 xv+hX5RZbZpq5DoIIPl9x5aHvqBhYh1TbFKpe0gKwjKLVQcy+A+Yp6MCFft43Xuzk53a 8TBiENf2cer2zEgRynfAzy+gC6VszB9hwZCbV6aJjdGuQcA9Z1XfpgeNHciFodlwRcBr HHzjrhwHuXKETo6CNUblAQs9jRzsoD8XM6zqjI7vlCIFUY2AqEi0T1Lx3sRC3Bk1szZ0 /eww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681218982; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CcUTTOUcMW0dZnIqgtsXXko3U+fcNkeoSkY3ZJOPmXE=; b=dQmXpTHmF1YkVunj+le3Tdfs1U0FFe6izjgeya6SQ//b8s5BMyR1rMf+npq7m/zHVY afubtPH42S4F8nWAH98nit2kqTwPwQQhoC1DCaq/HxU39OAv1hVo/cQQgd1fqDIrffIu ZrG7GL6iJMSmABAQXm40JDE0+68Sy3FO0qrgwN8yUNC1EZMKWxY4vcyHlyb2rtRJA+im AbjOeBMFXHHU5G00YxDCkILYUKgxQI7BbeKSjr9xJVHcXTvfW/LisUJV7LnDZjytOh3f a5qp+xRUgMbtYAvqgGEJ+SKhLTGX626ozjjNJzkRQeDCbvfX+j/OFQbaoao383OlO9L0 RT6g== X-Gm-Message-State: AAQBX9deXds00PB/HGuu+og7QdHQbAopGk+QYgbPai/fbg6m/Lkz/2Ho ropumho14+bRkgvuDWhOBMQHmQ== X-Google-Smtp-Source: AKy350blhLpXLllc5IUc17Ff5DabLr3YrfUjg7JsGcKpnIEbMfXx9pu1SF8NEN24gpwptlidkj7IFg== X-Received: by 2002:ac2:414a:0:b0:4d5:978e:8bcf with SMTP id c10-20020ac2414a000000b004d5978e8bcfmr3481121lfi.33.1681218982568; Tue, 11 Apr 2023 06:16:22 -0700 (PDT) Received: from [192.168.1.101] (abxj23.neoplus.adsl.tpnet.pl. [83.9.3.23]) by smtp.gmail.com with ESMTPSA id r26-20020ac252ba000000b004eb09820adbsm2557794lfm.105.2023.04.11.06.16.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Apr 2023 06:16:22 -0700 (PDT) Message-ID: <6c75d434-bb5d-278f-a125-d096fd6b387d@linaro.org> Date: Tue, 11 Apr 2023 15:16:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v3 7/7] arm64: dts: qcom: sa8775p: add the GPU IOMMU node Content-Language: en-US To: Bartosz Golaszewski , Bjorn Andersson , Andy Gross , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Will Deacon , Robin Murphy , Joerg Roedel , Catalin Marinas , Arnd Bergmann Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, Bartosz Golaszewski References: <20230411125910.401075-1-brgl@bgdev.pl> <20230411125910.401075-8-brgl@bgdev.pl> From: Konrad Dybcio In-Reply-To: <20230411125910.401075-8-brgl@bgdev.pl> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 11.04.2023 14:59, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Add the Adreno GPU IOMMU for sa8775p-based platforms. > > Signed-off-by: Bartosz Golaszewski > --- > arch/arm64/boot/dts/qcom/sa8775p.dtsi | 37 +++++++++++++++++++++++++++ > 1 file changed, 37 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi > index 191b510b5a1a..11f3d80dd869 100644 > --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi > +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi > @@ -7,6 +7,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -605,6 +606,42 @@ gpucc: clock-controller@3d90000 { > #power-domain-cells = <1>; > }; > > + adreno_smmu: iommu@3da0000 { > + compatible = "qcom,sa8775p-smmu-500", "qcom,adreno-smmu", > + "arm,mmu-500"; Err.. does it even boot like this? You dropped the qcom,smmu-500 compatible which means it's getting bound to the generic SMMU driver (without QC quirks). If that was a mistake, you should have had all 4 "qcom,sa8775p-smmu-500", qcom,adreno-smmu, "qcom,smmu-500", "arm,mmu-500" Without falling into the qc-specific codepaths, the Adreno compat does nothing. Konrad > + reg = <0x0 0x03da0000 0x0 0x20000>; > + #iommu-cells = <2>; > + #global-interrupts = <2>; > + dma-coherent; > + power-domains = <&gpucc GPU_CC_CX_GDSC>; > + clocks = <&gcc GCC_GPU_MEMNOC_GFX_CLK>, > + <&gcc GCC_GPU_SNOC_DVM_GFX_CLK>, > + <&gpucc GPU_CC_AHB_CLK>, > + <&gpucc GPU_CC_HLOS1_VOTE_GPU_SMMU_CLK>, > + <&gpucc GPU_CC_CX_GMU_CLK>, > + <&gpucc GPU_CC_HUB_CX_INT_CLK>, > + <&gpucc GPU_CC_HUB_AON_CLK>; > + clock-names = "gcc_gpu_memnoc_gfx_clk", > + "gcc_gpu_snoc_dvm_gfx_clk", > + "gpu_cc_ahb_clk", > + "gpu_cc_hlos1_vote_gpu_smmu_clk", > + "gpu_cc_cx_gmu_clk", > + "gpu_cc_hub_cx_int_clk", > + "gpu_cc_hub_aon_clk"; > + interrupts = , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + ; > + }; > + > pdc: interrupt-controller@b220000 { > compatible = "qcom,sa8775p-pdc", "qcom,pdc"; > reg = <0x0 0x0b220000 0x0 0x30000>,