From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EE33C63797 for ; Mon, 9 Jan 2023 11:38:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234288AbjAILiq (ORCPT ); Mon, 9 Jan 2023 06:38:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54886 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234816AbjAILio (ORCPT ); Mon, 9 Jan 2023 06:38:44 -0500 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 49C7EB36 for ; Mon, 9 Jan 2023 03:38:41 -0800 (PST) Received: by mail-wm1-x336.google.com with SMTP id g10so6047359wmo.1 for ; Mon, 09 Jan 2023 03:38:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=uWRQwZU7Q5uXmRpQpJb8/BTaeDI/2pDdqBknaeuYMoc=; b=y1NBPAWB/5QSk15IQF0sayDsBGK9DTwzo64Fwhce+Wv3f7tVbPw++Vm7KjFJ/ePuIH alZSxq4wMtI3JYRZn3zmZrqmW5U+tcE/36mSZS+ao+PBouUNXkLt8uMAN3EDUZoM8y1Z V38rcAlr6k9TL1waTrhaRP8dMZcyQgFxWY3TRRWCtw3tASJlyK9l3O/MWYqVGJgAknVC jyzHq/yTgZ5C7OdYW+njoDU4LjZ+sYY1fS9XGuRSIkUPXzN3ekBZA31uKMfMGcdTnJze j7zyR4Zp7HBcTCJS529n0Jvj5PuGWJpqpZXzP6IkeqqXkPlbC7aVB/jHNAVTFf8RXMND S+Fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uWRQwZU7Q5uXmRpQpJb8/BTaeDI/2pDdqBknaeuYMoc=; b=WMWBhjjQmFcXIBuq3nKlOw9iMh2KnyvdnALoJ7vzoG9C+7lO9IWrCtYPb8uB/EoUSe k1WjqcjtlLP/+qPPCl2DubuswAnSeDS4qhQdtVs/KplSwC0ptU6s7zyE8DQg6LlbhflU 7m9skWwbE+KmAqwe70t0mxWp+fu14w5knQA7yhsT6ouUyWTq7d2O/nXdKYdK/7QXfn/w tCD4JURd8Z3Oi8Sq+zA8AK4JYA0cnQ6TjfdGSYTreZC7c3t0jiulYh4DO1x6mxDHe3E0 hYEaiPNAwU/4A2gCow8UR57LDjkpjimK6hfhXvxmo+MwUMpjWs1TRRwK5q816hhNGUVS S2gA== X-Gm-Message-State: AFqh2kocSxZbM0oSvUMdiyES8ANXYn3FjWam41bxocd0bJxZ1jW4JaX8 iDfZPqoXVrnZGlZ+6Ci5JXkNzg== X-Google-Smtp-Source: AMrXdXsgKZSO61ZWkew6Daa4r2uBx8Xe/DlWi/W5u/PDxgxQsVfDr2oBgtSbr4LJo3JD2nU14fQRlg== X-Received: by 2002:a05:600c:1f12:b0:3cf:8155:2adc with SMTP id bd18-20020a05600c1f1200b003cf81552adcmr47185923wmb.33.1673264319841; Mon, 09 Jan 2023 03:38:39 -0800 (PST) Received: from [192.168.7.111] (679773502.box.freepro.com. [212.114.21.58]) by smtp.gmail.com with ESMTPSA id r126-20020a1c2b84000000b003d35c845cbbsm15439361wmr.21.2023.01.09.03.38.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Jan 2023 03:38:39 -0800 (PST) Message-ID: <6c784b12-ea81-2ac9-ff99-e33f5c123483@linaro.org> Date: Mon, 9 Jan 2023 12:38:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH 03/12] dt-bindings: nvmem: convert amlogic-meson-mx-efuse.txt to dt-schema Content-Language: en-US To: Martin Blumenstingl Cc: Jakub Kicinski , Wim Van Sebroeck , Srinivas Kandagatla , Rob Herring , Andrew Lunn , Alessandro Zummo , Eric Dumazet , Bjorn Helgaas , Kevin Hilman , Ulf Hansson , Heiner Kallweit , Vinod Koul , Russell King , Thomas Gleixner , Kishon Vijay Abraham I , Guenter Roeck , Krzysztof Kozlowski , Alexandre Belloni , Daniel Lezcano , Jerome Brunet , Paolo Abeni , Mauro Carvalho Chehab , "David S. Miller" , linux-media@vger.kernel.org, netdev@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-mmc@vger.kernel.org, linux-rtc@vger.kernel.org, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org References: <20221117-b4-amlogic-bindings-convert-v1-0-3f025599b968@linaro.org> <20221117-b4-amlogic-bindings-convert-v1-3-3f025599b968@linaro.org> Organization: Linaro Developer Services In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 26/11/2022 00:04, Martin Blumenstingl wrote: > Hi Neil, > > thanks for your work on this! > > On Fri, Nov 18, 2022 at 3:33 PM Neil Armstrong > wrote: > [...] >> + #address-cells = <1>; >> + #size-cells = <1>; >> + >> + sn: sn@14 { >> + reg = <0x14 0x10>; >> + }; >> + >> + eth_mac: mac@34 { >> + reg = <0x34 0x10>; >> + }; >> + >> + bid: bid@46 { >> + reg = <0x46 0x30>; >> + }; > I assume you took these examples from the newer, GX eFuse? > Unfortunately on boards with these older SoCs the serial number and > MAC address are often not stored in the eFuse. > This is just an example, so I won't be sad if we keep them. To avoid > confusion I suggest switching to different examples: > ethernet_mac_address: mac@1b4 { > reg = <0x1b4 0x6>; > }; > temperature_calib: calib@1f4 { > reg = <0x1f4 0x4>; > }; > > What do you think? Sure switched to it ! Neil > > > Best regards, > Martin