From: Vikash Garodia <vgarodia@codeaurora.org>
To: Stanimir Varbanov <stanimir.varbanov@linaro.org>
Cc: hverkuil@xs4all.nl, mchehab@kernel.org, robh@kernel.org,
mark.rutland@arm.com, andy.gross@linaro.org, arnd@arndb.de,
bjorn.andersson@linaro.org, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-soc@vger.kernel.org, devicetree@vger.kernel.org,
acourbot@chromium.org, linux-media-owner@vger.kernel.org
Subject: Re: [PATCH v3 2/4] venus: firmware: move load firmware in a separate function
Date: Mon, 06 Aug 2018 13:54:52 +0530 [thread overview]
Message-ID: <6c8c4e7b27000903073ac85a867b0454@codeaurora.org> (raw)
In-Reply-To: <b5ecaa26-2f3b-9a2e-d496-7f9b35e3f761@linaro.org>
Hi Stanimir,
On 2018-07-25 15:05, Stanimir Varbanov wrote:
> Hi Vikash,
>
> On 07/04/2018 10:06 PM, Vikash Garodia wrote:
<snip>
>> +
>> + if (!IS_ENABLED(CONFIG_QCOM_MDT_LOADER))
>> + return -EPROBE_DEFER;
>
> the original venus_boot was checking for || !qcom_scm_is_available()
> why
> is that removed? It was done on purpose.
For booting venus without tz, scm calls are not needed. Does it look
good to
keep the check for "!core->no_tz" case alone ?
if (!core->no_tz && !qcom_scm_is_available())
return -EPROBE_DEFER;
Thanks,
Vikash
next prev parent reply other threads:[~2018-08-06 8:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-04 19:06 [PATCH v3 0/4] Venus updates - PIL Vikash Garodia
2018-07-04 19:06 ` [PATCH v3 1/4] venus: firmware: add routine to reset ARM9 Vikash Garodia
2018-07-25 9:35 ` Stanimir Varbanov
2018-07-25 11:14 ` Stanimir Varbanov
2018-07-04 19:06 ` [PATCH v3 2/4] venus: firmware: move load firmware in a separate function Vikash Garodia
2018-07-25 9:35 ` Stanimir Varbanov
2018-08-06 8:24 ` Vikash Garodia [this message]
2018-08-06 13:38 ` Vikash Garodia
2018-07-04 19:06 ` [PATCH v3 3/4] venus: firmware: add no TZ boot and shutdown routine Vikash Garodia
2018-07-25 9:36 ` Stanimir Varbanov
2018-08-06 8:18 ` Vikash Garodia
2018-07-04 19:06 ` [PATCH v3 4/4] venus: firmware: register separate driver for firmware device Vikash Garodia
2018-07-05 23:36 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c8c4e7b27000903073ac85a867b0454@codeaurora.org \
--to=vgarodia@codeaurora.org \
--cc=acourbot@chromium.org \
--cc=andy.gross@linaro.org \
--cc=arnd@arndb.de \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil@xs4all.nl \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media-owner@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
--cc=stanimir.varbanov@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).