From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Caleb Connolly <caleb.connolly@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
phone-devel@vger.kernel.org
Subject: Re: [PATCH 2/6] arm64: dts: qcom: pmi8998: enable rradc by default
Date: Fri, 26 May 2023 21:46:07 +0200 [thread overview]
Message-ID: <6ca15f25-b4aa-1806-06ef-343c11f8f19a@linaro.org> (raw)
In-Reply-To: <20230524-pmi8998-charger-dts-v1-2-f9334afc4505@linaro.org>
On 24.05.2023 19:38, Caleb Connolly wrote:
> There is no need for the RRADC to be disabled by default,
> lets just enable it by default and not clutter up DT.
>
> Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
> ---
Acked-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm64/boot/dts/qcom/msm8998-oneplus-common.dtsi | 4 ----
> arch/arm64/boot/dts/qcom/pmi8998.dtsi | 2 --
> arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 4 ----
> arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi | 4 ----
> arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi | 4 ----
> 5 files changed, 18 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8998-oneplus-common.dtsi b/arch/arm64/boot/dts/qcom/msm8998-oneplus-common.dtsi
> index 062d56c42385..68e634f8212c 100644
> --- a/arch/arm64/boot/dts/qcom/msm8998-oneplus-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8998-oneplus-common.dtsi
> @@ -279,10 +279,6 @@ vol_keys_default: vol-keys-state {
> };
> };
>
> -&pmi8998_rradc {
> - status = "okay";
> -};
> -
> &qusb2phy {
> status = "okay";
>
> diff --git a/arch/arm64/boot/dts/qcom/pmi8998.dtsi b/arch/arm64/boot/dts/qcom/pmi8998.dtsi
> index ffe587f281d8..be6f60bfc26c 100644
> --- a/arch/arm64/boot/dts/qcom/pmi8998.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pmi8998.dtsi
> @@ -23,8 +23,6 @@ pmi8998_rradc: adc@4500 {
> compatible = "qcom,pmi8998-rradc";
> reg = <0x4500>;
> #io-channel-cells = <1>;
> -
> - status = "disabled";
> };
> };
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> index e14fe9bbb386..66087af02d74 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> @@ -649,10 +649,6 @@ led@5 {
> };
> };
>
> -&pmi8998_rradc {
> - status = "okay";
> -};
> -
> /* QUAT I2S Uses 4 I2S SD Lines for audio on LT9611 HDMI Bridge */
> &q6afedai {
> dai@22 {
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
> index 5c384345c05d..55ee8dcf27c3 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
> @@ -480,10 +480,6 @@ pinconf {
> };
> };
>
> -&pmi8998_rradc {
> - status = "okay";
> -};
> -
> &q6afedai {
> qi2s@22 {
> reg = <22>;
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
> index 5ed975cc6ecb..1915643f1c49 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
> @@ -346,10 +346,6 @@ &pm8998_resin {
> status = "okay";
> };
>
> -&pmi8998_rradc {
> - status = "okay";
> -};
> -
> /* QUAT I2S Uses 1 I2S SD Line for audio on TAS2559/60 amplifiers */
> &q6afedai {
> dai@22 {
>
next prev parent reply other threads:[~2023-05-26 19:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 17:38 [PATCH 0/6] Enable PMI8998 charger on supported devices Caleb Connolly
2023-05-24 17:38 ` [PATCH 1/6] dt-bindings: mfd: qcom,spmi-pmic: Document pmi8998 charger Caleb Connolly
2023-05-24 18:24 ` Rob Herring
2023-05-24 19:02 ` Conor Dooley
2023-05-24 19:53 ` Caleb Connolly
2023-05-24 20:08 ` Conor Dooley
2023-05-24 17:38 ` [PATCH 2/6] arm64: dts: qcom: pmi8998: enable rradc by default Caleb Connolly
2023-05-26 19:46 ` Konrad Dybcio [this message]
2023-05-24 17:38 ` [PATCH 3/6] arm64: dts: qcom: pmi8998: add charger node Caleb Connolly
2023-05-26 19:46 ` Konrad Dybcio
2023-05-26 21:39 ` Caleb Connolly
2023-05-26 21:41 ` Konrad Dybcio
2023-05-24 17:38 ` [PATCH 4/6] arm64: dts: qcom: sdm845-oneplus: enable pmi8998 charger Caleb Connolly
2023-05-24 17:38 ` [PATCH 5/6] arm64: dts: qcom: sdm845-shift-axolotl: " Caleb Connolly
2023-05-26 19:47 ` Konrad Dybcio
2023-05-24 17:38 ` [PATCH 6/6] arm64: dts: qcom: sdm845-xiaomi-beryllium: " Caleb Connolly
2023-05-26 19:47 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ca15f25-b4aa-1806-06ef-343c11f8f19a@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=caleb.connolly@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).