From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f48.google.com (mail-qv1-f48.google.com [209.85.219.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D1053BADA7 for ; Fri, 2 Oct 2026 19:18:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790968720; cv=none; b=baSs9esEMOekHzV7VnwET9FHYDG/U2QJ01jIO6Vej50PsZOJW4WVB1CAEtdt9FD+xSmx6feMIUtuFk8cbNRO2kb45lvvn3g3vKm5JXCq2IIkMJrtBAxVfWb6RagD3qAy9sGCUhR/bfrRko+/Fbzl0Zh0dsj7cjYtFM3GTfNu7Qk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790968720; c=relaxed/simple; bh=jsedZLxYBjeRK5DRFBlUwUDOw3C1t+5s3b7lh0/hqDA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kxnYa05nyDB0xzaSdvrYM4XTt6M2vrX7UGqmZ+xFwqfQWYcs83dK2WWyaqli5mPOe89GWMKWRmYamc1sczgOFwbr2uCJDOxXv5zvk1cwOq0sPpFuScReCLfXWRsvVuZT070R+6bRDuKRFAoewjUKQFNmwE6iYmMFVgV6lB6XN0c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b=eghDmcSR; arc=none smtp.client-ip=209.85.219.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b="eghDmcSR" Received: by mail-qv1-f48.google.com with SMTP id 6a1803df08f44-91791ec1b83so544266d6.1 for ; Fri, 02 Oct 2026 12:18:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20251104.gappssmtp.com; s=20251104; t=1790968717; x=1791573517; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=K2WGxmgiqbuVWGrMMN7M+HLRy0CqkeslBWbdjt3ajek=; b=eghDmcSRsR6MOItEQd6AKVUmnUtisYNWkhZU9z5cL/DTj8jualhQcRwk33Y9a6UdOp tvXhwTjgyzCx0fzgVXbzdFi5tecJ4g8j+Ch603SxboaDbbIBjWtQ94+hOLawY0Oepn6M gE0DHnHjVDcGbpp1TuPQ32XLwMZKMlVEoFpPMmU3jr2BN3Cj5zSXZLeDt8BGe5XqD3ch Eoeo//GZIU3j9xx4jYjKhOYCPnzOaXAPM+mHc+fWtMxgQkQiHOG/i5By/Xl4OSS8EZhJ FnvaUi62c8p7ZGrWmAb5hpds+Zmkg+wkBfOHxZy/EtLcFLEvNCGBtGIUDAGso76DNv6w gPIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790968717; x=1791573517; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=K2WGxmgiqbuVWGrMMN7M+HLRy0CqkeslBWbdjt3ajek=; b=lGBiPn62ED+HxGmbFO39IIDfE0IdtebZ15TNt2xIZwQCaG+ZkYxN0xlNERQBnIfGgX vkZZn75MPBVsFD9DRcdcgDrqXEaKw+G6EdUp0N5KeUpQoYOSnWr3+FjuLUj9CIuhkD3b AK9Bh/VJhcsI9Mh9yNbCT2SSLltW7It0mWI18bOaCbmq/EiCIHXuUC4GqwiCHCoJ8M7g 8c1F1G+mZabqC0E2o2G0xxxUoIYJqS+503VWAhwqOl7skL0X0bEt7zuZWN+ifqd62nU+ 2BIhL/A08DfchGVUdhm5fA2CYbFSREGcx/NbMei1Xp6QcqiO8iE2VkeMxVkQm5dNNeXl /aIg== X-Forwarded-Encrypted: i=1; AKwUvBz9hflNPoc6mfsmj7XGWWgqyAyGYABp68KbiqRDpP2nwYw6lM88ZODdaeCre2y1Tm97XYY4sDm06ymV@vger.kernel.org X-Gm-Message-State: AFq9FYJX7as5r5vV/EUJUMCUuvGEUafrWq03G8GcTInaLNnRGSAqEBPS lJosBejqwQ1Gadb72TkX5pBDeY+3tY/M4G+Tii3W94KhowotYVo1TGj0I7kY63bWkOY= X-Gm-Gg: AYBFou2euM/ybm8orUoMtm966zvqsTIAJjr0gnUnfZpZfYNiW6pf4LaHm3dcwPvpDgr SnMPlQZLGP9ImUjpApTmstD+FtaNvi/R5orlt9+BV1KTZ6NbEz8GkYC7LDknIAxUFP8oSs0S1vE Vb7qVFE3CtMuBSdlP3FEorpKJI3OLNoF1/uDdHytXuWp7nDaEBig6PYjrwML8X5V5pS2Hvw/ANG /c3VdmXzwCj0celg6vKPndB5pGPFYGpKkSZEYoJAB749p2ptu1/5jgbbwxVwHq8mZsbZnJ9nxEh IRIsvvNpwqApMCe+WZUS90Malgq/XV7dq1/+5MmIBB3MRhDD8MYFi+KLORWn6HLv0mTxxOSmLRq RIhREPeAXSWcKV0lC5/f78SWsYKN4koAGMs593oDlihzboQnqPGHiZ9Pn0e+nBL5+8EtK8ZnJdl jFnIw+AopzZCqVdIZ8SiLY8DfyjTFrVbFhD+r7lN9hdQcE+T5c7BhW0Sglie5T1iif9a4BJjP5x dYAKiFxZyQ= X-Received: by 2002:a05:6214:3019:b0:917:a92a:fd59 with SMTP id 6a1803df08f44-9195d1da497mr5054326d6.37.1790968717042; Fri, 02 Oct 2026 12:18:37 -0700 (PDT) Received: from [172.22.22.28] ([73.62.185.64]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-917e0b67167sm27020566d6.21.2026.10.02.12.18.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Oct 2026 12:18:36 -0700 (PDT) Message-ID: <6cad75b3-c4fb-486f-82a2-6613c4dffe32@riscstar.com> Date: Fri, 2 Oct 2026 14:18:34 -0500 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 0/5] PCI/pwrctrl: tc9563: Introduce support for embedded GPIO controller To: Bjorn Helgaas , Lorenzo Bianconi , Bjorn Andersson , Bartosz Golaszewski , Linus Walleij Cc: Bjorn Helgaas , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chaitanya Chundru , Bartosz Golaszewski , Konrad Dybcio , Michael Walle , Daniel Thompson , Sushrut Shree Trivedi , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-msm@vger.kernel.org, Manivannan Sadhasivam , Konrad Dybcio , Abel Vesa References: <20261002175405.GA189401@bhelgaas> Content-Language: en-US From: Alex Elder In-Reply-To: <20261002175405.GA189401@bhelgaas> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/2/26 12:54 PM, Bjorn Helgaas wrote: > [cc->to: Bjorn A for arm64 DTS, Linus, Bart for immutable branch question] > > On Wed, Sep 23, 2026 at 03:43:50PM -0500, Bjorn Helgaas wrote: >> On Wed, Sep 09, 2026 at 04:55:52PM +0200, Lorenzo Bianconi wrote: >>> The TC9563 embeds a GPIO controller currently used for per-port reset >>> signals. >>> Add a driver for the GPIO controller embedded in the Toshiba TC9563 PCIe >>> switch providing 37 GPIO lines. The controller is registered as an auxiliary >>> device by the TC9563 power controller driver and accessed through the same >>> i2c device. >>> Please note this series is based on pwrctrl upstream branch. >> ... > >>> --- >>> Alex Elder (1): >>> gpio: tc9563: Add support for the embedded GPIO controller >>> >>> Lorenzo Bianconi (4): >>> dt-bindings: PCI: toshiba,tc9563: Document embedded GPIO controller >>> PCI/pwrctrl: tc9563: Add GPIO auxiliary device support >>> PCI/pwrctrl: tc9563: Switch per-port reset to GPIO descriptor API >>> arm64: dts: qcom: qcs6490-rb3gen2: Enable TC9563 embedded GPIO controller >>> >>> .../devicetree/bindings/pci/toshiba,tc9563.yaml | 14 +- >>> arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 7 +- >>> drivers/gpio/Kconfig | 11 ++ >>> drivers/gpio/Makefile | 1 + >>> drivers/gpio/gpio-tc9563.c | 99 +++++++++++++ >>> drivers/pci/pwrctrl/Kconfig | 1 + >>> drivers/pci/pwrctrl/pci-pwrctrl-tc9563.c | 165 +++++++++++++++++++-- >>> include/linux/soc/qcom/tc9563.h | 19 +++ >>> 8 files changed, 300 insertions(+), 17 deletions(-) >>> --- >>> base-commit: 028f86457e822ab9de5b0d6d23efddc1b8b54ae1 >>> change-id: 20260731-pci-tc9563-aux-66a29d438f60 >> >> Applied on pci/pwrctrl for v7.4, thank you! > > I had applied the arch/arm64 DTS change: > > arm64: dts: qcom: qcs6490-rb3gen2: Enable TC9563 embedded GPIO controller > > on pci/pwrctrl, but I think that was a mistake because that should be > handled by Bjorn Andersson instead. I'm only responding to this to provide slightly more explanation about what you want to do. Resetting pci/pwrctrl has no effect on me. > What I would *like* to do is rework the pci/pwrctrl branch to drop > patch 5/5 (the arch/arm64 DTS change) and reorder the Alex's new gpio > driver first so it's not in the middle of the tc9563 DT and driver > updates: Currently, the dt-bindings commit is before the gpio commit (and followed by the two pwrctrl commits). You want to reorder the first two, as below. -Alex > gpio: tc9563: Add support for the embedded GPIO controller > dt-bindings: PCI: toshiba,tc9563: Document embedded GPIO controller > PCI/pwrctrl: tc9563: Add GPIO auxiliary device support > PCI/pwrctrl: tc9563: Switch per-port reset to GPIO descriptor API > > But I don't want to break anybody who assumed pci/pwrctrl was > immutable and pulled it in already, e.g., to the GPIO tree. Would > this rework break anybody?