devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Biju Das <biju.das.jz@bp.renesas.com>, Rob Herring <robh+dt@kernel.org>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
	Magnus Damm <magnus.damm@gmail.com>,
	"linux-renesas-soc@vger.kernel.org" 
	<linux-renesas-soc@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Chris Paterson <Chris.Paterson2@renesas.com>,
	Biju Das <biju.das@bp.renesas.com>,
	Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: Re: [PATCH v4 4/5] arm64: dts: renesas: Add initial DTSI for RZ/G2UL SoC
Date: Sat, 2 Apr 2022 22:08:04 +0200	[thread overview]
Message-ID: <6cb05255-2cfd-e941-5a7a-e15d7a00edbe@linaro.org> (raw)
In-Reply-To: <OS0PR01MB5922A0675D7928834AD33BFD86E39@OS0PR01MB5922.jpnprd01.prod.outlook.com>

On 02/04/2022 21:37, Biju Das wrote:
> Hi Krzysztof Kozlowski,
> 
> Thanks for the feedback.
> 
>> Subject: Re: [PATCH v4 4/5] arm64: dts: renesas: Add initial DTSI for
>> RZ/G2UL SoC
>>
>> On 02/04/2022 09:30, Biju Das wrote:
>>> Add initial DTSI for RZ/G2UL SoC.
>>>

(...)

>>> +	soc: soc {
>>> +		compatible = "simple-bus";
>>> +		interrupt-parent = <&gic>;
>>> +		#address-cells = <2>;
>>> +		#size-cells = <2>;
>>> +		ranges;
>>> +
>>> +		ssi0: ssi@10049c00 {
>>> +			reg = <0 0x10049c00 0 0x400>;
>>> +			#sound-dai-cells = <0>;
>>> +			/* place holder */
>>
>> Here and in other place holders - why there are no compatibles here?
> 
> These interface are not tested with mainline kernel and will be added later after testing.
> 
>> What do you hold place for
> 
> As mentioned in commit description, I will get compilation error as the carrier board shared 
> with other SoC's For eg:- RZ/G2L,RZ/G2LC and RZ/V2L.
> 

OK, thanks for explanation. It looks a bit fragile, because it means
that your rz-smarc-common.dtsi enables nodes which are not described.
Although I see the point why it's done like this, so it's fine for me.

Best regards,
Krzysztof

  reply	other threads:[~2022-04-02 20:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-02  7:30 [PATCH v4 0/5] Add Renesas RZ/G2UL Type-1 {SoC,SMARC EVK} support Biju Das
2022-04-02  7:30 ` [PATCH v4 2/5] dt-bindings: clock: Add R9A07G043 CPG Clock and Reset Definitions Biju Das
2022-04-12 15:21   ` Geert Uytterhoeven
2022-04-02  7:30 ` [PATCH v4 4/5] arm64: dts: renesas: Add initial DTSI for RZ/G2UL SoC Biju Das
2022-04-02 16:39   ` Krzysztof Kozlowski
2022-04-02 19:37     ` Biju Das
2022-04-02 20:08       ` Krzysztof Kozlowski [this message]
2022-04-02  7:30 ` [PATCH v4 5/5] arm64: dts: renesas: Add initial device tree for RZ/G2UL Type-1 SMARC EVK Biju Das

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6cb05255-2cfd-e941-5a7a-e15d7a00edbe@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=Chris.Paterson2@renesas.com \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=biju.das@bp.renesas.com \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).