* [PATCH] ARM: dts: stm32: add STM32F746 syscfg clock
@ 2023-11-01 15:51 Ben Wolsieffer
2023-11-21 13:29 ` Alexandre TORGUE
2023-11-21 13:30 ` Alexandre TORGUE
0 siblings, 2 replies; 3+ messages in thread
From: Ben Wolsieffer @ 2023-11-01 15:51 UTC (permalink / raw)
To: linux-stm32, devicetree, linux-arm-kernel, linux-kernel
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Maxime Coquelin,
Alexandre Torgue, Ben Wolsieffer
The syscfg syscon was missing its clock, therefore any attempt to
read/write it after clk_disable_unused() silently failed. This was
preventing external pin interrupts from working if they were initialized
after this point.
Signed-off-by: Ben Wolsieffer <ben.wolsieffer@hefring.com>
---
arch/arm/boot/dts/st/stm32f746.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/st/stm32f746.dtsi b/arch/arm/boot/dts/st/stm32f746.dtsi
index 4942753d011e..cce6ab0e4617 100644
--- a/arch/arm/boot/dts/st/stm32f746.dtsi
+++ b/arch/arm/boot/dts/st/stm32f746.dtsi
@@ -501,6 +501,7 @@ sdio1: mmc@40012c00 {
syscfg: syscon@40013800 {
compatible = "st,stm32-syscfg", "syscon";
reg = <0x40013800 0x400>;
+ clocks = <&rcc 0 STM32F7_APB2_CLOCK(SYSCFG)>;
};
exti: interrupt-controller@40013c00 {
--
2.42.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: stm32: add STM32F746 syscfg clock
2023-11-01 15:51 [PATCH] ARM: dts: stm32: add STM32F746 syscfg clock Ben Wolsieffer
@ 2023-11-21 13:29 ` Alexandre TORGUE
2023-11-21 13:30 ` Alexandre TORGUE
1 sibling, 0 replies; 3+ messages in thread
From: Alexandre TORGUE @ 2023-11-21 13:29 UTC (permalink / raw)
To: Ben Wolsieffer, linux-stm32, devicetree, linux-arm-kernel,
linux-kernel
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Maxime Coquelin
Hi Ben
On 11/1/23 16:51, Ben Wolsieffer wrote:
> The syscfg syscon was missing its clock, therefore any attempt to
> read/write it after clk_disable_unused() silently failed. This was
> preventing external pin interrupts from working if they were initialized
> after this point.
>
> Signed-off-by: Ben Wolsieffer <ben.wolsieffer@hefring.com>
> ---
> arch/arm/boot/dts/st/stm32f746.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/st/stm32f746.dtsi b/arch/arm/boot/dts/st/stm32f746.dtsi
> index 4942753d011e..cce6ab0e4617 100644
> --- a/arch/arm/boot/dts/st/stm32f746.dtsi
> +++ b/arch/arm/boot/dts/st/stm32f746.dtsi
> @@ -501,6 +501,7 @@ sdio1: mmc@40012c00 {
> syscfg: syscon@40013800 {
> compatible = "st,stm32-syscfg", "syscon";
> reg = <0x40013800 0x400>;
> + clocks = <&rcc 0 STM32F7_APB2_CLOCK(SYSCFG)>;
> };
>
> exti: interrupt-controller@40013c00 {
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: stm32: add STM32F746 syscfg clock
2023-11-01 15:51 [PATCH] ARM: dts: stm32: add STM32F746 syscfg clock Ben Wolsieffer
2023-11-21 13:29 ` Alexandre TORGUE
@ 2023-11-21 13:30 ` Alexandre TORGUE
1 sibling, 0 replies; 3+ messages in thread
From: Alexandre TORGUE @ 2023-11-21 13:30 UTC (permalink / raw)
To: Ben Wolsieffer, linux-stm32, devicetree, linux-arm-kernel,
linux-kernel
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Maxime Coquelin
Hi Ben
On 11/1/23 16:51, Ben Wolsieffer wrote:
> The syscfg syscon was missing its clock, therefore any attempt to
> read/write it after clk_disable_unused() silently failed. This was
> preventing external pin interrupts from working if they were initialized
> after this point.
>
> Signed-off-by: Ben Wolsieffer <ben.wolsieffer@hefring.com>
> ---
> arch/arm/boot/dts/st/stm32f746.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/st/stm32f746.dtsi b/arch/arm/boot/dts/st/stm32f746.dtsi
> index 4942753d011e..cce6ab0e4617 100644
> --- a/arch/arm/boot/dts/st/stm32f746.dtsi
> +++ b/arch/arm/boot/dts/st/stm32f746.dtsi
> @@ -501,6 +501,7 @@ sdio1: mmc@40012c00 {
> syscfg: syscon@40013800 {
> compatible = "st,stm32-syscfg", "syscon";
> reg = <0x40013800 0x400>;
> + clocks = <&rcc 0 STM32F7_APB2_CLOCK(SYSCFG)>;
> };
>
> exti: interrupt-controller@40013c00 {
Applied on stm32-next.
Thanks
Alex
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-21 13:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-01 15:51 [PATCH] ARM: dts: stm32: add STM32F746 syscfg clock Ben Wolsieffer
2023-11-21 13:29 ` Alexandre TORGUE
2023-11-21 13:30 ` Alexandre TORGUE
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).