From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78A3FC64E7B for ; Wed, 2 Dec 2020 15:48:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 13CE820B1F for ; Wed, 2 Dec 2020 15:48:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728550AbgLBPsY (ORCPT ); Wed, 2 Dec 2020 10:48:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54804 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728538AbgLBPsX (ORCPT ); Wed, 2 Dec 2020 10:48:23 -0500 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 30318C0613D4 for ; Wed, 2 Dec 2020 07:47:43 -0800 (PST) Received: by mail-wr1-x443.google.com with SMTP id 64so4469365wra.11 for ; Wed, 02 Dec 2020 07:47:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=hZCo1m8g7QPYnEX3m7SsmQm546vtQp+mN348j0Xkt6I=; b=WozaPSMeOVI9euTVFOarywGpxKAPZvKOXOEWQtvyps7gdpv6liS1NZR50dH857phu2 Y1bMq0kgHUwjXNWnESQfr3PxIZEMqAohaQBnW3/nd5DWWL0S8YiX4k2whD+N+KHoeFop 17/44eB5Xm0ZftGesDSIUrNQbgxc63hr9WR9P18dHP2Yda+6R4cQEaB0jjNIxAR/g1W8 CXSxIStqcYpyTXP8aiLtE9H/hTG0YMbcil0gG63TyDzHxLfKpu8LoaL2NjmbWB8Bx3hS YTce5kYBVLCHvO2X2wSEbN2x3JqL4Li+z851OEp0eKF9dELEArBV1erCImBwUK+G++v5 dmcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=hZCo1m8g7QPYnEX3m7SsmQm546vtQp+mN348j0Xkt6I=; b=TfrzK0Nn8uwcZPFYjkAR3dTRTpZPvLiq/pxbVm6wCCE1WuFsoaKAEPmpnTngWBW/U8 1CZktqwBCIipYFzHJCqPlarCDbXOnnzBhOOD2w7Qx6vyXZhXxmf0eFW41SsqciM7aTkq P4oNGXCa0sAEIYKoMrNFf6fZe6yH2ySEFoINxFUK5O2tsV5uUyTmkSWewpVoto5EC1og H8lc6hTXL5LXxJHNnKRIwfbPnTRTS/1SQ3VbakcJavQcUplL9yb7X0zbw7//yLwRZ51Y tCEtnr/3d5hsguCAHY3VVN9t2faGgUFkM0US+ddLEKzpRjRISmNjIMRk5+srbAO7t/h9 tnPw== X-Gm-Message-State: AOAM533LujnKjw0KsKUQw78XN66TKQ6VGkoKxtLhYspcV3z7V1ZePHCn AyXRhgFyMqY/RcridpG7auWvuQ== X-Google-Smtp-Source: ABdhPJzPDRn6F8yI8MQnEqRIUcKoTyE96fFWrfcQlIjRGQGvsOzW1c+R+URB/NtEvglv2Rk0vXYh+w== X-Received: by 2002:adf:f102:: with SMTP id r2mr4198893wro.315.1606924061942; Wed, 02 Dec 2020 07:47:41 -0800 (PST) Received: from [192.168.86.34] (cpc86377-aztw32-2-0-cust226.18-1.cable.virginm.net. [92.233.226.227]) by smtp.googlemail.com with ESMTPSA id r13sm2444950wrs.6.2020.12.02.07.47.40 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 02 Dec 2020 07:47:41 -0800 (PST) Subject: Re: [PATCH 1/6] arm64: dts: qcom: sm8250: add apr and its services To: Bjorn Andersson Cc: linux-arm-msm@vger.kernel.org, agross@kernel.org, robh+dt@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20201201153706.13450-1-srinivas.kandagatla@linaro.org> <20201201153706.13450-2-srinivas.kandagatla@linaro.org> From: Srinivas Kandagatla Message-ID: <6cbf6754-56bc-c35a-038e-08903c2e09d2@linaro.org> Date: Wed, 2 Dec 2020 15:47:40 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Many thanks Bjorn for review, On 01/12/2020 19:25, Bjorn Andersson wrote: > On Tue 01 Dec 09:37 CST 2020, Srinivas Kandagatla wrote: > >> Add apr node and its associated services required for audio on RB5. >> >> Signed-off-by: Srinivas Kandagatla >> --- >> arch/arm64/boot/dts/qcom/sm8250.dtsi | 56 ++++++++++++++++++++++++++++ >> 1 file changed, 56 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi >> index 65acd1f381eb..3b4e98b13d36 100644 >> --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi >> @@ -11,6 +11,8 @@ >> #include >> #include >> #include >> +#include >> +#include > > Please move this line one step down to maintain the alphabetical sort > order. I agree with all the comments on this patch as well as other patches, will send v2 with those fixed! Thanks, srini > > Thanks, > Bjorn > >> #include >> #include >> >> @@ -2620,6 +2622,60 @@ >> label = "lpass"; >> qcom,remote-pid = <2>; >> >> + apr { >> + compatible = "qcom,apr-v2"; >> + qcom,glink-channels = "apr_audio_svc"; >> + qcom,apr-domain = ; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + apr-service@3 { >> + reg = ; >> + compatible = "qcom,q6core"; >> + qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd"; >> + }; >> + >> + q6afe: apr-service@4 { >> + compatible = "qcom,q6afe"; >> + reg = ; >> + qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd"; >> + q6afedai: dais { >> + compatible = "qcom,q6afe-dais"; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + #sound-dai-cells = <1>; >> + }; >> + >> + q6afecc: cc { >> + compatible = "qcom,q6afe-clocks"; >> + #clock-cells = <2>; >> + }; >> + }; >> + >> + q6asm: apr-service@7 { >> + compatible = "qcom,q6asm"; >> + reg = ; >> + qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd"; >> + q6asmdai: dais { >> + compatible = "qcom,q6asm-dais"; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + #sound-dai-cells = <1>; >> + iommus = <&apps_smmu 0x1801 0x0>; >> + }; >> + }; >> + >> + q6adm: apr-service@8 { >> + compatible = "qcom,q6adm"; >> + reg = ; >> + qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd"; >> + q6routing: routing { >> + compatible = "qcom,q6adm-routing"; >> + #sound-dai-cells = <0>; >> + }; >> + }; >> + }; >> + >> fastrpc { >> compatible = "qcom,fastrpc"; >> qcom,glink-channels = "fastrpcglink-apps-dsp"; >> -- >> 2.21.0 >>