From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68D4AC77B72 for ; Thu, 20 Apr 2023 07:10:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233972AbjDTHKy (ORCPT ); Thu, 20 Apr 2023 03:10:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58882 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233933AbjDTHKx (ORCPT ); Thu, 20 Apr 2023 03:10:53 -0400 Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B099E76; Thu, 20 Apr 2023 00:10:49 -0700 (PDT) Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id 09E7A24E270; Thu, 20 Apr 2023 15:10:47 +0800 (CST) Received: from EXMBX067.cuchost.com (172.16.6.67) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 20 Apr 2023 15:10:46 +0800 Received: from [192.168.125.89] (113.72.144.253) by EXMBX067.cuchost.com (172.16.6.67) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 20 Apr 2023 15:10:45 +0800 Message-ID: <6ce407ab-0d2a-323f-61df-44b2ed8eb0ca@starfivetech.com> Date: Thu, 20 Apr 2023 15:10:45 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v2 3/3] riscv: dts: starfive: Add cpu scaling for JH7110 SoC To: Conor Dooley CC: "Rafael J. Wysocki" , Viresh Kumar , Emil Renner Berthing , "Rob Herring" , Krzysztof Kozlowski , Paul Walmsley , Palmer Dabbelt , Albert Ou , Shengyu Qu , , , , References: <20230417063942.3141-1-mason.huo@starfivetech.com> <20230417063942.3141-4-mason.huo@starfivetech.com> <20230418-talcum-unthread-618a5bd2758a@spud> Content-Language: en-US From: Mason Huo In-Reply-To: <20230418-talcum-unthread-618a5bd2758a@spud> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [113.72.144.253] X-ClientProxiedBy: EXCAS066.cuchost.com (172.16.6.26) To EXMBX067.cuchost.com (172.16.6.67) X-YovoleRuleAgent: yovoleflag Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2023/4/19 1:28, Conor Dooley wrote: > Hey Mason, > > Just one minor comment in passing.. > > On Mon, Apr 17, 2023 at 02:39:42PM +0800, Mason Huo wrote: >> Add the operating-points-v2 to support cpu scaling on StarFive JH7110 SoC. >> It supports up to 4 cpu frequency loads. >> >> Signed-off-by: Mason Huo >> --- >> .../jh7110-starfive-visionfive-2.dtsi | 17 ++++++++++ >> arch/riscv/boot/dts/starfive/jh7110.dtsi | 33 +++++++++++++++++++ >> 2 files changed, 50 insertions(+) >> >> diff --git a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi >> index cca1c8040801..b25e6d68ce53 100644 >> --- a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi >> +++ b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi >> @@ -227,3 +227,20 @@ &uart0 { >> pinctrl-0 = <&uart0_pins>; >> status = "okay"; >> }; >> + >> +&U74_1 { >> + cpu-supply = <&vdd_cpu>; >> +}; >> + >> +&U74_2 { >> + cpu-supply = <&vdd_cpu>; >> +}; >> + >> +&U74_3 { >> + cpu-supply = <&vdd_cpu>; >> +}; >> + >> +&U74_4 { >> + cpu-supply = <&vdd_cpu>; >> +}; >> + > > Applying: riscv: dts: starfive: Add cpu scaling for JH7110 SoC > /stuff/linux/.git/rebase-apply/patch:30: new blank line at EOF. > + > warning: 1 line adds whitespace errors. > > Cheers, > Conor. > Hi Conor, Will fix it soon. Thanks Mason