From mboxrd@z Thu Jan 1 00:00:00 1970 From: Santosh Shilimkar Subject: Re: [PATCH v2 3/3] remoteproc/keystone: Ensure the DSPs are in reset in probe Date: Sat, 10 Jun 2017 12:32:43 -0700 Message-ID: <6ce5952b-55b0-8f77-2e14-51110d6bf979@oracle.com> References: <20170608002447.47580-1-s-anna@ti.com> <20170608002447.47580-4-s-anna@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170608002447.47580-4-s-anna-l0cyMroinI0@public.gmane.org> Content-Language: en-US Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Suman Anna , Bjorn Andersson , Rob Herring , Ohad Ben-Cohen Cc: Santosh Shilimkar , Mark Rutland , linux-remoteproc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "Andrew F. Davis" , Sam Nelson List-Id: devicetree@vger.kernel.org On 6/7/2017 5:24 PM, Suman Anna wrote: > From: "Andrew F. Davis" > > The DSPs are expected to be in reset when the driver probes a device. > If the DSPs are out of reset in probe, the system may crash when the > firmware is being loaded. So, add a check to make sure the DSP resets > are asserted, and if not, throw a eye-catchy warning and assert the > resets specifically. > > Signed-off-by: Andrew F. Davis > [s-anna-l0cyMroinI0@public.gmane.org: replace warning with a WARN] > Signed-off-by: Suman Anna > --- Acked-by: Santosh Shilimkar -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html