Devicetree
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Monish Chunara <monish.chunara@oss.qualcomm.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Manivannan Sadhasivam <mani@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Sarthak Garg <sarthak.garg@oss.qualcomm.com>,
	Pradeep Pragallapati <pradeep.pragallapati@oss.qualcomm.com>,
	Nitin Rawat <nitin.rawat@oss.qualcomm.com>,
	Shiraz Hashim <shiraz.hashim@oss.qualcomm.com>
Subject: Re: [PATCH RESEND v1 2/2] arm64: dts: qcom: lemans-evk: Add SDHCI support for eMMC via overlay
Date: Wed, 2 Sep 2026 18:30:30 +0200	[thread overview]
Message-ID: <6d4b8ced-97e9-4926-8678-39339c5303af@oss.qualcomm.com> (raw)
In-Reply-To: <20260826113206.488991-3-monish.chunara@oss.qualcomm.com>

On 8/26/26 1:32 PM, Monish Chunara wrote:
> Enable the SDHCI controller for eMMC functionality on the lemans EVK
> using a device tree overlay. Configure the corresponding addresse space
> and resources for eMMC.

These are two separate changes that must be two separate patches

[...]

> diff --git a/arch/arm64/boot/dts/qcom/lemans.dtsi b/arch/arm64/boot/dts/qcom/lemans.dtsi
> index 695eae1b7256..99d21e3d7ab8 100644
> --- a/arch/arm64/boot/dts/qcom/lemans.dtsi
> +++ b/arch/arm64/boot/dts/qcom/lemans.dtsi
> @@ -4300,7 +4300,9 @@ apss_tpdm2_out: endpoint {
>  
>  		sdhc: mmc@87c4000 {
>  			compatible = "qcom,sa8775p-sdhci", "qcom,sdhci-msm-v5";
> -			reg = <0x0 0x087c4000 0x0 0x1000>;
> +			reg = <0x0 0x87C4000 0x0 0x1000>,
> +			      <0x0 0x87C5000 0x0 0x1000>;

Please don't deviate from the existing style (8 lowercase hex digits,
zero-padded in the front if necessary)

Konrad

      parent reply	other threads:[~2026-09-02 16:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-26 11:32 [PATCH RESEND v1 0/2] arm64: dts: qcom: lemans-evk: Update SDHC storage support via overlays Monish Chunara
2026-08-26 11:32 ` [PATCH RESEND v1 1/2] arm64: dts: qcom: lemans-evk: Move SD card support to overlay Monish Chunara
2026-09-02 16:29   ` Konrad Dybcio
2026-08-26 11:32 ` [PATCH RESEND v1 2/2] arm64: dts: qcom: lemans-evk: Add SDHCI support for eMMC via overlay Monish Chunara
2026-08-26 11:46   ` sashiko-bot
2026-09-02 16:30   ` Konrad Dybcio [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6d4b8ced-97e9-4926-8678-39339c5303af@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mani@kernel.org \
    --cc=monish.chunara@oss.qualcomm.com \
    --cc=nitin.rawat@oss.qualcomm.com \
    --cc=pradeep.pragallapati@oss.qualcomm.com \
    --cc=robh@kernel.org \
    --cc=sarthak.garg@oss.qualcomm.com \
    --cc=shiraz.hashim@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox