From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 30D12239E9B for ; Sat, 25 Apr 2026 16:24:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777134262; cv=none; b=VcxWZuHMathvFQJKN0cIMZMEgA3LPHBHtfRnsbJcGv5sqrEyiDICqVax2twFeGhdSHaqqTlJYPuyPzSPmm0t1K6kzrzHwunx2IzIuLoexU6rOyCtg35ZwiCQd6iAt7YcFXkol9ju304KzOInH42X2wxWI/VEEZgcviTF6EkOkwM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777134262; c=relaxed/simple; bh=VWy9Kg9mDTOQDkQpdKD/lfret98JGppo3qXkI9nfpyo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=secg+3Q0/8Q1BrGO7VHQ4JGw31CQ+Rb4QuyShQiqVAP6sPrvMif9YJlOTql5PWt++4T+85M3LO9E0ioGRWHnwb/Sh81GfyC2Qja5/f0tMnfz8mKaw0J8ez6HScgMsPtPBSGXg8dn606epSCG5yF8FX1iabt19awBJU7IVslM9xo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=jRm0M6hu; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=LBsyBRqa; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="jRm0M6hu"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="LBsyBRqa" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63PGOKNT2937316 for ; Sat, 25 Apr 2026 16:24:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= bZzgVikKVem+yKBm9PKQ2pL0LAqojwaDKUW5/SZUQuA=; b=jRm0M6huFizUvkHb tZYUdtnmtE2LQE1macTNCd8MjeOQ/jmrtd8i6rVmUi2ynura1X+uSDuMpGOGtMhc qK+4Epc530EwLltrtpZ0OZegKQJwLQ8ucfGJAMIAXH/w8N9lElP/thldjCiAKKdp nguBbfbmJVWsR/x7LoIYwmAVybriET0q/I2TX6msC3i9vUg0DdJaVAUfFT2VCZLr PFHDJlvZEzn7VaskC5AjzbXpDtwuSMAZtXetypupMBydu2h2lZDHID1O51lAde+2 qUcKbkRcOgG8RBVF+2m+kSHOf392hF0uzxm0p2k+bApZAkdA8cnPpye3Jjmmggra BAsXHQ== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4drp07h9mt-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 25 Apr 2026 16:24:20 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-3595485abbbso10762739a91.2 for ; Sat, 25 Apr 2026 09:24:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1777134259; x=1777739059; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=bZzgVikKVem+yKBm9PKQ2pL0LAqojwaDKUW5/SZUQuA=; b=LBsyBRqav61Jw7tJF4ytIpWxfYy9uMO6z4eV63appUIxi+YI+JHQqnhM95LrV4R+aa fLasUwE5DuJmCTIB7AISJP7kdiLx2j2DBwMyJLC5Mgidq/O+DQDnZVQOG8QwjaCVI6TH zoFa04tMpDVPrS1zsXL9UlWyTEXPNt7ltAdEC3xNJEhZ5EDPDJh0q1omxkvDX7KkITY8 dTiMdWHw1It4bAx7r0WKEyLVM7sp9guU1O9QlrZExO4TmO5+2ui3neARUAEUuXNfBBIi htB1/IcPzUY8IJjjCtXWnreTaiNwYk+dRoBd+ZsiisUaE0DtlKHxzkZcdjCgsGiGt3Ws F+Yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777134259; x=1777739059; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bZzgVikKVem+yKBm9PKQ2pL0LAqojwaDKUW5/SZUQuA=; b=QZ9cLsi/D6h5oFLOzsnxIohp5ajrzrlTAeeEnK3pHwSmhi3PXJlmxdBFERThhklhqV eRoLzYv+4th3VPpQox+coaI2GTH77ltnZ9IwMXKHCxMpZR+mgHQ7zwbYI2vTIm2BKTZi ZxsVXaGgAvLl8aKeK7uFiQDK/WBF0vLcTLXpUVFtkflMh2qoAxPSFTazcTHydry5ZPQc SF/A0Er5qnPII6qsedbVxl1HCqeJnvaTBsh9Zumq4JPjRGZPx0FYSX8oY0YvkzcJZQLA 9WgiI9UDKUw5oVYloK+BNfhLSaHM4uuMI+1nuxPe6me29PrdRuH90hFgsjtEBfWDBgwZ kIKg== X-Forwarded-Encrypted: i=1; AFNElJ+4ooshuSo0yVfdkOOBxy4vFM6o+7Way1qwnKViFGAkHTwG1vRur1KvTw/5H1hMDDAWgtDkriVCBSES@vger.kernel.org X-Gm-Message-State: AOJu0YwPtnYYPLkeKssT+hiwu3wf0T1l0TxjtbCbTQsbzQ1LNbYg2RmG m0t3Yjz5O0s16SuD8AJXuROMssBa/aKZMt/yb24TK02Hrx11d24R9LAXyJxMDd24OKfUbx4WE7W 8+GzQnOdfPX5Mvu4MIfbjIhUqV/LzUk14tVOeyAhHX+rdkb4XcfRJGlBZQ5HZSyzq X-Gm-Gg: AeBDievMZ1vkyy5je7JVRLNmmI8Wru79q5j0tPikRbxbW9PWs5r0P2Vjaqz4H1HzgvO LVm3FvohydIHuRcsLsqs2v5FWpCXCjQJ3LqxZDx4NcJHa/6eMat631SNn+Q0RBB44+3zNwObCyc Ig2nFZYXRsvBOcguoTgcga1JdidB5GkPMNSNknEfiCAiab0+4/IVZm7FjjMqvzNPKQYcosM61Lx N9lsvn11Pe2Q9rTZOiYNHDrMPmbqc2kA3UULqMn4CbqLNy5ngiWlosQEOTwDoH7VMTXP7wL3pcw YrA+18oVOacZrVj9ydZLW+uuvNEtNfAjle/W9aLcVlb5621EOhvZlqQvZK6cZ70vaqLxVGXQ/og M71Ucz/6r+VeCfGqWHg7IEAzLXXDj59pcZSfeCtBzM61YvuRijv0PoJHUdctY4oD8zg== X-Received: by 2002:a17:90b:5543:b0:35f:bddd:3860 with SMTP id 98e67ed59e1d1-361403b18f5mr36788740a91.6.1777134259149; Sat, 25 Apr 2026 09:24:19 -0700 (PDT) X-Received: by 2002:a17:90b:5543:b0:35f:bddd:3860 with SMTP id 98e67ed59e1d1-361403b18f5mr36788694a91.6.1777134258606; Sat, 25 Apr 2026 09:24:18 -0700 (PDT) Received: from [192.168.29.100] ([49.43.194.239]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36141990bb6sm27919380a91.17.2026.04.25.09.23.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 25 Apr 2026 09:24:17 -0700 (PDT) Message-ID: <6d5516ab-f693-e605-77ad-e3f7d0bf579e@oss.qualcomm.com> Date: Sat, 25 Apr 2026 21:53:48 +0530 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v2 04/13] dt-bindings: media: qcom,glymur-iris: Add glymur video codec To: Krzysztof Kozlowski , Bryan O'Donoghue , Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Joerg Roedel , Will Deacon , Robin Murphy , Bjorn Andersson , Konrad Dybcio , Stefan Schmidt , Hans Verkuil , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Thierry Reding , Mikko Perttunen , David Airlie , Simona Vetter , Jonathan Hunter Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, driver-core@lists.linux.dev, dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org References: <20260423-glymur-v2-0-0296bccb9f4e@oss.qualcomm.com> <20260423-glymur-v2-4-0296bccb9f4e@oss.qualcomm.com> <0d68b3a6-576c-4073-9df0-802f909e439f@kernel.org> Content-Language: en-US From: Vishnu Reddy In-Reply-To: <0d68b3a6-576c-4073-9df0-802f909e439f@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=K8QS2SWI c=1 sm=1 tr=0 ts=69eceab4 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=gkiTcqCCC2T/77GpOVv7Jg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=Hbe3yhC3yqVD2gJYGagA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-ORIG-GUID: 9TJkAUhowl16yzorMTLMDNeM1QlevOK6 X-Proofpoint-GUID: 9TJkAUhowl16yzorMTLMDNeM1QlevOK6 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDI1MDE2OSBTYWx0ZWRfX4NPMZujXiCir xIN5TnA4kHjmkivn7F/EFsdycEehRnn27Q/N88fcr27WLjuYokFEZ+9m1l1x6AO+KScOHgprF4T JOfK0d5spM5JgCoPScRsYLXmFL0ql58uu5ik5YCUyZQSSqzP9btPHJpn0MfYkLWgrdDokVQG8pA te7wF/4o5o8k2/sUIHAbyL1wJ3kETtl+hxZKqKIe8WbMEW/5Pm0jT6Rk7OI09LorQnMMbOLcNEe TxLw2UEYiMI9lV5w+KI+qm0WFGfscF6k3riRIPzSjVlDyFHc9bUX9F+yuF6VKeyqE2hjgEyLiBi FKuQTu3JyFTLt+NTPLtN3KdsYPESsEqNcyT6mW/PJZtRKfzb+P19+nzQSHCkIOYoHu//E6XaBZ0 QMqH89q30UkMJaslzGb8DwrleBoagflYUzEn3ULGxgk7IUbMBpBk5gseqtKX0+MH6YvmT/lB5iQ IztJY5WGubOT/uiHM5Q== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-25_04,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 spamscore=0 malwarescore=0 phishscore=0 priorityscore=1501 adultscore=0 lowpriorityscore=0 bulkscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604250169 On 4/25/2026 4:10 PM, Krzysztof Kozlowski wrote: > On 25/04/2026 11:56, Vishnu Reddy wrote: >> On 4/24/2026 10:39 PM, Krzysztof Kozlowski wrote: >>> On 23/04/2026 15:29, Vishnu Reddy wrote: >>>> +required: >>>> + - compatible >>>> + - reg >>>> + - clocks >>>> + - clock-names >>>> + - dma-coherent >>>> + - interconnects >>>> + - interconnect-names >>>> + - interrupts >>>> + - iommus >>>> + - memory-region >>>> + - power-domains >>>> + - power-domain-names >>>> + - resets >>>> + - reset-names >>>> + >>>> +unevaluatedProperties: false >>>> + >>> I think I commented around here but probably not specific enough. You >>> miss here either reference to venus or usage of additionalProperties >>> instead of unevaluatedProperties. >>> >>> If you intend not to use qcom,venus-common.yaml, then explain WHY in >>> commit msg and switch to additionalProperties: false. >>> >>> Otherwise, you miss $ref. >>> >>> Rest looked good. >> Iris glymur platform have more clocks and power domains, which exceed >> the maxItems limits defined in qcom,venus-common.yaml. Inheriting from >> it would cause dt-schema validation failures, so I have chosen not to >> reference it. > Instead, you should extend the common schema. It's already flexible, so > what is the problem here? > > You then need to duplicate all of the common properties... Ack, I'm fine to update qcom,venus-common.yaml to relax the maxItems constraints for clocks and power domains, so that the Glymur Iris binding can properly inherit from it. > > Best regards, > Krzysztof