From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Fabio Estevam <festevam@gmail.com>, broonie@kernel.org
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, viorel.suman@nxp.com,
linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
Fabio Estevam <festevam@denx.de>
Subject: Re: [PATCH] ASoC: dt-bindings: fsl,xcvr: Adjust the number of interrupts
Date: Wed, 6 Dec 2023 12:03:07 +0100 [thread overview]
Message-ID: <6d58e60d-c85b-47a7-840e-47711ad208d5@linaro.org> (raw)
In-Reply-To: <20231205202015.2118980-1-festevam@gmail.com>
On 05/12/2023 21:20, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
>
> Unlike i.MX8MP, i.MX93 has two XCVR interrupts.
>
> Describe the two interrupts for the i.MX93 to fix the following
> dt-schema warning:
>
> imx93-11x11-evk.dtb: xcvr@42680000: interrupts: [[0, 203, 4], [0, 204, 4]] is too long
> from schema $id: http://devicetree.org/schemas/sound/fsl,xcvr.yaml#
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
> .../devicetree/bindings/sound/fsl,xcvr.yaml | 18 +++++++++++++++++-
> 1 file changed, 17 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/fsl,xcvr.yaml b/Documentation/devicetree/bindings/sound/fsl,xcvr.yaml
> index 799b362ba498..2db69a953afa 100644
> --- a/Documentation/devicetree/bindings/sound/fsl,xcvr.yaml
> +++ b/Documentation/devicetree/bindings/sound/fsl,xcvr.yaml
> @@ -38,7 +38,10 @@ properties:
> - const: txfifo
>
> interrupts:
> - maxItems: 1
> + items:
> + - description: WAKEUPMIX Audio XCVR Interrupt 1
> + - description: WAKEUPMIX Audio XCVR Interrupt 2
> + minItems: 1
>
> clocks:
> items:
> @@ -78,6 +81,19 @@ required:
> - dma-names
> - resets
>
> +allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - fsl,imx93-xcvr
> + then:
> + properties:
> + interrupts:
> + minItems: 2
> + maxItems: 2
Same comment as your lcdif. Why all devices support now two interrupts?
Best regards,
Krzysztof
prev parent reply other threads:[~2023-12-06 11:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-05 20:20 [PATCH] ASoC: dt-bindings: fsl,xcvr: Adjust the number of interrupts Fabio Estevam
2023-12-06 11:03 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d58e60d-c85b-47a7-840e-47711ad208d5@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@denx.de \
--cc=festevam@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-sound@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=viorel.suman@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).