* [PATCH v2 0/3] fsi: sbefifo: Prevent async FFDC collection for Odyssey SBEFIFOs
@ 2024-04-15 15:39 Eddie James
2024-04-15 15:39 ` [PATCH v2 1/3] dt-bindings: fsi: Document the IBM SBEFIFO engine Eddie James
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Eddie James @ 2024-04-15 15:39 UTC (permalink / raw)
To: linux-aspeed
Cc: joel, andrew, devicetree, linux-fsi, robh, conor+dt, krzk+dt, jk,
alistair, eajames, lakshmiy
A new type of SBE on the Odyssey chip will return any async FFDC in the
next transaction, so collecting the FFDC is unnecessary and results in
unexpected behavior. Turn off the async collection for Odyssey SBEFIFOs.
Changes since v1:
- Change "ody" to "odyssey"
- Fix minor issues in binding document
Eddie James (3):
dt-bindings: fsi: Document the IBM SBEFIFO engine
fsi: sbefifo: Prevent async FFDC collection for Odyssey SBEFIFOs
ARM: dts: aspeed: Update Odyssey SBEFIFO compatible strings
.../devicetree/bindings/fsi/ibm,sbefifo.yaml | 39 +++++++++++
.../dts/aspeed/aspeed-bmc-ibm-everest.dts | 64 +++++++++----------
.../arm/boot/dts/aspeed/ibm-power10-quad.dtsi | 64 +++++++++----------
drivers/fsi/fsi-sbefifo.c | 37 +++++++++++
4 files changed, 140 insertions(+), 64 deletions(-)
create mode 100644 Documentation/devicetree/bindings/fsi/ibm,sbefifo.yaml
--
2.39.3
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2 1/3] dt-bindings: fsi: Document the IBM SBEFIFO engine
2024-04-15 15:39 [PATCH v2 0/3] fsi: sbefifo: Prevent async FFDC collection for Odyssey SBEFIFOs Eddie James
@ 2024-04-15 15:39 ` Eddie James
2024-04-16 17:25 ` Conor Dooley
2024-04-15 15:39 ` [PATCH v2 2/3] fsi: sbefifo: Prevent async FFDC collection for Odyssey SBEFIFOs Eddie James
2024-04-15 15:39 ` [PATCH v2 3/3] ARM: dts: aspeed: Update Odyssey SBEFIFO compatible strings Eddie James
2 siblings, 1 reply; 6+ messages in thread
From: Eddie James @ 2024-04-15 15:39 UTC (permalink / raw)
To: linux-aspeed
Cc: joel, andrew, devicetree, linux-fsi, robh, conor+dt, krzk+dt, jk,
alistair, eajames, lakshmiy
The SBEFIFO engine provides an interface to the POWER processor
Self Boot Engine (SBE).
Signed-off-by: Eddie James <eajames@linux.ibm.com>
---
Changes since v1:
- Chance "ody" to "odyssey"
- Fix typo in commit message
- Reword description to describe the hardware only
.../devicetree/bindings/fsi/ibm,sbefifo.yaml | 39 +++++++++++++++++++
1 file changed, 39 insertions(+)
create mode 100644 Documentation/devicetree/bindings/fsi/ibm,sbefifo.yaml
diff --git a/Documentation/devicetree/bindings/fsi/ibm,sbefifo.yaml b/Documentation/devicetree/bindings/fsi/ibm,sbefifo.yaml
new file mode 100644
index 000000000000..69521b1cfb25
--- /dev/null
+++ b/Documentation/devicetree/bindings/fsi/ibm,sbefifo.yaml
@@ -0,0 +1,39 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/fsi/ibm,sbefifo.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: IBM FSI-attached SBEFIFO engine
+
+maintainers:
+ - Eddie James <eajames@linux.ibm.com>
+
+description: |
+ The SBEFIFO is an FSI CFAM engine that provides an interface to the
+ POWER processor Self Boot Engine (SBE). This node will always be a child
+ of an FSI CFAM node; see fsi.txt for details on FSI slave and CFAM
+ nodes.
+
+properties:
+ compatible:
+ enum:
+ - ibm,p9-sbefifo
+ - ibm,odyssey-sbefifo
+
+ reg:
+ items:
+ - description: FSI slave address
+
+required:
+ - compatible
+ - reg
+
+additionalProperties: false
+
+examples:
+ - |
+ sbefifo@2400 {
+ compatible = "ibm,p9-sbefifo";
+ reg = <0x2400 0x400>;
+ };
--
2.39.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2 2/3] fsi: sbefifo: Prevent async FFDC collection for Odyssey SBEFIFOs
2024-04-15 15:39 [PATCH v2 0/3] fsi: sbefifo: Prevent async FFDC collection for Odyssey SBEFIFOs Eddie James
2024-04-15 15:39 ` [PATCH v2 1/3] dt-bindings: fsi: Document the IBM SBEFIFO engine Eddie James
@ 2024-04-15 15:39 ` Eddie James
2024-04-15 15:39 ` [PATCH v2 3/3] ARM: dts: aspeed: Update Odyssey SBEFIFO compatible strings Eddie James
2 siblings, 0 replies; 6+ messages in thread
From: Eddie James @ 2024-04-15 15:39 UTC (permalink / raw)
To: linux-aspeed
Cc: joel, andrew, devicetree, linux-fsi, robh, conor+dt, krzk+dt, jk,
alistair, eajames, lakshmiy
A new type of SBE on the Odyssey chip will return any async FFDC in the
next transaction, so collecting the FFDC is unnecessary and results in
unexpected behavior. Turn off the async collection for Odyssey SBEFIFOs.
Signed-off-by: Eddie James <eajames@linux.ibm.com>
---
Changes since v1:
- Change "ody" to "odyssey"
drivers/fsi/fsi-sbefifo.c | 37 +++++++++++++++++++++++++++++++++++++
1 file changed, 37 insertions(+)
diff --git a/drivers/fsi/fsi-sbefifo.c b/drivers/fsi/fsi-sbefifo.c
index 0385476bfb03..b8add20e05ec 100644
--- a/drivers/fsi/fsi-sbefifo.c
+++ b/drivers/fsi/fsi-sbefifo.c
@@ -125,6 +125,7 @@ struct sbefifo {
struct mutex lock;
bool broken;
bool dead;
+ bool need_async;
bool async_ffdc;
bool timed_out;
u32 timeout_in_cmd_ms;
@@ -141,6 +142,10 @@ struct sbefifo_user {
u32 read_timeout_ms;
};
+struct sbefifo_data {
+ bool need_async;
+};
+
static DEFINE_MUTEX(sbefifo_ffdc_mutex);
static ssize_t timeout_show(struct device *dev, struct device_attribute *attr,
@@ -317,6 +322,10 @@ static int sbefifo_check_sbe_state(struct sbefifo *sbefifo)
return -ESHUTDOWN;
}
+ /* Newer SBEFIFOs don't need async FFDC collection */
+ if (!sbefifo->need_async)
+ return 0;
+
/* Is there async FFDC available ? Remember it */
if (sbm & CFAM_SBM_SBE_ASYNC_FFDC)
sbefifo->async_ffdc = true;
@@ -1031,6 +1040,7 @@ static void sbefifo_free(struct device *dev)
static int sbefifo_probe(struct device *dev)
{
+ const struct sbefifo_data *md = of_device_get_match_data(dev);
struct fsi_device *fsi_dev = to_fsi_dev(dev);
struct sbefifo *sbefifo;
struct device_node *np;
@@ -1044,6 +1054,11 @@ static int sbefifo_probe(struct device *dev)
if (!sbefifo)
return -ENOMEM;
+ if (md)
+ sbefifo->need_async = md->need_async;
+ else
+ sbefifo->need_async = true;
+
/* Grab a reference to the device (parent of our cdev), we'll drop it later */
if (!get_device(dev)) {
kfree(sbefifo);
@@ -1128,6 +1143,27 @@ static int sbefifo_remove(struct device *dev)
return 0;
}
+static const struct sbefifo_data p9_sbefifo_data = {
+ .need_async = true,
+};
+
+static const struct sbefifo_data odyssey_sbefifo_data = {
+ .need_async = false,
+};
+
+static const struct of_device_id sbefifo_of_ids[] = {
+ {
+ .compatible = "ibm,p9-sbefifo",
+ .data = &p9_sbefifo_data,
+ },
+ {
+ .compatible = "ibm,odyssey-sbefifo",
+ .data = &odyssey_sbefifo_data,
+ },
+ { }
+};
+MODULE_DEVICE_TABLE(of, sbefifo_of_ids);
+
static const struct fsi_device_id sbefifo_ids[] = {
{
.engine_type = FSI_ENGID_SBE,
@@ -1141,6 +1177,7 @@ static struct fsi_driver sbefifo_drv = {
.drv = {
.name = DEVICE_NAME,
.bus = &fsi_bus_type,
+ .of_match_table = sbefifo_of_ids,
.probe = sbefifo_probe,
.remove = sbefifo_remove,
}
--
2.39.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2 3/3] ARM: dts: aspeed: Update Odyssey SBEFIFO compatible strings
2024-04-15 15:39 [PATCH v2 0/3] fsi: sbefifo: Prevent async FFDC collection for Odyssey SBEFIFOs Eddie James
2024-04-15 15:39 ` [PATCH v2 1/3] dt-bindings: fsi: Document the IBM SBEFIFO engine Eddie James
2024-04-15 15:39 ` [PATCH v2 2/3] fsi: sbefifo: Prevent async FFDC collection for Odyssey SBEFIFOs Eddie James
@ 2024-04-15 15:39 ` Eddie James
2 siblings, 0 replies; 6+ messages in thread
From: Eddie James @ 2024-04-15 15:39 UTC (permalink / raw)
To: linux-aspeed
Cc: joel, andrew, devicetree, linux-fsi, robh, conor+dt, krzk+dt, jk,
alistair, eajames, lakshmiy
Set the new compatible string for Odyssey SBEFIFOs so that they
don't collect async FFDC.
Signed-off-by: Eddie James <eajames@linux.ibm.com>
---
Changes since v1:
- Change "ody" to "odyssey"
.../dts/aspeed/aspeed-bmc-ibm-everest.dts | 64 +++++++++----------
.../arm/boot/dts/aspeed/ibm-power10-quad.dtsi | 64 +++++++++----------
2 files changed, 64 insertions(+), 64 deletions(-)
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts
index 214b2e6a4c6d..27dfe315d633 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts
@@ -2545,7 +2545,7 @@ scom500: scom@1000 {
};
sbefifo500: sbefifo@2400 {
- compatible = "ibm,p9-sbefifo";
+ compatible = "ibm,odyssey-sbefifo";
reg = <0x2400 0x400>;
#address-cells = <1>;
#size-cells = <0>;
@@ -2577,7 +2577,7 @@ scom501: scom@1000 {
};
sbefifo501: sbefifo@2400 {
- compatible = "ibm,p9-sbefifo";
+ compatible = "ibm,odyssey-sbefifo";
reg = <0x2400 0x400>;
#address-cells = <1>;
#size-cells = <0>;
@@ -2609,7 +2609,7 @@ scom510: scom@1000 {
};
sbefifo510: sbefifo@2400 {
- compatible = "ibm,p9-sbefifo";
+ compatible = "ibm,odyssey-sbefifo";
reg = <0x2400 0x400>;
#address-cells = <1>;
#size-cells = <0>;
@@ -2641,7 +2641,7 @@ scom511: scom@1000 {
};
sbefifo511: sbefifo@2400 {
- compatible = "ibm,p9-sbefifo";
+ compatible = "ibm,odyssey-sbefifo";
reg = <0x2400 0x400>;
#address-cells = <1>;
#size-cells = <0>;
@@ -2673,7 +2673,7 @@ scom512: scom@1000 {
};
sbefifo512: sbefifo@2400 {
- compatible = "ibm,p9-sbefifo";
+ compatible = "ibm,odyssey-sbefifo";
reg = <0x2400 0x400>;
#address-cells = <1>;
#size-cells = <0>;
@@ -2705,7 +2705,7 @@ scom513: scom@1000 {
};
sbefifo513: sbefifo@2400 {
- compatible = "ibm,p9-sbefifo";
+ compatible = "ibm,odyssey-sbefifo";
reg = <0x2400 0x400>;
#address-cells = <1>;
#size-cells = <0>;
@@ -2737,7 +2737,7 @@ scom514: scom@1000 {
};
sbefifo514: sbefifo@2400 {
- compatible = "ibm,p9-sbefifo";
+ compatible = "ibm,odyssey-sbefifo";
reg = <0x2400 0x400>;
#address-cells = <1>;
#size-cells = <0>;
@@ -2769,7 +2769,7 @@ scom515: scom@1000 {
};
sbefifo515: sbefifo@2400 {
- compatible = "ibm,p9-sbefifo";
+ compatible = "ibm,odyssey-sbefifo";
reg = <0x2400 0x400>;
#address-cells = <1>;
#size-cells = <0>;
@@ -2918,7 +2918,7 @@ scom602: scom@1000 {
};
sbefifo602: sbefifo@2400 {
- compatible = "ibm,p9-sbefifo";
+ compatible = "ibm,odyssey-sbefifo";
reg = <0x2400 0x400>;
#address-cells = <1>;
#size-cells = <0>;
@@ -2950,7 +2950,7 @@ scom603: scom@1000 {
};
sbefifo603: sbefifo@2400 {
- compatible = "ibm,p9-sbefifo";
+ compatible = "ibm,odyssey-sbefifo";
reg = <0x2400 0x400>;
#address-cells = <1>;
#size-cells = <0>;
@@ -2982,7 +2982,7 @@ scom610: scom@1000 {
};
sbefifo610: sbefifo@2400 {
- compatible = "ibm,p9-sbefifo";
+ compatible = "ibm,odyssey-sbefifo";
reg = <0x2400 0x400>;
#address-cells = <1>;
#size-cells = <0>;
@@ -3014,7 +3014,7 @@ scom611: scom@1000 {
};
sbefifo611: sbefifo@2400 {
- compatible = "ibm,p9-sbefifo";
+ compatible = "ibm,odyssey-sbefifo";
reg = <0x2400 0x400>;
#address-cells = <1>;
#size-cells = <0>;
@@ -3046,7 +3046,7 @@ scom614: scom@1000 {
};
sbefifo614: sbefifo@2400 {
- compatible = "ibm,p9-sbefifo";
+ compatible = "ibm,odyssey-sbefifo";
reg = <0x2400 0x400>;
#address-cells = <1>;
#size-cells = <0>;
@@ -3078,7 +3078,7 @@ scom615: scom@1000 {
};
sbefifo615: sbefifo@2400 {
- compatible = "ibm,p9-sbefifo";
+ compatible = "ibm,odyssey-sbefifo";
reg = <0x2400 0x400>;
#address-cells = <1>;
#size-cells = <0>;
@@ -3110,7 +3110,7 @@ scom616: scom@1000 {
};
sbefifo616: sbefifo@2400 {
- compatible = "ibm,p9-sbefifo";
+ compatible = "ibm,odyssey-sbefifo";
reg = <0x2400 0x400>;
#address-cells = <1>;
#size-cells = <0>;
@@ -3142,7 +3142,7 @@ scom617: scom@1000 {
};
sbefifo617: sbefifo@2400 {
- compatible = "ibm,p9-sbefifo";
+ compatible = "ibm,odyssey-sbefifo";
reg = <0x2400 0x400>;
#address-cells = <1>;
#size-cells = <0>;
@@ -3291,7 +3291,7 @@ scom700: scom@1000 {
};
sbefifo700: sbefifo@2400 {
- compatible = "ibm,p9-sbefifo";
+ compatible = "ibm,odyssey-sbefifo";
reg = <0x2400 0x400>;
#address-cells = <1>;
#size-cells = <0>;
@@ -3323,7 +3323,7 @@ scom701: scom@1000 {
};
sbefifo701: sbefifo@2400 {
- compatible = "ibm,p9-sbefifo";
+ compatible = "ibm,odyssey-sbefifo";
reg = <0x2400 0x400>;
#address-cells = <1>;
#size-cells = <0>;
@@ -3355,7 +3355,7 @@ scom710: scom@1000 {
};
sbefifo710: sbefifo@2400 {
- compatible = "ibm,p9-sbefifo";
+ compatible = "ibm,odyssey-sbefifo";
reg = <0x2400 0x400>;
#address-cells = <1>;
#size-cells = <0>;
@@ -3387,7 +3387,7 @@ scom711: scom@1000 {
};
sbefifo711: sbefifo@2400 {
- compatible = "ibm,p9-sbefifo";
+ compatible = "ibm,odyssey-sbefifo";
reg = <0x2400 0x400>;
#address-cells = <1>;
#size-cells = <0>;
@@ -3419,7 +3419,7 @@ scom712: scom@1000 {
};
sbefifo712: sbefifo@2400 {
- compatible = "ibm,p9-sbefifo";
+ compatible = "ibm,odyssey-sbefifo";
reg = <0x2400 0x400>;
#address-cells = <1>;
#size-cells = <0>;
@@ -3451,7 +3451,7 @@ scom713: scom@1000 {
};
sbefifo713: sbefifo@2400 {
- compatible = "ibm,p9-sbefifo";
+ compatible = "ibm,odyssey-sbefifo";
reg = <0x2400 0x400>;
#address-cells = <1>;
#size-cells = <0>;
@@ -3483,7 +3483,7 @@ scom714: scom@1000 {
};
sbefifo714: sbefifo@2400 {
- compatible = "ibm,p9-sbefifo";
+ compatible = "ibm,odyssey-sbefifo";
reg = <0x2400 0x400>;
#address-cells = <1>;
#size-cells = <0>;
@@ -3515,7 +3515,7 @@ scom715: scom@1000 {
};
sbefifo715: sbefifo@2400 {
- compatible = "ibm,p9-sbefifo";
+ compatible = "ibm,odyssey-sbefifo";
reg = <0x2400 0x400>;
#address-cells = <1>;
#size-cells = <0>;
@@ -3664,7 +3664,7 @@ scom802: scom@1000 {
};
sbefifo802: sbefifo@2400 {
- compatible = "ibm,p9-sbefifo";
+ compatible = "ibm,odyssey-sbefifo";
reg = <0x2400 0x400>;
#address-cells = <1>;
#size-cells = <0>;
@@ -3696,7 +3696,7 @@ scom803: scom@1000 {
};
sbefifo803: sbefifo@2400 {
- compatible = "ibm,p9-sbefifo";
+ compatible = "ibm,odyssey-sbefifo";
reg = <0x2400 0x400>;
#address-cells = <1>;
#size-cells = <0>;
@@ -3728,7 +3728,7 @@ scom810: scom@1000 {
};
sbefifo810: sbefifo@2400 {
- compatible = "ibm,p9-sbefifo";
+ compatible = "ibm,odyssey-sbefifo";
reg = <0x2400 0x400>;
#address-cells = <1>;
#size-cells = <0>;
@@ -3760,7 +3760,7 @@ scom811: scom@1000 {
};
sbefifo811: sbefifo@2400 {
- compatible = "ibm,p9-sbefifo";
+ compatible = "ibm,odyssey-sbefifo";
reg = <0x2400 0x400>;
#address-cells = <1>;
#size-cells = <0>;
@@ -3792,7 +3792,7 @@ scom814: scom@1000 {
};
sbefifo814: sbefifo@2400 {
- compatible = "ibm,p9-sbefifo";
+ compatible = "ibm,odyssey-sbefifo";
reg = <0x2400 0x400>;
#address-cells = <1>;
#size-cells = <0>;
@@ -3824,7 +3824,7 @@ scom815: scom@1000 {
};
sbefifo815: sbefifo@2400 {
- compatible = "ibm,p9-sbefifo";
+ compatible = "ibm,odyssey-sbefifo";
reg = <0x2400 0x400>;
#address-cells = <1>;
#size-cells = <0>;
@@ -3856,7 +3856,7 @@ scom816: scom@1000 {
};
sbefifo816: sbefifo@2400 {
- compatible = "ibm,p9-sbefifo";
+ compatible = "ibm,odyssey-sbefifo";
reg = <0x2400 0x400>;
#address-cells = <1>;
#size-cells = <0>;
@@ -3888,7 +3888,7 @@ scom817: scom@1000 {
};
sbefifo817: sbefifo@2400 {
- compatible = "ibm,p9-sbefifo";
+ compatible = "ibm,odyssey-sbefifo";
reg = <0x2400 0x400>;
#address-cells = <1>;
#size-cells = <0>;
diff --git a/arch/arm/boot/dts/aspeed/ibm-power10-quad.dtsi b/arch/arm/boot/dts/aspeed/ibm-power10-quad.dtsi
index 57494c744b5d..58848e77143c 100644
--- a/arch/arm/boot/dts/aspeed/ibm-power10-quad.dtsi
+++ b/arch/arm/boot/dts/aspeed/ibm-power10-quad.dtsi
@@ -22,7 +22,7 @@ scom100: scom@1000 {
};
sbefifo100: sbefifo@2400 {
- compatible = "ibm,p9-sbefifo";
+ compatible = "ibm,odyssey-sbefifo";
reg = <0x2400 0x400>;
#address-cells = <1>;
#size-cells = <0>;
@@ -50,7 +50,7 @@ scom101: scom@1000 {
};
sbefifo101: sbefifo@2400 {
- compatible = "ibm,p9-sbefifo";
+ compatible = "ibm,odyssey-sbefifo";
reg = <0x2400 0x400>;
#address-cells = <1>;
#size-cells = <0>;
@@ -78,7 +78,7 @@ scom110: scom@1000 {
};
sbefifo110: sbefifo@2400 {
- compatible = "ibm,p9-sbefifo";
+ compatible = "ibm,odyssey-sbefifo";
reg = <0x2400 0x400>;
#address-cells = <1>;
#size-cells = <0>;
@@ -106,7 +106,7 @@ scom111: scom@1000 {
};
sbefifo111: sbefifo@2400 {
- compatible = "ibm,p9-sbefifo";
+ compatible = "ibm,odyssey-sbefifo";
reg = <0x2400 0x400>;
#address-cells = <1>;
#size-cells = <0>;
@@ -134,7 +134,7 @@ scom112: scom@1000 {
};
sbefifo112: sbefifo@2400 {
- compatible = "ibm,p9-sbefifo";
+ compatible = "ibm,odyssey-sbefifo";
reg = <0x2400 0x400>;
#address-cells = <1>;
#size-cells = <0>;
@@ -162,7 +162,7 @@ scom113: scom@1000 {
};
sbefifo113: sbefifo@2400 {
- compatible = "ibm,p9-sbefifo";
+ compatible = "ibm,odyssey-sbefifo";
reg = <0x2400 0x400>;
#address-cells = <1>;
#size-cells = <0>;
@@ -190,7 +190,7 @@ scom114: scom@1000 {
};
sbefifo114: sbefifo@2400 {
- compatible = "ibm,p9-sbefifo";
+ compatible = "ibm,odyssey-sbefifo";
reg = <0x2400 0x400>;
#address-cells = <1>;
#size-cells = <0>;
@@ -218,7 +218,7 @@ scom115: scom@1000 {
};
sbefifo115: sbefifo@2400 {
- compatible = "ibm,p9-sbefifo";
+ compatible = "ibm,odyssey-sbefifo";
reg = <0x2400 0x400>;
#address-cells = <1>;
#size-cells = <0>;
@@ -246,7 +246,7 @@ scom202: scom@1000 {
};
sbefifo202: sbefifo@2400 {
- compatible = "ibm,p9-sbefifo";
+ compatible = "ibm,odyssey-sbefifo";
reg = <0x2400 0x400>;
#address-cells = <1>;
#size-cells = <0>;
@@ -274,7 +274,7 @@ scom203: scom@1000 {
};
sbefifo203: sbefifo@2400 {
- compatible = "ibm,p9-sbefifo";
+ compatible = "ibm,odyssey-sbefifo";
reg = <0x2400 0x400>;
#address-cells = <1>;
#size-cells = <0>;
@@ -302,7 +302,7 @@ scom210: scom@1000 {
};
sbefifo210: sbefifo@2400 {
- compatible = "ibm,p9-sbefifo";
+ compatible = "ibm,odyssey-sbefifo";
reg = <0x2400 0x400>;
#address-cells = <1>;
#size-cells = <0>;
@@ -330,7 +330,7 @@ scom211: scom@1000 {
};
sbefifo211: sbefifo@2400 {
- compatible = "ibm,p9-sbefifo";
+ compatible = "ibm,odyssey-sbefifo";
reg = <0x2400 0x400>;
#address-cells = <1>;
#size-cells = <0>;
@@ -358,7 +358,7 @@ scom214: scom@1000 {
};
sbefifo214: sbefifo@2400 {
- compatible = "ibm,p9-sbefifo";
+ compatible = "ibm,odyssey-sbefifo";
reg = <0x2400 0x400>;
#address-cells = <1>;
#size-cells = <0>;
@@ -386,7 +386,7 @@ scom215: scom@1000 {
};
sbefifo215: sbefifo@2400 {
- compatible = "ibm,p9-sbefifo";
+ compatible = "ibm,odyssey-sbefifo";
reg = <0x2400 0x400>;
#address-cells = <1>;
#size-cells = <0>;
@@ -414,7 +414,7 @@ scom216: scom@1000 {
};
sbefifo216: sbefifo@2400 {
- compatible = "ibm,p9-sbefifo";
+ compatible = "ibm,odyssey-sbefifo";
reg = <0x2400 0x400>;
#address-cells = <1>;
#size-cells = <0>;
@@ -442,7 +442,7 @@ scom217: scom@1000 {
};
sbefifo217: sbefifo@2400 {
- compatible = "ibm,p9-sbefifo";
+ compatible = "ibm,odyssey-sbefifo";
reg = <0x2400 0x400>;
#address-cells = <1>;
#size-cells = <0>;
@@ -492,7 +492,7 @@ scom300: scom@1000 {
};
sbefifo300: sbefifo@2400 {
- compatible = "ibm,p9-sbefifo";
+ compatible = "ibm,odyssey-sbefifo";
reg = <0x2400 0x400>;
#address-cells = <1>;
#size-cells = <0>;
@@ -524,7 +524,7 @@ scom301: scom@1000 {
};
sbefifo301: sbefifo@2400 {
- compatible = "ibm,p9-sbefifo";
+ compatible = "ibm,odyssey-sbefifo";
reg = <0x2400 0x400>;
#address-cells = <1>;
#size-cells = <0>;
@@ -556,7 +556,7 @@ scom310: scom@1000 {
};
sbefifo310: sbefifo@2400 {
- compatible = "ibm,p9-sbefifo";
+ compatible = "ibm,odyssey-sbefifo";
reg = <0x2400 0x400>;
#address-cells = <1>;
#size-cells = <0>;
@@ -588,7 +588,7 @@ scom311: scom@1000 {
};
sbefifo311: sbefifo@2400 {
- compatible = "ibm,p9-sbefifo";
+ compatible = "ibm,odyssey-sbefifo";
reg = <0x2400 0x400>;
#address-cells = <1>;
#size-cells = <0>;
@@ -620,7 +620,7 @@ scom312: scom@1000 {
};
sbefifo312: sbefifo@2400 {
- compatible = "ibm,p9-sbefifo";
+ compatible = "ibm,odyssey-sbefifo";
reg = <0x2400 0x400>;
#address-cells = <1>;
#size-cells = <0>;
@@ -652,7 +652,7 @@ scom313: scom@1000 {
};
sbefifo313: sbefifo@2400 {
- compatible = "ibm,p9-sbefifo";
+ compatible = "ibm,odyssey-sbefifo";
reg = <0x2400 0x400>;
#address-cells = <1>;
#size-cells = <0>;
@@ -684,7 +684,7 @@ scom314: scom@1000 {
};
sbefifo314: sbefifo@2400 {
- compatible = "ibm,p9-sbefifo";
+ compatible = "ibm,odyssey-sbefifo";
reg = <0x2400 0x400>;
#address-cells = <1>;
#size-cells = <0>;
@@ -716,7 +716,7 @@ scom315: scom@1000 {
};
sbefifo315: sbefifo@2400 {
- compatible = "ibm,p9-sbefifo";
+ compatible = "ibm,odyssey-sbefifo";
reg = <0x2400 0x400>;
#address-cells = <1>;
#size-cells = <0>;
@@ -865,7 +865,7 @@ scom402: scom@1000 {
};
sbefifo402: sbefifo@2400 {
- compatible = "ibm,p9-sbefifo";
+ compatible = "ibm,odyssey-sbefifo";
reg = <0x2400 0x400>;
#address-cells = <1>;
#size-cells = <0>;
@@ -897,7 +897,7 @@ scom403: scom@1000 {
};
sbefifo403: sbefifo@2400 {
- compatible = "ibm,p9-sbefifo";
+ compatible = "ibm,odyssey-sbefifo";
reg = <0x2400 0x400>;
#address-cells = <1>;
#size-cells = <0>;
@@ -929,7 +929,7 @@ scom410: scom@1000 {
};
sbefifo410: sbefifo@2400 {
- compatible = "ibm,p9-sbefifo";
+ compatible = "ibm,odyssey-sbefifo";
reg = <0x2400 0x400>;
#address-cells = <1>;
#size-cells = <0>;
@@ -961,7 +961,7 @@ scom411: scom@1000 {
};
sbefifo411: sbefifo@2400 {
- compatible = "ibm,p9-sbefifo";
+ compatible = "ibm,odyssey-sbefifo";
reg = <0x2400 0x400>;
#address-cells = <1>;
#size-cells = <0>;
@@ -993,7 +993,7 @@ scom414: scom@1000 {
};
sbefifo414: sbefifo@2400 {
- compatible = "ibm,p9-sbefifo";
+ compatible = "ibm,odyssey-sbefifo";
reg = <0x2400 0x400>;
#address-cells = <1>;
#size-cells = <0>;
@@ -1025,7 +1025,7 @@ scom415: scom@1000 {
};
sbefifo415: sbefifo@2400 {
- compatible = "ibm,p9-sbefifo";
+ compatible = "ibm,odyssey-sbefifo";
reg = <0x2400 0x400>;
#address-cells = <1>;
#size-cells = <0>;
@@ -1057,7 +1057,7 @@ scom416: scom@1000 {
};
sbefifo416: sbefifo@2400 {
- compatible = "ibm,p9-sbefifo";
+ compatible = "ibm,odyssey-sbefifo";
reg = <0x2400 0x400>;
#address-cells = <1>;
#size-cells = <0>;
@@ -1089,7 +1089,7 @@ scom417: scom@1000 {
};
sbefifo417: sbefifo@2400 {
- compatible = "ibm,p9-sbefifo";
+ compatible = "ibm,odyssey-sbefifo";
reg = <0x2400 0x400>;
#address-cells = <1>;
#size-cells = <0>;
--
2.39.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/3] dt-bindings: fsi: Document the IBM SBEFIFO engine
2024-04-15 15:39 ` [PATCH v2 1/3] dt-bindings: fsi: Document the IBM SBEFIFO engine Eddie James
@ 2024-04-16 17:25 ` Conor Dooley
2024-04-19 20:32 ` Eddie James
0 siblings, 1 reply; 6+ messages in thread
From: Conor Dooley @ 2024-04-16 17:25 UTC (permalink / raw)
To: Eddie James
Cc: linux-aspeed, joel, andrew, devicetree, linux-fsi, robh, conor+dt,
krzk+dt, jk, alistair, lakshmiy
[-- Attachment #1: Type: text/plain, Size: 2081 bytes --]
On Mon, Apr 15, 2024 at 10:39:05AM -0500, Eddie James wrote:
> The SBEFIFO engine provides an interface to the POWER processor
> Self Boot Engine (SBE).
>
> Signed-off-by: Eddie James <eajames@linux.ibm.com>
> ---
> Changes since v1:
> - Chance "ody" to "odyssey"
> - Fix typo in commit message
> - Reword description to describe the hardware only
>
> .../devicetree/bindings/fsi/ibm,sbefifo.yaml | 39 +++++++++++++++++++
> 1 file changed, 39 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/fsi/ibm,sbefifo.yaml
>
> diff --git a/Documentation/devicetree/bindings/fsi/ibm,sbefifo.yaml b/Documentation/devicetree/bindings/fsi/ibm,sbefifo.yaml
> new file mode 100644
> index 000000000000..69521b1cfb25
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/fsi/ibm,sbefifo.yaml
Filename matching a compatible please.
> @@ -0,0 +1,39 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/fsi/ibm,sbefifo.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: IBM FSI-attached SBEFIFO engine
> +
> +maintainers:
> + - Eddie James <eajames@linux.ibm.com>
> +
> +description: |
This | should not be needed, there's no formatting to preserve.
> + The SBEFIFO is an FSI CFAM engine that provides an interface to the
> + POWER processor Self Boot Engine (SBE). This node will always be a child
> + of an FSI CFAM node; see fsi.txt for details on FSI slave and CFAM
> + nodes.
> +
> +properties:
> + compatible:
> + enum:
> + - ibm,p9-sbefifo
> + - ibm,odyssey-sbefifo
> +
> + reg:
> + items:
> + - description: FSI slave address
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + sbefifo@2400 {
Per fsi.txt, the generic node name looks like it should be
"fsi-slave-engine"?
Cheers,
Conor.
> + compatible = "ibm,p9-sbefifo";
> + reg = <0x2400 0x400>;
> + };
> --
> 2.39.3
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/3] dt-bindings: fsi: Document the IBM SBEFIFO engine
2024-04-16 17:25 ` Conor Dooley
@ 2024-04-19 20:32 ` Eddie James
0 siblings, 0 replies; 6+ messages in thread
From: Eddie James @ 2024-04-19 20:32 UTC (permalink / raw)
To: Conor Dooley
Cc: linux-aspeed, joel, andrew, devicetree, linux-fsi, robh, conor+dt,
krzk+dt, jk, alistair, lakshmiy
On 4/16/24 12:25, Conor Dooley wrote:
> On Mon, Apr 15, 2024 at 10:39:05AM -0500, Eddie James wrote:
>> The SBEFIFO engine provides an interface to the POWER processor
>> Self Boot Engine (SBE).
>>
>> Signed-off-by: Eddie James <eajames@linux.ibm.com>
>> ---
>> Changes since v1:
>> - Chance "ody" to "odyssey"
>> - Fix typo in commit message
>> - Reword description to describe the hardware only
>>
>> .../devicetree/bindings/fsi/ibm,sbefifo.yaml | 39 +++++++++++++++++++
>> 1 file changed, 39 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/fsi/ibm,sbefifo.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/fsi/ibm,sbefifo.yaml b/Documentation/devicetree/bindings/fsi/ibm,sbefifo.yaml
>> new file mode 100644
>> index 000000000000..69521b1cfb25
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/fsi/ibm,sbefifo.yaml
> Filename matching a compatible please.
Ack, and ack to your comments below. I'll send v3.
Thanks,
Eddie
>
>> @@ -0,0 +1,39 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/fsi/ibm,sbefifo.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: IBM FSI-attached SBEFIFO engine
>> +
>> +maintainers:
>> + - Eddie James <eajames@linux.ibm.com>
>> +
>> +description: |
> This | should not be needed, there's no formatting to preserve.
>
>> + The SBEFIFO is an FSI CFAM engine that provides an interface to the
>> + POWER processor Self Boot Engine (SBE). This node will always be a child
>> + of an FSI CFAM node; see fsi.txt for details on FSI slave and CFAM
>> + nodes.
>> +
>> +properties:
>> + compatible:
>> + enum:
>> + - ibm,p9-sbefifo
>> + - ibm,odyssey-sbefifo
>> +
>> + reg:
>> + items:
>> + - description: FSI slave address
>> +
>> +required:
>> + - compatible
>> + - reg
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> + - |
>> + sbefifo@2400 {
> Per fsi.txt, the generic node name looks like it should be
> "fsi-slave-engine"?
>
> Cheers,
> Conor.
>
>> + compatible = "ibm,p9-sbefifo";
>> + reg = <0x2400 0x400>;
>> + };
>> --
>> 2.39.3
>>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-04-19 20:32 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-15 15:39 [PATCH v2 0/3] fsi: sbefifo: Prevent async FFDC collection for Odyssey SBEFIFOs Eddie James
2024-04-15 15:39 ` [PATCH v2 1/3] dt-bindings: fsi: Document the IBM SBEFIFO engine Eddie James
2024-04-16 17:25 ` Conor Dooley
2024-04-19 20:32 ` Eddie James
2024-04-15 15:39 ` [PATCH v2 2/3] fsi: sbefifo: Prevent async FFDC collection for Odyssey SBEFIFOs Eddie James
2024-04-15 15:39 ` [PATCH v2 3/3] ARM: dts: aspeed: Update Odyssey SBEFIFO compatible strings Eddie James
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).