Re: [PATCH v3 2/3] dt-bindings: iio: dac: Add adi,ad3530r.yaml

[Krzysztof Kozlowski <krzk@kernel.org>]

On 03/04/2025 08:59, Paller, Kim Seer wrote:
> 
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzk@kernel.org>
>> Sent: Thursday, April 3, 2025 2:44 PM
>> To: Paller, Kim Seer <KimSeer.Paller@analog.com>
>> Cc: Jonathan Cameron <jic23@kernel.org>; Lars-Peter Clausen
>> <lars@metafoo.de>; Hennerich, Michael <Michael.Hennerich@analog.com>;
>> Rob Herring <robh@kernel.org>; Krzysztof Kozlowski <krzk+dt@kernel.org>;
>> Conor Dooley <conor+dt@kernel.org>; linux-iio@vger.kernel.org; linux-
>> kernel@vger.kernel.org; devicetree@vger.kernel.org
>> Subject: Re: [PATCH v3 2/3] dt-bindings: iio: dac: Add adi,ad3530r.yaml
>>
>> [External]
>>
>> On Thu, Apr 03, 2025 at 01:33:56PM +0800, Kim Seer Paller wrote:
>>> Document the AD3530/AD3530R (8-channel) and AD3531/AD3531R (4-
>> channel)
>>> low-power, 16-bit, buffered voltage output DACs with software-
>>> programmable gain controls. They provide full-scale output spans of
>>> 2.5V or 5V for reference voltages of 2.5V. These devices operate on a
>>> single 2.7V to 5.5V supply and are guaranteed to be monotonic by design.
>>> The "R" variants include a 2.5V, 5ppm/°C internal reference, which is
>>> disabled by default.
>>>
>>> Signed-off-by: Kim Seer Paller <kimseer.paller@analog.com>
>>> ---
>>>  .../devicetree/bindings/iio/dac/adi,ad3530r.yaml   | 99
>> ++++++++++++++++++++++
>>>  MAINTAINERS                                        |  7 ++
>>>  2 files changed, 106 insertions(+)
>>
>> You got report about error in v2, which you did not respond to.
>>
>> You send v3... with same error. I don't understand this.
> 
> I'm not sure, but based on the information provided, the errors might be
> unrelated to the driver, or I might have missed something.

It's your job to respond to errors one way or another (unless there are
obviously false positives). Ignoring them means this is marked as
"changes requested".

Best regards,
Krzysztof