Re: [PATCH v1 2/7] dt-bindings: soc: qcom: cpr3: Add bindings for IPQ9574

[Krzysztof Kozlowski <krzk@kernel.org>]

On 20/06/2024 10:14, Varadarajan Narayanan wrote:
> Add the bindings for the IPQ9574 CPR3 driver to the documentation.
> 
> Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com>
> ---
>  .../bindings/soc/qcom/qcom,cpr3.yaml          | 32 +++++++++++++++++++
>  1 file changed, 32 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,cpr3.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,cpr3.yaml
> index acf2e294866b..d5e02505c863 100644
> --- a/Documentation/devicetree/bindings/soc/qcom/qcom,cpr3.yaml
> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,cpr3.yaml
> @@ -24,6 +24,7 @@ properties:
>        - const: qcom,cpr4
>        - items:
>            - enum:
> +              - qcom,ipq9574-cprh
>                - qcom,msm8998-cprh
>                - qcom,sdm630-cprh
>            - const: qcom,cprh
> @@ -52,9 +53,11 @@ properties:
>  
>    nvmem-cells:
>      description: Cells containing the fuse corners and revision data
> +    minItems: 17
>      maxItems: 32
>  
>    nvmem-cell-names:
> +    minItems: 17
>      maxItems: 32
>  
>    operating-points-v2: true
> @@ -74,6 +77,35 @@ required:
>  additionalProperties: false
>  
>  allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - qcom,ipq9574-cprh
> +    then:
> +      properties:
> +

No need for blank line.

Constrain nvmem-cells. Also constrain the other variant.



Best regards,
Krzysztof