* [PATCH 0/2] Add rpmhpd power domains driver support for QCS615
@ 2024-09-20 4:08 Tingguo Cheng
2024-09-20 4:08 ` [PATCH 1/2] dt-bindings: power: qcom,rpmpd: document qcs615 RPMh power domains Tingguo Cheng
2024-09-20 4:08 ` [PATCH 2/2] pmdomain: qcom: rpmhpd: Add qcs615 " Tingguo Cheng
0 siblings, 2 replies; 6+ messages in thread
From: Tingguo Cheng @ 2024-09-20 4:08 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson,
Ulf Hansson
Cc: kernel, linux-arm-msm, devicetree, linux-kernel, linux-pm,
quic_fenglinw, quic_tingweiz, Tingguo Cheng
Document the qcom,qcs615-rpmhpd compatible and add power domains in
rpmhpd driver to support QCS615.
Signed-off-by: Tingguo Cheng <quic_tingguoc@quicinc.com>
---
Tingguo Cheng (2):
dt-bindings: power: qcom,rpmpd: document qcs615 RPMh power domains
pmdomain: qcom: rpmhpd: Add qcs615 power domains
Documentation/devicetree/bindings/power/qcom,rpmpd.yaml | 1 +
drivers/pmdomain/qcom/rpmhpd.c | 12 ++++++++++++
2 files changed, 13 insertions(+)
---
base-commit: 4f3e012d4cfd1d9bf837870c961f462ca9f23ebe
change-id: 20240920-add_qcs615_powerdomains_driver_support-c934be5c56fb
Best regards,
--
Tingguo Cheng <quic_tingguoc@quicinc.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 1/2] dt-bindings: power: qcom,rpmpd: document qcs615 RPMh power domains 2024-09-20 4:08 [PATCH 0/2] Add rpmhpd power domains driver support for QCS615 Tingguo Cheng @ 2024-09-20 4:08 ` Tingguo Cheng 2024-09-20 13:15 ` Krzysztof Kozlowski 2024-09-20 4:08 ` [PATCH 2/2] pmdomain: qcom: rpmhpd: Add qcs615 " Tingguo Cheng 1 sibling, 1 reply; 6+ messages in thread From: Tingguo Cheng @ 2024-09-20 4:08 UTC (permalink / raw) To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Ulf Hansson Cc: kernel, linux-arm-msm, devicetree, linux-kernel, linux-pm, quic_fenglinw, quic_tingweiz, Tingguo Cheng Add compatible string for the RPMh power domains on qcs615 platform. Signed-off-by: Tingguo Cheng <quic_tingguoc@quicinc.com> --- Documentation/devicetree/bindings/power/qcom,rpmpd.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml index 929b7ef9c1bcdae8194adfdfd6114573ab4d59cd..b4f4ea905667a94806f632166db54384bc9de8e3 100644 --- a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml +++ b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml @@ -32,6 +32,7 @@ properties: - qcom,msm8998-rpmpd - qcom,qcm2290-rpmpd - qcom,qcs404-rpmpd + - qcom,qcs615-rpmhpd - qcom,qdu1000-rpmhpd - qcom,qm215-rpmpd - qcom,sa8155p-rpmhpd -- 2.34.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: power: qcom,rpmpd: document qcs615 RPMh power domains 2024-09-20 4:08 ` [PATCH 1/2] dt-bindings: power: qcom,rpmpd: document qcs615 RPMh power domains Tingguo Cheng @ 2024-09-20 13:15 ` Krzysztof Kozlowski 2024-09-27 12:16 ` Tingguo Cheng 0 siblings, 1 reply; 6+ messages in thread From: Krzysztof Kozlowski @ 2024-09-20 13:15 UTC (permalink / raw) To: Tingguo Cheng, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Ulf Hansson Cc: kernel, linux-arm-msm, devicetree, linux-kernel, linux-pm, quic_fenglinw, quic_tingweiz On 20/09/2024 06:08, Tingguo Cheng wrote: > Add compatible string for the RPMh power domains on qcs615 platform. > > Signed-off-by: Tingguo Cheng <quic_tingguoc@quicinc.com> > --- > Documentation/devicetree/bindings/power/qcom,rpmpd.yaml | 1 + > 1 file changed, 1 insertion(+) > You sent within 30 minutes two independent patchsets touching the same part of code, so you knew it will lead to conflicts. I don't get how you imagine this to be applied. I suggest combining patchsets in such case. Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: power: qcom,rpmpd: document qcs615 RPMh power domains 2024-09-20 13:15 ` Krzysztof Kozlowski @ 2024-09-27 12:16 ` Tingguo Cheng 2024-09-27 12:25 ` Krzysztof Kozlowski 0 siblings, 1 reply; 6+ messages in thread From: Tingguo Cheng @ 2024-09-27 12:16 UTC (permalink / raw) To: Krzysztof Kozlowski, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Ulf Hansson Cc: kernel, linux-arm-msm, devicetree, linux-kernel, linux-pm, quic_fenglinw, quic_tingweiz On 9/20/2024 9:15 PM, Krzysztof Kozlowski wrote: > On 20/09/2024 06:08, Tingguo Cheng wrote: >> Add compatible string for the RPMh power domains on qcs615 platform. >> >> Signed-off-by: Tingguo Cheng <quic_tingguoc@quicinc.com> >> --- >> Documentation/devicetree/bindings/power/qcom,rpmpd.yaml | 1 + >> 1 file changed, 1 insertion(+) >> > > You sent within 30 minutes two independent patchsets touching the same > part of code, so you knew it will lead to conflicts. I don't get how you > imagine this to be applied. I suggest combining patchsets in such case. I created a new patchset by combining the two patchsets into one to resolve the conflicts. 20240927-add_qcs615_qcs8300_powerdomains_driver_support-v2-0-18c030ad7b68@quicinc.com | |<--Patchset 1:Current patchset. |<--Patchset 2:https://lore.kernel.org/r/20240920-add_qcs8300_powerdomains_driver_support-v1-0-96a2a08841da@quicinc.com > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Best regards, > Krzysztof > > -- Thank you & BRs Tingguo ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: power: qcom,rpmpd: document qcs615 RPMh power domains 2024-09-27 12:16 ` Tingguo Cheng @ 2024-09-27 12:25 ` Krzysztof Kozlowski 0 siblings, 0 replies; 6+ messages in thread From: Krzysztof Kozlowski @ 2024-09-27 12:25 UTC (permalink / raw) To: Tingguo Cheng, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Ulf Hansson Cc: kernel, linux-arm-msm, devicetree, linux-kernel, linux-pm, quic_fenglinw, quic_tingweiz On 27/09/2024 14:16, Tingguo Cheng wrote: > > > On 9/20/2024 9:15 PM, Krzysztof Kozlowski wrote: >> On 20/09/2024 06:08, Tingguo Cheng wrote: >>> Add compatible string for the RPMh power domains on qcs615 platform. >>> >>> Signed-off-by: Tingguo Cheng <quic_tingguoc@quicinc.com> >>> --- >>> Documentation/devicetree/bindings/power/qcom,rpmpd.yaml | 1 + >>> 1 file changed, 1 insertion(+) >>> >> >> You sent within 30 minutes two independent patchsets touching the same >> part of code, so you knew it will lead to conflicts. I don't get how you >> imagine this to be applied. I suggest combining patchsets in such case. > I created a new patchset by combining the two patchsets into one to > resolve the conflicts. > > 20240927-add_qcs615_qcs8300_powerdomains_driver_support-v2-0-18c030ad7b68@quicinc.com > | > |<--Patchset 1:Current patchset. > |<--Patchset > 2:https://lore.kernel.org/r/20240920-add_qcs8300_powerdomains_driver_support-v1-0-96a2a08841da@quicinc.com > >> >> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> And this? Please carefully read your internal go/upstream guides and in-kernel submitting patches before posting. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/2] pmdomain: qcom: rpmhpd: Add qcs615 power domains 2024-09-20 4:08 [PATCH 0/2] Add rpmhpd power domains driver support for QCS615 Tingguo Cheng 2024-09-20 4:08 ` [PATCH 1/2] dt-bindings: power: qcom,rpmpd: document qcs615 RPMh power domains Tingguo Cheng @ 2024-09-20 4:08 ` Tingguo Cheng 1 sibling, 0 replies; 6+ messages in thread From: Tingguo Cheng @ 2024-09-20 4:08 UTC (permalink / raw) To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Ulf Hansson Cc: kernel, linux-arm-msm, devicetree, linux-kernel, linux-pm, quic_fenglinw, quic_tingweiz, Tingguo Cheng Add support for power domains exposed by RPMh on the qcs615 platform. Only CX/CX_AO are exposed by RPMh. Consumers such as VDD_MX, EBI, LPI_ MX and LPI_CX will share the power domains. Signed-off-by: Tingguo Cheng <quic_tingguoc@quicinc.com> --- drivers/pmdomain/qcom/rpmhpd.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/pmdomain/qcom/rpmhpd.c b/drivers/pmdomain/qcom/rpmhpd.c index 65505e1e221986ad20751b658374dd0e74719703..2ff1a255f27247e26b4ef0f4cbf1f68010bb0aec 100644 --- a/drivers/pmdomain/qcom/rpmhpd.c +++ b/drivers/pmdomain/qcom/rpmhpd.c @@ -624,7 +624,19 @@ static const struct rpmhpd_desc x1e80100_desc = { .num_pds = ARRAY_SIZE(x1e80100_rpmhpds), }; +/* QCS615 RPMH powerdomains */ +static struct rpmhpd *qcs615_rpmhpds[] = { + [RPMHPD_CX] = &cx, + [RPMHPD_CX_AO] = &cx_ao, +}; + +static const struct rpmhpd_desc qcs615_desc = { + .rpmhpds = qcs615_rpmhpds, + .num_pds = ARRAY_SIZE(qcs615_rpmhpds), +}; + static const struct of_device_id rpmhpd_match_table[] = { + { .compatible = "qcom,qcs615-rpmhpd", .data = &qcs615_desc }, { .compatible = "qcom,qdu1000-rpmhpd", .data = &qdu1000_desc }, { .compatible = "qcom,sa8155p-rpmhpd", .data = &sa8155p_desc }, { .compatible = "qcom,sa8540p-rpmhpd", .data = &sa8540p_desc }, -- 2.34.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-09-27 12:25 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-09-20 4:08 [PATCH 0/2] Add rpmhpd power domains driver support for QCS615 Tingguo Cheng 2024-09-20 4:08 ` [PATCH 1/2] dt-bindings: power: qcom,rpmpd: document qcs615 RPMh power domains Tingguo Cheng 2024-09-20 13:15 ` Krzysztof Kozlowski 2024-09-27 12:16 ` Tingguo Cheng 2024-09-27 12:25 ` Krzysztof Kozlowski 2024-09-20 4:08 ` [PATCH 2/2] pmdomain: qcom: rpmhpd: Add qcs615 " Tingguo Cheng
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).