From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9164BC6FD1C for ; Sat, 25 Mar 2023 11:35:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231856AbjCYLfL (ORCPT ); Sat, 25 Mar 2023 07:35:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54038 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231327AbjCYLfL (ORCPT ); Sat, 25 Mar 2023 07:35:11 -0400 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F0D6BBAB for ; Sat, 25 Mar 2023 04:35:09 -0700 (PDT) Received: by mail-ed1-x529.google.com with SMTP id x3so17446821edb.10 for ; Sat, 25 Mar 2023 04:35:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679744108; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=W8sbl3G2CZLODjlbB1uxWf2aT5vhXcTjxqACgV87rNU=; b=cZXk7l2qJgIojf+tCHcNf4qQzd+VavmXIWepTpdQUQkUEZNWmjigthhKeQm7g4Eee6 QpFl6Jgp/K3DirZGIOipApaS3piHwjON6hkHMWKRxVU+roiH0hikMLSYw4AZoW7yjKmb eaED5OqaeWR7OGu0+olpp7o9/E1xmiQtkIXBiYxXy5NqPNeQDsNMWHTSuctXntPATxTM D8z+Is4U1BhKvPE6vVxZmoboJQAlD1/7R/TaLeK1kId96NehUzOcwLwwkG4kXhBljGYQ bz+vuBOmvaK0IptpeS1YEHv0qaxDzlIyntxrRM1lxiCnMoUJE23C41iIxPcVwpqCcInc xIpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679744108; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=W8sbl3G2CZLODjlbB1uxWf2aT5vhXcTjxqACgV87rNU=; b=Kf4/FFO7KPWwzdD4V9GuVOZyHHJzXkQlnRP1+Ral+s/32St1sRPdINp9iM+g8dt9zr kVvSNhqxTeN723dd6axJNApS0CTYdSzjk1cFM5ViokW5vds0nlOpgcPoxX9OspuVrOz3 u0gif1GGEkjQhEgIafFyZ949P6mErwlnu6PmHrW0JgSir2ZpU4nz0/Zqoyic0123i+8c VSXs9e5c7ych5ZoyUeAddyBMYh4z5tFE8/PskwGs1zwx+3wYCpXj0QECTIFBUnmQur3t kjj2l4kM86MwuQEBbvbEs0i9F53xjlFxZ6cWx6T0Y4LJUSoTbUHEj6ZBef3t0vvAom8P PlVA== X-Gm-Message-State: AAQBX9eyCxtdsO72sjHn+Io5UuqbKnClO6FoRta+lOJ2CeFcBjPodXUx CgT2Z062JoyF/x/bXwvoUHtKEA== X-Google-Smtp-Source: AKy350ZZB2IMfnQvR9XYmhMsZzU0Qst2DCYcRIhiZknm1/aJdstBvEatRrXugUfBv8jhwoMv39amCA== X-Received: by 2002:aa7:da57:0:b0:4fb:80cf:89e6 with SMTP id w23-20020aa7da57000000b004fb80cf89e6mr6473413eds.8.1679744107720; Sat, 25 Mar 2023 04:35:07 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:d230:b2c7:d55:c9c8? ([2a02:810d:15c0:828:d230:b2c7:d55:c9c8]) by smtp.gmail.com with ESMTPSA id 17-20020a508751000000b004bf7905559asm12075408edv.44.2023.03.25.04.35.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 25 Mar 2023 04:35:07 -0700 (PDT) Message-ID: <6da91d8c-6694-9041-2f2f-72a8e95c7df2@linaro.org> Date: Sat, 25 Mar 2023 12:35:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v3 01/11] dt-bindings: arm: Add support for DSB element size Content-Language: en-US To: Tao Zhang , Suzuki K Poulose , Mathieu Poirier , Alexander Shishkin , Konrad Dybcio , Mike Leach , Rob Herring , Krzysztof Kozlowski Cc: Jinlong Mao , Greg Kroah-Hartman , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Tingwei Zhang , Yuanfang Zhang , Trilok Soni , Hao Zhang , linux-arm-msm@vger.kernel.org, Bjorn Andersson References: <1679551448-19160-1-git-send-email-quic_taozha@quicinc.com> <1679551448-19160-2-git-send-email-quic_taozha@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 24/03/2023 10:15, Tao Zhang wrote: >>>> +    $ref: /schemas/types.yaml#/definitions/uint32 >>>> +    minimum: 32 >>>> +    maximum: 64 >>> >>> Shouldn't this be something like oneOf ? It is not a range, but one of >>> those two specific values ? >> >> Yes, "qcom,dsb-element-size" should be an optional option required in >> TPDM >> >> devicetree. Other properties like "qcom,cmb-element-size", >> "qcom,tc-element-size" >> >> and etc. will be added in a later patch series. >> >> I will update this doc according to your advice in the next version of >> the patch. >> >> Tao >> > Correct my misunderstanding in the mail above. > > You are right, DSB element size should be 32-bit or 64-bit. I will > update this in the next Then 'enum', not 'oneOf'. Best regards, Krzysztof