From: Krzysztof Kozlowski <krzk@kernel.org>
To: "qinjian[覃健]" <qinjian@cqplus1.com>
Cc: "robh+dt@kernel.org" <robh+dt@kernel.org>,
"mturquette@baylibre.com" <mturquette@baylibre.com>,
"sboyd@kernel.org" <sboyd@kernel.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"maz@kernel.org" <maz@kernel.org>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"arnd@arndb.de" <arnd@arndb.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v11 2/9] dt-bindings: reset: Add bindings for SP7021 reset driver
Date: Wed, 23 Mar 2022 09:37:08 +0100 [thread overview]
Message-ID: <6dbeda18-a11c-609d-7a8f-bf2e6f27aea7@kernel.org> (raw)
In-Reply-To: <678d1f84d9d240b9983f9d3b82db17d4@cqplus1.com>
On 23/03/2022 02:54, qinjian[覃健] wrote:
>>> +examples:
>>> + - |
>>> + rstc: reset@9c000054 {
>>> + compatible = "sunplus,sp7021-reset";
>>> + #reset-cells = <1>;
>>> + reg = <0x9c000054 0x28>;
>>
>> I asked you to put the reg after compatible in all DTS code and
>> examples. If you do not agree with a comment, please respond. Ignoring
>> it is not cooperative.
>>
>
> Your reply: https://lore.kernel.org/all/d3ac3e2f-71fd-b2b4-7c7e-bb43c681d14e@canonical.com/
>>> + - |
>>> +
>>> + clkc: clock-controller@9c000000 {
>>> + compatible = "sunplus,sp7021-clkc";
>>> + #clock-cells = <1>;
>>> + reg = <0x9c000000 0x280>;
>>
>> In DTS code, please put reg after compatible. In all your examples and
>> DTS patches.
>>
>>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>
> I see your review-tag. So, I misunderstand your comments.
> Did you means 'reg' must directly after the 'compatible', like this?
> clkc: clock-controller@9c000000 {
> #clock-cells = <1>;
> compatible = "sunplus,sp7021-clkc";
> reg = <0x9c000000 0x280>;
You moved now compatible so not. First goes compatible, then goes reg.
clock-controller@.... {
compatible = ....;
reg = ...;
here goes the rest;
}
My review tag was conditional because I asked to change the code. Such
review tag should be used by you if you implement what I asked for.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-03-23 8:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-22 6:16 [PATCH v11 0/9] Add Sunplus SP7021 SoC Support Qin Jian
2022-03-22 6:16 ` [PATCH v11 1/9] dt-bindings: arm: sunplus: Add bindings for Sunplus SP7021 SoC boards Qin Jian
2022-03-22 6:16 ` [PATCH v11 2/9] dt-bindings: reset: Add bindings for SP7021 reset driver Qin Jian
2022-03-22 11:04 ` Krzysztof Kozlowski
2022-03-23 1:54 ` qinjian[覃健]
2022-03-23 8:37 ` Krzysztof Kozlowski [this message]
2022-03-23 8:44 ` qinjian[覃健]
2022-03-22 6:16 ` [PATCH v11 3/9] reset: Add Sunplus " Qin Jian
2022-03-22 6:16 ` [PATCH v11 4/9] dt-bindings: clock: Add bindings for SP7021 clock driver Qin Jian
2022-03-22 11:02 ` Krzysztof Kozlowski
2022-03-22 6:16 ` [PATCH v11 5/9] clk: Add Sunplus " Qin Jian
2022-03-22 6:16 ` [PATCH v11 6/9] dt-bindings: interrupt-controller: Add bindings for SP7021 interrupt controller Qin Jian
2022-03-22 6:16 ` [PATCH v11 7/9] irqchip: Add Sunplus SP7021 interrupt controller driver Qin Jian
2022-03-22 6:16 ` [PATCH v11 8/9] ARM: sunplus: Add initial support for Sunplus SP7021 SoC Qin Jian
2022-03-22 6:17 ` [PATCH v11 9/9] ARM: sp7021_defconfig: Add Sunplus SP7021 defconfig Qin Jian
2022-03-22 10:19 ` Arnd Bergmann
2022-03-23 1:41 ` qinjian[覃健]
2022-03-23 8:20 ` Arnd Bergmann
2022-03-23 8:45 ` qinjian[覃健]
2022-03-22 10:56 ` [PATCH v11 0/9] Add Sunplus SP7021 SoC Support Sudeep Holla
2022-03-23 2:40 ` qinjian[覃健]
2022-03-23 11:15 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6dbeda18-a11c-609d-7a8f-bf2e6f27aea7@kernel.org \
--to=krzk@kernel.org \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maz@kernel.org \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=qinjian@cqplus1.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).