From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CBCD04A07 for ; Thu, 15 Aug 2024 00:25:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723681512; cv=none; b=t8X2QNDvMp0soA1V6WRlyJKD8pBD2ZtJNHBq4Jva6ZLxUhfohKvuh97h7hxQAIxxW9hZXBSjwFN5v+V0k6CHgozWGvBb91elljzdo2fnibpP3J8ypHxQZVXeJvWP7nvOETzBxLexy5EnSQHJ9NAW0/EZIQxZR+yRyaLXXiKl1+c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723681512; c=relaxed/simple; bh=g6+dyTfaV4ejypt384XwkQLfJA1ttnYEy1lC+qK1r3s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Yy3mzKxxKotoMDOxnoJlw7MaiWdAghJ6PYRiSSbbbsaF01rd7XVp2OxTEY1mhCzHBXu5/+i+XT1KBZCWnV9KOK3ql+q7tV0JKHCNtog95uFUYLTix8NIh6nFnGOEHUCPb/JKqNKpLknmm6O1tcpH2IhVqF45BHpUDbFzxbTDQ54= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=rDv/ElSp; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="rDv/ElSp" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4280bca3960so2100515e9.3 for ; Wed, 14 Aug 2024 17:25:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1723681509; x=1724286309; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=N/0QdOsIFxUfrsS8J5sSBj2pcKHUSLNB+HboC0R4mPw=; b=rDv/ElSpxAGvF4j+qx6rEAm6ynQ1lcPvn/R5Jvm7a8ji5r8oQ9LpUpkLN+sLMTyZbo EE8pJLxpqBkyzkyG5VB8Jv9Y132YoDFdsAc6MBOkNmQ+KKnmlCoH/9tMzj8EoUmZhPlM juJqmxN5qQP96wArgc7pl07jimAJkk1SFb5U+oQ4A9U3JWFSuj4/1U2WReKNtIO1ZU7G l7fA8Foxjm1RhjXZ5WHh2VhgcpLRcwyjRe9I6KPNIASJpWOC91v3Cwk8JPZDH7gXna43 4XzoKA44JDofkbWJ2UnvGQEwN4+/IMXZOcEOHZUy3/09oMPgUI2nwtSjOQLtx7OGYLHH Hbrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723681509; x=1724286309; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=N/0QdOsIFxUfrsS8J5sSBj2pcKHUSLNB+HboC0R4mPw=; b=my7/m1M2bEz20KzmAMAS301aTgggg4nMsfHfHbVRcM4/gGtALBb9rguZAD3uX21vzF zuLUBaHwuflsQZa90BStH+e3wtp4OP+JmkEmxRi1i15qtR6sVKUCOgccGtnDAyEuiOrZ ue1/Ljl0qAG4MWjHGCykxsCRLTEcxEn+ZAx/VJbRTqOu8DaO1YeXXO93QQGzejwlI3cn goauakjT4ianA0rGHz4RDbfSpRlH1kqGdswp2l4jHgLj/DJoSGlhGfre4Dff40jpaivT jdcILy/HgHvNMp35+/TFS4OsI11ZBWB33eoeWuPz3dhp38qGYI3/nGtUtxCaW/YDUC/R ofEA== X-Forwarded-Encrypted: i=1; AJvYcCWqPg48ugHVcxYduo1gt1QDqqwve1Ff9XiqP/LIj9NpSrFlyq2m7H/ZytMrtYcr2/yYSED4utAU4OtQe/Oq3UtgtFkvbXseihEkTA== X-Gm-Message-State: AOJu0YzsEarxylMrNX2szcOWdLkw4cDgWyMnK37amKltQr+s4rZwoBoh O4lxlxD3RK8FNT4Ceuhn34fXPl+nTieskJoxwlqIIfc9Bx7qncjcyoCFE+nDUhc= X-Google-Smtp-Source: AGHT+IH6OOO0/mqpv5WEBdqkxeeXkLkx+fI3KP1fNMpiF/1yOPcKF/57UJ/RlG4aNyCcyfEqrARPdA== X-Received: by 2002:a05:600c:138e:b0:427:d8fd:42a9 with SMTP id 5b1f17b1804b1-429dd247c0bmr29414975e9.22.1723681509029; Wed, 14 Aug 2024 17:25:09 -0700 (PDT) Received: from [192.168.0.25] ([176.61.106.227]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-429d877e066sm69470185e9.1.2024.08.14.17.25.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Aug 2024 17:25:08 -0700 (PDT) Message-ID: <6ddaa41b-86cf-44e5-a671-fd70f266642b@linaro.org> Date: Thu, 15 Aug 2024 01:25:07 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 13/13] media: qcom: camss: Add support for VFE hardware version Titan 780 To: Depeng Shao , rfoss@kernel.org, todor.too@gmail.com, bryan.odonoghue@linaro.org, mchehab@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@quicinc.com, Yongsheng Li References: <20240812144131.369378-1-quic_depengs@quicinc.com> <20240812144131.369378-14-quic_depengs@quicinc.com> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <20240812144131.369378-14-quic_depengs@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/08/2024 15:41, Depeng Shao wrote: > +void camss_reg_update(struct camss *camss, int hw_id, int port_id, bool is_clear) > +{ > + struct csid_device *csid; > + > + if (hw_id < camss->res->csid_num) { > + csid = &(camss->csid[hw_id]); > + > + csid->res->hw_ops->reg_update(csid, port_id, is_clear); > + } > +} The naming here doesn't make the action clear hw_ops->rup_update(csid, port, clear); "is_clear" is not required since the type is a bool the "is" is implied in the the logical state so just "clear" will do. But re: my previous comment on having the ISR do the clear as is done in the VFE 480, I don't think this is_clear parameter is warranted. We want the calling function to request the rup_update() for the rup_update() function to wait on completion and the ISR() to do the clear once the RUP interrupt has been raised. At least I think that's how it should work - could you please experiment with your code for the flow - as it appears to match the VFE 480 logic. --- bod