From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FF84C4332F for ; Mon, 14 Nov 2022 07:45:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235976AbiKNHpR (ORCPT ); Mon, 14 Nov 2022 02:45:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40498 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235993AbiKNHpP (ORCPT ); Mon, 14 Nov 2022 02:45:15 -0500 Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3AFE32725 for ; Sun, 13 Nov 2022 23:45:14 -0800 (PST) Received: by mail-lj1-x22a.google.com with SMTP id t10so12096497ljj.0 for ; Sun, 13 Nov 2022 23:45:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=RThUDKfaIW0h3m+CPW+odfwhZdY9NoazLhG6pvsOy0A=; b=CoOlY/JyiNs3rBh4briKTbLMg62G/yRn3DUkMDJzget5JbFD8S18U9q/bf7kLwdCgA H3WNJ8E68XjGyJt6t/VX9NRljtJ/StNuprqE8a+BwtF+G5u+qwj02RRjSu7dyKQA3qPp zO6eg8WjvAkD5HHTbYyjnYAL0M+YeYyobzzX6BqqVdCZD5Qkwotvga0tUWQGssdtOaYL GHL97W+2ldZtctrLynDhXX4MiYSYtXgORw8klZwSedUBxZzwifo/qk4IkbwZbUxMQCCe V3smUKYYzFPsX1I8CJCdOuBMLOdXt0LHAgEhcpvx6YsaXCanmx6EuwYd5xit9wZR+8yN Ktew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RThUDKfaIW0h3m+CPW+odfwhZdY9NoazLhG6pvsOy0A=; b=pKxX8oO9uaE66piUD06wcs0VPSa/wyPRlsVH2s+azazp9l2PHWoApCY4d6ZiAPXufI LQJiu1EGq4NmaKBotOOmacDa84imZ9mn4wSQzmvPf+l/hHfwWkv5lKV5MlzZv81BpGc+ IRz9jo9Phw67jb5m3kLi9iugLl9lACqQRY9O03qKsDpFcg63MrnV6iqgaSojpb19RjrG VM6IRKQ6BwsqqW94FP47dm1BrQzXd0cYm8eX2zCnLS0wfOV3pYiNixt4JUiENaq+lhKn 7X8M/LIja5wzKzeybSZVhIjaB7O2LASo4AwO/yjsl1UItJOUY8Mi5XCGKGUh01nngmwu ltKw== X-Gm-Message-State: ANoB5pnqoNe0ix6/icLw+CJHrSTJCTrtqyBGvGESZd7UIENO+L0yEJ+R 7E5P19RjQUkucnyxxLVgp+udmQ== X-Google-Smtp-Source: AA0mqf6Je7SzJ0/6XL2Blpt4CrFzA9c9QJH8q3G+IlddOO2mBMpg0spYsMrpNNrOy4sFVty13KIf3Q== X-Received: by 2002:a05:651c:12c9:b0:26f:c03d:f99b with SMTP id 9-20020a05651c12c900b0026fc03df99bmr3814983lje.190.1668411912583; Sun, 13 Nov 2022 23:45:12 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id cf30-20020a056512281e00b00492ca820e15sm1711964lfb.270.2022.11.13.23.45.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 13 Nov 2022 23:45:12 -0800 (PST) Message-ID: <6df681b1-318c-ea0a-8add-e0a18302eaf7@linaro.org> Date: Mon, 14 Nov 2022 08:45:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 02/10] ASoC: dt-bindings: qcom,apr: Split services to shared schema Content-Language: en-US To: Srinivas Kandagatla , Banajit Goswami , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Patrick Lai , Srinivasa Rao Mandadapu References: <20221111113547.100442-1-krzysztof.kozlowski@linaro.org> <20221111113547.100442-3-krzysztof.kozlowski@linaro.org> <5207a28b-9c8c-5014-28c1-15635ad30143@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <5207a28b-9c8c-5014-28c1-15635ad30143@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 11/11/2022 17:35, Srinivas Kandagatla wrote: > > > On 11/11/2022 11:35, Krzysztof Kozlowski wrote: >> The APR/GPR nodes are organized like: >> >> apr-or-gpr-device-node <- qcom,apr.yaml >> apr-gpr-service@[0-9] <- qcom,apr.yaml >> service-specific-components <- /schemas/sound/qcom,q6*.yaml >> >> The schema for services (apr-gpr-service@[0-9]) already grows > > I have not seen these grow or change alteast in the past 9 years. You added GPR to services in 2021, so it grew past 9 years. Then it grew in 2022 when I started adding missing pieces - missing compatibles and properties. > > Old APR (Elite f/w) and new GPR (AudioReach) interface provides access > to static services on the DSP. > >> considerably and is still quite not specific. It allows several >> incorrect combinations, like adding a clock-controller to a APM device. > > This should be fixed for sure for validation. This cannot be fixed without making schema over-complicated. It includes six different compatibles. Except few of them - these compatibles represent different devices. > > We had dedicated bindings per service before. Where? > > As the service has changed as part of new AudioReach Firmware, we could > have added new bindings for these services again. But as we are dealing > with the same audio hardware and clock resources a new bindings per > service did not make sense. Since then we moved all the lpass audio > ports and clocks related bindings to qcom,q6dsp-lpass-clocks.yaml and > qcom,q6dsp-lpass-ports.yaml. These are not bindings for services but bindings for their devices. Best regards, Krzysztof