From: Krzysztof Kozlowski <krzk@kernel.org>
To: Pengyu Luo <mitltlatltl@gmail.com>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
Jessica Zhang <jesszhan0024@gmail.com>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Subject: Re: [PATCH v3 1/2] dt-bindings: display: panel: Add Himax HX83121A
Date: Mon, 16 Mar 2026 09:15:20 +0100 [thread overview]
Message-ID: <6e00e9f3-0ff2-422d-b79f-fff8ebd47e58@kernel.org> (raw)
In-Reply-To: <CAH2e8h4US7Ut=u3AW6bra9kUhCo15k+sWmVw40adVE-JQ+ayVg@mail.gmail.com>
On 16/03/2026 09:02, Pengyu Luo wrote:
> On Mon, Mar 16, 2026 at 3:44 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> On Sun, Mar 15, 2026 at 10:45:35PM +0800, Pengyu Luo wrote:
>>> HX83121A is a driver IC used to drive MIPI-DSI panels. It is found
>>> in HUAWEI Matebook E Go series (Gaokun2/3) with BOE or CSOT panels.
>>>
>>> Signed-off-by: Pengyu Luo <mitltlatltl@gmail.com>
>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
>>> ---
>>> v3:
>>> - remove '|' from description (Krzysztof)
>>> - drop description for reset-gpios (Krzysztof)
>>
>> And all other changes?
>>
>> Why aren't you testing this code?
>>
>> NAK, drop the tag and request re-review.
>>
>
> I see. I will send a new version later. I made changes to v1 binding by mistake.
And EVERY patch you sent must be build tested, which would tell you that
you made mistakes. Why do you think build testing your code is our task?
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-03-16 8:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-15 14:45 [PATCH v2 0/2] drm/panel: Add Himax HX83121A panel driver Pengyu Luo
2026-03-15 14:45 ` [PATCH v3 1/2] dt-bindings: display: panel: Add Himax HX83121A Pengyu Luo
2026-03-15 16:19 ` Rob Herring (Arm)
2026-03-16 7:44 ` Krzysztof Kozlowski
2026-03-16 8:02 ` Pengyu Luo
2026-03-16 8:15 ` Krzysztof Kozlowski [this message]
2026-03-16 8:18 ` Pengyu Luo
2026-03-15 14:45 ` [PATCH v3 2/2] drm/panel: Add Himax HX83121A panel driver Pengyu Luo
2026-03-16 7:43 ` [PATCH v2 0/2] " Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e00e9f3-0ff2-422d-b79f-fff8ebd47e58@kernel.org \
--to=krzk@kernel.org \
--cc=airlied@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jesszhan0024@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mitltlatltl@gmail.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox