[PATCH] dt-bindings: clock: qcom,gcc-ipq6018: split to separate schema

[PATCH] dt-bindings: clock: qcom,gcc-ipq6018: split to separate schema

[Robert Marko]

The Qualcomm IPQ6018 GCC clock controller has clock inputs, thus existing
gcc-other.yaml was not describing it fully so move it to a separate schema.

Fully document the allowed and required XO and sleep clock inputs, as well
as update the provided example.

Signed-off-by: Robert Marko <robimarko@gmail.com>
---
 .../bindings/clock/qcom,gcc-ipq6018.yaml      | 57 +++++++++++++++++++
 .../bindings/clock/qcom,gcc-other.yaml        |  3 -
 2 files changed, 57 insertions(+), 3 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/clock/qcom,gcc-ipq6018.yaml

diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-ipq6018.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-ipq6018.yaml
new file mode 100644
index 0000000000000..af5d883cfdc86
--- /dev/null
+++ b/Documentation/devicetree/bindings/clock/qcom,gcc-ipq6018.yaml
@@ -0,0 +1,57 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/clock/qcom,gcc-ipq6018.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm Global Clock & Reset Controller on IPQ6018
+
+maintainers:
+  - Stephen Boyd <sboyd@kernel.org>
+  - Taniya Das <quic_tdas@quicinc.com>
+  - Robert Marko <robimarko@gmail.com>
+
+description: |
+  Qualcomm global clock control module provides the clocks, resets and power
+  domains on IPQ6018.
+
+  See also::
+    include/dt-bindings/clock/qcom,gcc-ipq6018.h
+    include/dt-bindings/reset/qcom,gcc-ipq6018.h
+
+allOf:
+  - $ref: qcom,gcc.yaml#
+
+properties:
+  compatible:
+    const: qcom,gcc-ipq6018
+
+  clocks:
+    items:
+      - description: board XO clock
+      - description: sleep clock
+
+  clock-names:
+    items:
+      - const: xo
+      - const: sleep_clk
+
+required:
+  - compatible
+  - clocks
+  - clock-names
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    clock-controller@1800000 {
+      compatible = "qcom,gcc-ipq6018";
+      reg = <0x01800000 0x80000>;
+      clocks = <&xo>, <&sleep_clk>;
+      clock-names = "xo", "sleep_clk";
+      #clock-cells = <1>;
+      #power-domain-cells = <1>;
+      #reset-cells = <1>;
+    };
+...
diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-other.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-other.yaml
index 559fc21435c8d..7d05f0f63cef2 100644
--- a/Documentation/devicetree/bindings/clock/qcom,gcc-other.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,gcc-other.yaml
@@ -15,8 +15,6 @@ description: |
   domains.
 
   See also::
-    include/dt-bindings/clock/qcom,gcc-ipq6018.h
-    include/dt-bindings/reset/qcom,gcc-ipq6018.h
     include/dt-bindings/clock/qcom,gcc-msm8953.h
     include/dt-bindings/clock/qcom,gcc-mdm9607.h
 
@@ -26,7 +24,6 @@ allOf:
 properties:
   compatible:
     enum:
-      - qcom,gcc-ipq6018
       - qcom,gcc-mdm9607
 
 required:
-- 
2.41.0

Re: [PATCH] dt-bindings: clock: qcom,gcc-ipq6018: split to separate schema

[Krzysztof Kozlowski]

On 26/10/2023 12:18, Robert Marko wrote:
> The Qualcomm IPQ6018 GCC clock controller has clock inputs, thus existing
> gcc-other.yaml was not describing it fully so move it to a separate schema.
> 
> Fully document the allowed and required XO and sleep clock inputs, as well
> as update the provided example.
> 
> Signed-off-by: Robert Marko <robimarko@gmail.com>

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH] dt-bindings: clock: qcom,gcc-ipq6018: split to separate schema

[Bjorn Andersson]

On Thu, 26 Oct 2023 12:18:37 +0200, Robert Marko wrote:
> The Qualcomm IPQ6018 GCC clock controller has clock inputs, thus existing
> gcc-other.yaml was not describing it fully so move it to a separate schema.
> 
> Fully document the allowed and required XO and sleep clock inputs, as well
> as update the provided example.
> 
> 
> [...]

Applied, thanks!

[1/1] dt-bindings: clock: qcom,gcc-ipq6018: split to separate schema
      commit: cec1f2ffcc065568fea9718921698576c6d1c62d

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>