From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Kieran Bingham <kieran.bingham@ideasonboard.com>,
linux-media@vger.kernel.org
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
<devicetree@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] Documentation: dt-bindings: media: i2c: Add ROHM BU64754 bindings
Date: Sun, 17 Sep 2023 19:27:27 +0200 [thread overview]
Message-ID: <6e163f4d-061d-3c20-4c2e-44c74d529f10@linaro.org> (raw)
In-Reply-To: <169494678738.1922990.10472250640303677004@ping.linuxembedded.co.uk>
On 17/09/2023 12:33, Kieran Bingham wrote:
> Quoting Krzysztof Kozlowski (2023-09-17 10:37:07)
>> On 15/09/2023 18:59, Kieran Bingham wrote:
>>> Add YAML device tree bindings for the ROHM BU64754 VCM Motor Driver for
>>> Camera Autofocus.
>>>
>>> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
>>> ---
>>
>> ...
>>
>>> +properties:
>>> + compatible:
>>> + items:
>>> + - enum:
>>> + - rohm,bu64754
>>> +
>>> + reg:
>>> + maxItems: 1
>>> +
>>> + vdd-supply:
>>
>> If the supply is not required, how the driver gets any power?
>
> It may not be controllable. It could be wired to be always on.
That's different. You talk now about board, I am talking about device.
Is the supply required for the device? If yes, then it should be
required by the bindings.
>
> The device has a low power mode which is controllable by software, so it
> could be always powered on and controlled via software only if desired.
> The driver handles that already as if the regulator isn't specified the
> power down register bits will be set to put it in low power mode.
Best regards,
Krzysztof
prev parent reply other threads:[~2023-09-17 17:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230915165946.4183839-1-kieran.bingham@ideasonboard.com>
2023-09-15 16:59 ` [PATCH 1/2] Documentation: dt-bindings: media: i2c: Add ROHM BU64754 bindings Kieran Bingham
2023-09-15 21:13 ` Conor Dooley
2023-09-17 10:26 ` Kieran Bingham
2023-09-17 9:37 ` Krzysztof Kozlowski
2023-09-17 10:33 ` Kieran Bingham
2023-09-17 17:27 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e163f4d-061d-3c20-4c2e-44c74d529f10@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kieran.bingham@ideasonboard.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).