Devicetree
 help / color / mirror / Atom feed
From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Paul Cercueil <paul@crapouillou.net>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Peter Griffin <peter.griffin@linaro.org>,
	Alim Akhtar <alim.akhtar@samsung.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ARM: dts: samsung: exynos4210-i9100: Enable RTS/CTS in Bluetooth node
Date: Wed, 2 Sep 2026 10:36:43 +0200	[thread overview]
Message-ID: <6e319291-72b8-4a43-b953-8a9f0a6049c8@samsung.com> (raw)
In-Reply-To: <20260829101509.138284-1-paul@crapouillou.net>

On 29.08.2026 12:15, Paul Cercueil wrote:
> The BCM4330 is connected using CTS/RTS too, so add the 'uart-has-rtscts'
> property.
>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>


Indeed the CTS/RTS pins are used for BT on most of the ARM Exynos boards,
as the "<&uartX_fctl>" property is assigned for pinctl-0. This is not really
specific to i9100, so maybe this property should be added to other dts?


However I wonder if Samsung UART driver actually use this "uart-has-rtscts"
DT property? A quick "git grep uart-has-rtscts drivers/tty" shows nothing
related to Samsung Exynos...


> ---
>
> Notes:
>     Changes:
>     
>     V1 was: "ARM: dts: samsung: exynos4210-i9100: Fix Bluetooth node"
>     
>     -v2: Drop max-speed property. It's only supposed to be used in some
>          cases, which don't apply here. As this was the "fix" for getting
>          Bluetooth to work on my device, which will be applied to the
>          driver instead, the Fixes: tag was removed.
>
>  arch/arm/boot/dts/samsung/exynos4210-i9100.dts | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/samsung/exynos4210-i9100.dts b/arch/arm/boot/dts/samsung/exynos4210-i9100.dts
> index 8a635bee59fa..95964be7daa8 100644
> --- a/arch/arm/boot/dts/samsung/exynos4210-i9100.dts
> +++ b/arch/arm/boot/dts/samsung/exynos4210-i9100.dts
> @@ -875,6 +875,7 @@ &serial_0 {
>  	status = "okay";
>  
>  	pinctrl-names = "default";
> +	uart-has-rtscts;
>  	pinctrl-0 = <&bt_en>, <&bt_res>, <&uart0_data>, <&uart0_fctl>;
>  
>  	bluetooth {

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland


  parent reply	other threads:[~2026-09-02  8:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20260829101532eucas1p29f4e04d4dfd169377793c276221059a6@eucas1p2.samsung.com>
2026-08-29 10:15 ` [PATCH v2] ARM: dts: samsung: exynos4210-i9100: Enable RTS/CTS in Bluetooth node Paul Cercueil
2026-09-01 14:27   ` Paul Cercueil
2026-09-02  8:36   ` Marek Szyprowski [this message]
2026-09-03 13:29     ` Paul Cercueil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6e319291-72b8-4a43-b953-8a9f0a6049c8@samsung.com \
    --to=m.szyprowski@samsung.com \
    --cc=alim.akhtar@samsung.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=paul@crapouillou.net \
    --cc=peter.griffin@linaro.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox