From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: gchan9527@gmail.com, Robert Foss <rfoss@kernel.org>,
Todor Tomov <todor.too@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
cros-qcom-dts-watchers@chromium.org,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 6/8] Add debug log info to msm_csid_subdev_init function
Date: Mon, 24 Jun 2024 11:08:42 +0100 [thread overview]
Message-ID: <6e643b88-2fbf-4bd1-b7a9-1af9e93f1916@linaro.org> (raw)
In-Reply-To: <20240624-b4-sc7180-camss-v2-6-0dfecdc50073@gmail.com>
On 24/06/2024 00:22, George Chan via B4 Relay wrote:
> + dev_err(dev, "missing clk %s", res->clock[i]);
Please don't abbreviate - the other error message says "clock" here we
say "clk"
Once fixed to clock please add
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
next prev parent reply other threads:[~2024-06-24 10:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-23 23:22 [PATCH v2 0/8] Add sc7180 camss subsys support George Chan via B4 Relay
2024-06-23 23:22 ` [PATCH v2 1/8] Add qcom,sc7180-camss George Chan via B4 Relay
2024-06-24 4:55 ` Krzysztof Kozlowski
2024-06-23 23:22 ` [PATCH v2 2/8] Add Gen2 v1.2.2 two-phase MIPI CSI-2 DPHY init George Chan via B4 Relay
2024-06-23 23:22 ` [PATCH v2 3/8] Add sc7180 support George Chan via B4 Relay
2024-06-23 23:22 ` [PATCH v2 4/8] Add sc7180 resources George Chan via B4 Relay
2024-06-23 23:22 ` [PATCH v2 5/8] Add debug log info to camss_enable_clocks function George Chan via B4 Relay
2024-06-24 10:07 ` Bryan O'Donoghue
2024-06-23 23:22 ` [PATCH v2 6/8] Add debug log info to msm_csid_subdev_init function George Chan via B4 Relay
2024-06-24 10:08 ` Bryan O'Donoghue [this message]
2024-06-24 10:19 ` Krzysztof Kozlowski
2024-06-23 23:22 ` [PATCH v2 7/8] Add debug log info to vfe block init and set clock rate George Chan via B4 Relay
2024-06-24 10:15 ` Bryan O'Donoghue
2024-06-23 23:22 ` [PATCH RFT v2 8/8] Add support for sc7180 camss subsys George Chan via B4 Relay
2024-06-24 4:55 ` Krzysztof Kozlowski
2024-06-24 4:54 ` [PATCH v2 0/8] Add sc7180 camss subsys support Krzysztof Kozlowski
2024-06-24 10:05 ` Bryan O'Donoghue
2024-06-24 12:07 ` george chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e643b88-2fbf-4bd1-b7a9-1af9e93f1916@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=gchan9527@gmail.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=todor.too@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).