devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: Randy Dunlap <rdunlap@infradead.org>,
	Jilin Yuan <yuanjilin@cdjrlc.com>,
	robh+dt@kernel.org, frowand.list@gmail.com
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] of: fix repeated words in comments
Date: Wed, 19 Oct 2022 19:57:44 +0100	[thread overview]
Message-ID: <6e6935bc-6de9-99fe-be17-1845b1910e2c@kernel.org> (raw)
In-Reply-To: <9fb4c010-b465-e908-6868-d9e493a9688f@infradead.org>

On 19/10/2022 19:53, Randy Dunlap wrote:
> 
> 
> On 10/19/22 06:02, Jilin Yuan wrote:
>> Delete the redundant word 'of'.
>>
>> Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
>> ---
>>  drivers/of/device.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/of/device.c b/drivers/of/device.c
>> index 8cefe5a7d04e..16c7e5a2a868 100644
>> --- a/drivers/of/device.c
>> +++ b/drivers/of/device.c
>> @@ -19,7 +19,7 @@
>>  
>>  /**
>>   * of_match_device - Tell if a struct device matches an of_device_id list
>> - * @matches: array of of device match structures to search in
>> + * @matches: array of device match structures to search in
> 
> Hi,
> Rob has already explained this at least 2 times.
> 
> The second "of" is "open firmware".
> I would write it
>               array of OF device match structures to search in
> :)

Good luck getting a response out of these guys, at this point
you've gotta wonder if they're real people or bots.

> 
>>   * @dev: the of device structure to match against
>>   *
>>   * Used by a driver to check whether an platform_device present in the
> 

  reply	other threads:[~2022-10-19 18:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-19 13:02 [PATCH] of: fix repeated words in comments Jilin Yuan
2022-10-19 18:53 ` Randy Dunlap
2022-10-19 18:57   ` Conor Dooley [this message]
2022-10-20 13:34     ` Bagas Sanjaya
2022-10-20  1:39   ` Theodore Ts'o
2022-10-20  1:54     ` Randy Dunlap
2022-10-20 13:15     ` Rob Herring
2022-10-20 13:35   ` Bagas Sanjaya
2022-10-20 17:36     ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6e6935bc-6de9-99fe-be17-1845b1910e2c@kernel.org \
    --to=conor@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=frowand.list@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=robh+dt@kernel.org \
    --cc=yuanjilin@cdjrlc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).