From: Stephen Boyd <sboyd@kernel.org>
To: Jie Luo <quic_luoj@quicinc.com>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
agross@kernel.org, andersson@kernel.org, catalin.marinas@arm.com,
conor+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
mturquette@baylibre.com, p.zabel@pengutronix.de,
robh+dt@kernel.org, will@kernel.org
Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
quic_srichara@quicinc.com
Subject: Re: [PATCH v3 3/3] clk: qcom: add clock controller driver for qca8386/qca8084
Date: Tue, 22 Aug 2023 12:10:25 -0700 [thread overview]
Message-ID: <6e781c2d21e346cdd7f84c3b7a57dafc.sboyd@kernel.org> (raw)
In-Reply-To: <6ebdcbdc-409c-0c08-1e5d-f9aa0b92c3b2@quicinc.com>
Quoting Jie Luo (2023-08-14 03:58:26)
>
>
> On 8/12/2023 6:56 PM, Konrad Dybcio wrote:
> > My main point is, why can't you use qcom_cc_really_probe?
> >
>
> Hi Konrad,
> qcom_cc_really_probe is taking the platform_device as the input
> parameter, but the nss_cc_qca8k_probe takes the mdio_device as the probe
> parameter.
There's no real reason why it takes a platform device instead of a plain
struct device. You can have an earlier patch change that function to
take a struct device instead.
next prev parent reply other threads:[~2023-08-22 19:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-10 11:54 [PATCH v3 0/3] add clock controller of qca8386/qca8084 Luo Jie
2023-08-10 11:54 ` [PATCH v3 1/3] clk: qcom: branch: Add clk_branch2_mdio_ops Luo Jie
2023-08-10 11:54 ` [PATCH v3 2/3] dt-bindings: clock: add qca8386/qca8084 clock and reset definitions Luo Jie
2023-08-10 12:21 ` Rob Herring
2023-08-10 21:11 ` Rob Herring
2023-08-10 11:54 ` [PATCH v3 3/3] clk: qcom: add clock controller driver for qca8386/qca8084 Luo Jie
2023-08-10 12:59 ` Konrad Dybcio
2023-08-11 11:49 ` Jie Luo
2023-08-12 10:56 ` Konrad Dybcio
2023-08-14 10:58 ` Jie Luo
2023-08-22 19:10 ` Stephen Boyd [this message]
2023-08-23 5:50 ` Jie Luo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e781c2d21e346cdd7f84c3b7a57dafc.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=quic_luoj@quicinc.com \
--cc=quic_srichara@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).