From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
robh+dt@kernel.org, vkoul@kernel.org,
yung-chuan.liao@linux.intel.com
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org, quic_srivasam@quicinc.com
Subject: Re: [PATCH 3/3] soundwire: qcom: add wake up interrupt support
Date: Wed, 23 Feb 2022 12:14:58 -0600 [thread overview]
Message-ID: <6e79238c-2ceb-0ae7-2b37-7ffac777db60@linux.intel.com> (raw)
In-Reply-To: <ee14c940-85c9-6c14-5738-e055801407ab@linaro.org>
>> Not following, sorry. if you use pm_runtime functions and it so happens
>> that the resume already started, then those routines would wait for the
>> resume to complete.
> yes that is true,
>
> TBH, I was trying to reproduce the issue since morning to collect some
> traces but no luck so far, I hit these issues pretty much rarely. Now
> code has changed since few months back am unable to reproduce this
> anymore. Or it might be just the state of code I had while writing this up.
>
> But when I hit the issue, this is how it looks like:
>
> 1. IRQ Wake interrupt resume parent.
>
> 2. parent is in middle of resuming
>
> 3. Slave Pend interrupt in controller fired up
>
> 4. because of (3) child resume is requested and then the parent resume
> blocked on (2) to finish.
>
> 5. from (2) we also trying to resume child.
>
> 6. (5) is blocked on (4) to finish which is blocked on (2) to finish
>
> we are dead locked. Only way for me to avoid dead lock was to wake the
> child up after IRQ wake interrupts.
Maybe a red-herring, but we're seen cases like this where we called
pm_runtime_get_sync() while resuming, that didn't go so well. I would
look into the use of _no_pm routines if you are already trying to resume.
next prev parent reply other threads:[~2022-02-23 18:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-21 10:41 [PATCH 0/3] soundwire: qcom: add pm runtime support Srinivas Kandagatla
2022-02-21 10:41 ` [PATCH 1/3] soundwire: qcom: add runtime pm support Srinivas Kandagatla
2022-02-22 19:15 ` Pierre-Louis Bossart
2022-02-23 16:36 ` Srinivas Kandagatla
2022-02-23 18:21 ` Pierre-Louis Bossart
2022-02-21 10:41 ` [PATCH 2/3] dt-bindings: soundwire: qcom: document optional wake irq Srinivas Kandagatla
2022-02-21 10:41 ` [PATCH 3/3] soundwire: qcom: add wake up interrupt support Srinivas Kandagatla
2022-02-22 19:26 ` Pierre-Louis Bossart
2022-02-22 22:52 ` Srinivas Kandagatla
2022-02-23 0:31 ` Pierre-Louis Bossart
2022-02-23 16:22 ` Srinivas Kandagatla
2022-02-23 18:14 ` Pierre-Louis Bossart [this message]
2022-02-21 13:02 ` [PATCH 0/3] soundwire: qcom: add pm runtime support Srinivasa Rao Mandadapu (Temp)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e79238c-2ceb-0ae7-2b37-7ffac777db60@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_srivasam@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).