From: Krzysztof Kozlowski <krzk@kernel.org>
To: Danila Tikhonov <danila@jiaxyga.com>,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
andersson@kernel.org, konrad.dybcio@linaro.org,
rafael@kernel.org, viresh.kumar@linaro.org,
heikki.krogerus@linux.intel.com, gregkh@linuxfoundation.org,
kees@kernel.org, tony.luck@intel.com, gpiccoli@igalia.com,
sudeep.holla@arm.com, quic_rjendra@quicinc.com,
andre.przywara@arm.com, ulf.hansson@linaro.org,
davidwronek@gmail.com, neil.armstrong@linaro.org,
heiko.stuebner@cherry.de, rafal@milecki.pl,
macromorgan@hotmail.com, linus.walleij@linaro.org,
dmitry.baryshkov@linaro.org, johan+linaro@kernel.org,
javier.carrasco.cruz@gmail.com, quic_kriskura@quicinc.com,
lpieralisi@kernel.org, fekz115@gmail.com
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
linux-usb@vger.kernel.org, linux-hardening@vger.kernel.org,
linux@mainlining.org
Subject: Re: [PATCH 11/11] arm64: dts: qcom: sm7325: Add device-tree for Nothing Phone 1
Date: Tue, 30 Jul 2024 11:07:33 +0200 [thread overview]
Message-ID: <6e79d848-b1f0-4d56-b5cb-5fcf80868138@kernel.org> (raw)
In-Reply-To: <20240729201843.142918-12-danila@jiaxyga.com>
On 29/07/2024 22:18, Danila Tikhonov wrote:
> From: Eugene Lepshy <fekz115@gmail.com>
>
> Add device tree for the Nothing Phone 1 (nothing,spacewar) smartphone
> which is based on the SM7325 SoC.
...
> +
> +&i2c2 {
> + clock-frequency = <100000>;
> + status = "okay";
> +
> + /* nxp,tfa9873 (EAR speaker codec) @ 34 */
> + /* nxp,tfa9873 (Main speaker codec) @ 35 */
> +};
> +
> +&i2c9 {
> + clock-frequency = <1000000>;
> + status = "okay";
> +
> + nfc@28 {
> + compatible = "nxp,nxp-nci-i2c";
Prepend it with proper compatible for this NFC chip and update the bindings.
> + reg = <0x28>;
> +
> + interrupt-parent = <&tlmm>;
> + interrupts = <41 IRQ_TYPE_NONE>;
This does not look like valid interrupt type...
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-07-30 9:07 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-29 20:18 [PATCH 00/11] Add Nothing Phone (1) support Danila Tikhonov
2024-07-29 20:18 ` [PATCH 01/11] dt-bindings: arm: qcom,ids: Add IDs for SM7325 family Danila Tikhonov
2024-07-30 9:02 ` Krzysztof Kozlowski
2024-07-29 20:18 ` [PATCH 02/11] soc: qcom: socinfo: Add Soc " Danila Tikhonov
2024-07-30 9:02 ` Krzysztof Kozlowski
2024-07-29 20:18 ` [PATCH 03/11] cpufreq: Add SM7325 to cpufreq-dt-platdev blocklist Danila Tikhonov
2024-07-29 21:29 ` Dmitry Baryshkov
2024-07-29 20:18 ` [PATCH 04/11] soc: qcom: pd_mapper: Add SM7325 compatible Danila Tikhonov
2024-07-29 21:30 ` Dmitry Baryshkov
2024-07-29 20:18 ` [PATCH 05/11] dt-bindings: soc: qcom: qcom,pmic-glink: Document " Danila Tikhonov
2024-08-06 14:42 ` Rob Herring (Arm)
2024-07-29 20:18 ` [PATCH 06/11] usb: typec: ucsi: Add qcom,sm7325-pmic-glink as needing PDOS quirk Danila Tikhonov
2024-07-29 21:29 ` Dmitry Baryshkov
2024-07-30 9:04 ` Krzysztof Kozlowski
2024-07-29 20:18 ` [PATCH 07/11] dt-bindings: arm: cpus: Add qcom kryo670 compatible Danila Tikhonov
2024-07-30 9:04 ` Krzysztof Kozlowski
2024-07-29 20:18 ` [PATCH 08/11] arm64: dts: qcom: Add SM7325 device tree Danila Tikhonov
2024-07-29 21:30 ` Dmitry Baryshkov
2024-07-29 20:18 ` [PATCH 09/11] dt-bindings: vendor-prefixes: Add Nothing Technology Limited Danila Tikhonov
2024-07-30 9:04 ` Krzysztof Kozlowski
2024-07-29 20:18 ` [PATCH 10/11] dt-bindings: arm: qcom: Add SM7325 Nothing Phone 1 Danila Tikhonov
2024-07-30 9:04 ` Krzysztof Kozlowski
2024-07-29 20:18 ` [PATCH 11/11] arm64: dts: qcom: sm7325: Add device-tree for " Danila Tikhonov
2024-07-30 9:07 ` Krzysztof Kozlowski [this message]
2024-07-30 20:11 ` [PATCH 00/11] Add Nothing Phone (1) support Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e79d848-b1f0-4d56-b5cb-5fcf80868138@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=andre.przywara@arm.com \
--cc=conor+dt@kernel.org \
--cc=danila@jiaxyga.com \
--cc=davidwronek@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=fekz115@gmail.com \
--cc=gpiccoli@igalia.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=heiko.stuebner@cherry.de \
--cc=javier.carrasco.cruz@gmail.com \
--cc=johan+linaro@kernel.org \
--cc=kees@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@mainlining.org \
--cc=lpieralisi@kernel.org \
--cc=macromorgan@hotmail.com \
--cc=neil.armstrong@linaro.org \
--cc=quic_kriskura@quicinc.com \
--cc=quic_rjendra@quicinc.com \
--cc=rafael@kernel.org \
--cc=rafal@milecki.pl \
--cc=robh@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=tony.luck@intel.com \
--cc=ulf.hansson@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).