From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33B82C38147 for ; Wed, 18 Jan 2023 02:58:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229658AbjARC6d (ORCPT ); Tue, 17 Jan 2023 21:58:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36362 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229484AbjARC6b (ORCPT ); Tue, 17 Jan 2023 21:58:31 -0500 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 29EB44FC35 for ; Tue, 17 Jan 2023 18:58:30 -0800 (PST) Received: by mail-ej1-x62d.google.com with SMTP id vm8so79982463ejc.2 for ; Tue, 17 Jan 2023 18:58:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/jxMstUvueEQASfZNGKQtozJSkPqyF+FQ0f5CH6JWto=; b=Ewt84ua+9q2pPgw239vJZTEcpW5L79v2xH2x/6HFk8bN5JP8eYr9cEKvJEWJhoGWYE DIyriS8A5mmAUfdMwjXXiiKI376zR2cqXGWbOWmgAviSzQTdKxTT/bdCfD5I2IaoEC9w jwbQJab/9765992rtPSxzGY8PEA4DVY/XGQ8kLH4NhAT2lD/V7i8huNlHj6WRWOYH5pL OlmlcKQcSRDjkohjLwMQnNzF5z/WL+dfgpz1OwWdpVBzyIksOz1Tpe06CnqVcCAR6QMC 65W9m8cOxFC+1RxPzn8I4yG37K+5nHIvsyjE1VKTUQLiocp2JVQSvZTFXxe1tzwBrrkz HcUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/jxMstUvueEQASfZNGKQtozJSkPqyF+FQ0f5CH6JWto=; b=Fi04sjaMWd29l4kjXeM6gE2z//25yNRue+ufGElt7nzNmzJ1QGhpxFZGK6d6tP1BD7 TMz9zQvH5r42KwgKbUywQzZAf54VJNIj8jrdvFsMcO952iqxYNKqLKAuWwyla6BaQ56C ncaqErbSoFfxebdjSUfpL1eRKTsrqH2j8nJNannHqtjWuL01tFYwuawL8/2lc7yKJY4M YMdKqo2rYpTfstA4X7CpB8ky9vNW8gqA8yBsXUv20BxE3GcW08n5KxITbvIqWYIhZGpm xUVbb/LGVuBb1K4agsZc4NC3H6PeSsw2AfDpS91Y0YS4M7Uqf68rLAAJGAAq9bt15uZa CuQg== X-Gm-Message-State: AFqh2kod4rWTzghDV6f38rFfk9+bwQvJZWIVwq0ltwGQ0Q9cqvjvsr4M bpbLprchvXOpIgnGAiH72jfL/g== X-Google-Smtp-Source: AMrXdXtanBFiuO6F4QWUHNIZE17iB+p93sQtCEfM2tNe9hI+JXrj35iHPaKIWAXkSIORjuT0gYFAPw== X-Received: by 2002:a17:906:6846:b0:84d:2fdf:a41b with SMTP id a6-20020a170906684600b0084d2fdfa41bmr4755294ejs.50.1674010708743; Tue, 17 Jan 2023 18:58:28 -0800 (PST) Received: from ?IPV6:2001:14ba:a085:4d00::8a5? (dzccz6yyyyyyyyyyybcwt-3.rev.dnainternet.fi. [2001:14ba:a085:4d00::8a5]) by smtp.gmail.com with ESMTPSA id gk8-20020a17090790c800b0084d35ffbc20sm12875378ejb.68.2023.01.17.18.58.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Jan 2023 18:58:28 -0800 (PST) Message-ID: <6e7b1518-0dd5-59a6-128a-e3c3c194bf52@linaro.org> Date: Wed, 18 Jan 2023 04:58:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v5 10/12] arm64: dts: qcom: sc8280xp: Define some of the display blocks Content-Language: en-GB To: Bjorn Andersson Cc: Rob Clark , Abhinav Kumar , Sean Paul , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Bjorn Andersson , Konrad Dybcio , Kalyan Thota , Jessica Zhang , Kuogee Hsieh , Johan Hovold , Sankeerth Billakanti , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221207220012.16529-1-quic_bjorande@quicinc.com> <20221207220012.16529-11-quic_bjorande@quicinc.com> From: Dmitry Baryshkov In-Reply-To: <20221207220012.16529-11-quic_bjorande@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 08/12/2022 00:00, Bjorn Andersson wrote: > From: Bjorn Andersson > > Define the display clock controllers, the MDSS instances, the DP phys > and connect these together. > > Signed-off-by: Bjorn Andersson > Signed-off-by: Bjorn Andersson > --- > > Changes since v4: > - None > > arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 838 +++++++++++++++++++++++++ > 1 file changed, 838 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > index 9f3132ac2857..c2f186495506 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > @@ -4,6 +4,7 @@ > * Copyright (c) 2022, Linaro Limited > */ > > +#include > #include > #include > #include > @@ -1698,6 +1699,44 @@ usb_1_qmpphy: phy@8903000 { > status = "disabled"; > }; > > + mdss1_dp0_phy: phy@8909a00 { > + compatible = "qcom,sc8280xp-dp-phy"; > + reg = <0 0x08909a00 0 0x19c>, > + <0 0x08909200 0 0xec>, > + <0 0x08909600 0 0xec>, > + <0 0x08909000 0 0x1c8>; > + > + clocks = <&dispcc1 DISP_CC_MDSS_DPTX0_AUX_CLK>, > + <&dispcc1 DISP_CC_MDSS_AHB_CLK>; > + clock-names = "aux", "cfg_ahb"; > + > + power-domains = <&rpmhpd SC8280XP_MX>; > + > + #clock-cells = <1>; > + #phy-cells = <0>; > + > + status = "disabled"; > + }; > + > + mdss1_dp1_phy: phy@890ca00 { > + compatible = "qcom,sc8280xp-dp-phy"; > + reg = <0 0x0890ca00 0 0x19c>, > + <0 0x0890c200 0 0xec>, > + <0 0x0890c600 0 0xec>, > + <0 0x0890c000 0 0x1c8>; > + > + clocks = <&dispcc1 DISP_CC_MDSS_DPTX1_AUX_CLK>, > + <&dispcc1 DISP_CC_MDSS_AHB_CLK>; > + clock-names = "aux", "cfg_ahb"; > + > + power-domains = <&rpmhpd SC8280XP_MX>; > + > + #clock-cells = <1>; > + #phy-cells = <0>; > + > + status = "disabled"; > + }; > + > system-cache-controller@9200000 { > compatible = "qcom,sc8280xp-llcc"; > reg = <0 0x09200000 0 0x58000>, <0 0x09600000 0 0x58000>; > @@ -1813,6 +1852,326 @@ usb_1_dwc3: usb@a800000 { > }; > }; > > + mdss0: display-subsystem@ae00000 { > + compatible = "qcom,sc8280xp-mdss"; > + reg = <0 0x0ae00000 0 0x1000>; > + reg-names = "mdss"; > + > + power-domains = <&dispcc0 MDSS_GDSC>; > + > + clocks = <&gcc GCC_DISP_AHB_CLK>, > + <&dispcc0 DISP_CC_MDSS_AHB_CLK>, > + <&dispcc0 DISP_CC_MDSS_MDP_CLK>; > + clock-names = "iface", > + "ahb", > + "core"; > + > + resets = <&dispcc0 DISP_CC_MDSS_CORE_BCR>; > + > + interrupts = ; > + interrupt-controller; > + #interrupt-cells = <1>; > + > + interconnects = <&mmss_noc MASTER_MDP0 0 &mc_virt SLAVE_EBI1 0>, > + <&mmss_noc MASTER_MDP1 0 &mc_virt SLAVE_EBI1 0>; > + interconnect-names = "mdp0-mem", "mdp1-mem"; > + > + iommus = <&apps_smmu 0x1000 0x402>; > + > + status = "disabled"; > + > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; > + > + mdss0_mdp: display-controller@ae01000 { > + compatible = "qcom,sc8280xp-dpu"; > + reg = <0 0x0ae01000 0 0x8f000>, > + <0 0x0aeb0000 0 0x2008>; > + reg-names = "mdp", "vbif"; > + > + clocks = <&gcc GCC_DISP_HF_AXI_CLK>, > + <&gcc GCC_DISP_SF_AXI_CLK>, > + <&dispcc0 DISP_CC_MDSS_AHB_CLK>, > + <&dispcc0 DISP_CC_MDSS_MDP_LUT_CLK>, > + <&dispcc0 DISP_CC_MDSS_MDP_CLK>, > + <&dispcc0 DISP_CC_MDSS_VSYNC_CLK>; > + clock-names = "bus", > + "nrt_bus", > + "iface", > + "lut", > + "core", > + "vsync"; > + > + assigned-clocks = <&dispcc0 DISP_CC_MDSS_MDP_CLK>, > + <&dispcc0 DISP_CC_MDSS_VSYNC_CLK>; > + assigned-clock-rates = <460000000>, > + <19200000>; > + > + operating-points-v2 = <&mdss0_mdp_opp_table>; > + power-domains = <&rpmhpd SC8280XP_MMCX>; > + > + interrupt-parent = <&mdss0>; > + interrupts = <0>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@5 { > + reg = <5>; > + mdss0_intf5_out: endpoint { > + remote-endpoint = <&mdss0_dp3_in>; > + }; > + }; > + > + port@6 { > + reg = <6>; > + mdss0_intf6_out: endpoint { > + remote-endpoint = <&mdss0_dp2_in>; > + }; > + }; > + }; This now fails with: arch/arm64/boot/dts/qcom/sc8280xp-crd.dtb: display-controller@ae01000: ports: 'port@0' is a required property From schema: Documentation/devicetree/bindings/display/msm/qcom,sc8280xp-dpu.yaml arch/arm64/boot/dts/qcom/sc8280xp-crd.dtb: display-controller@ae01000: Unevaluated properties are not allowed ('ports' was unexpected) From schema: Documentation/devicetree/bindings/display/msm/qcom,sc8280xp-dpu.yaml We do not map reg ids to INTF indices. So, unless you plan to change that, could you please change these to port@0 / port@1 ? [skipped the rest] -- With best wishes Dmitry