Re: [linux-sunxi] [PATCH v5 5/6] ARM: sun7i: Convert to CCU

[Olliver Schinagl <oliver-dxLnbx3+1qmEVqv0pETR8A@public.gmane.org>]

Hi Maxime,

On 10-07-17 13:55, Maxime Ripard wrote:
> On Mon, Jul 10, 2017 at 01:23:51PM +0200, Olliver Schinagl wrote:
>> Hi Pleas,
>>
>> On 04-07-17 22:05, Priit Laes wrote:
>>> Convert sun7i-a20.dtsi to new CCU driver.
>>>
>>> Tested on Cubietruck.
>>>
>>> Signed-off-by: Priit Laes <plaes-q/aMd4JkU83YtjvyW6yDsg@public.gmane.org>
>>> ---
>>>  arch/arm/boot/dts/sun7i-a20.dtsi | 719 +++-----------------------------
>>>  1 file changed, 84 insertions(+), 635 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi
>>> index 96bee77..a5ca5a8 100644
>>> --- a/arch/arm/boot/dts/sun7i-a20.dtsi
>>> +++ b/arch/arm/boot/dts/sun7i-a20.dtsi
>>> @@ -46,8 +46,6 @@
>>>
>>>  #include <dt-bindings/interrupt-controller/arm-gic.h>
>>>  #include <dt-bindings/thermal/thermal.h>
>>> -
>>> -#include <dt-bindings/clock/sun4i-a10-pll2.h>
>>>  #include <dt-bindings/dma/sun4i-a10.h>
>> I had to add these includes here to make this all work:
>
> That's unlikely, none of the defines are used in this patch.
>

My appologies you are right. I needed to add them to get this ontop of 
your DRM stack working for the A20. I looked at my local diff and 
responded a bit overeagerly probably. Nice catch!

Olliver

> Maxime
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html