Re: [PATCH v1 0/5] Update APDS990x ALS to support device trees

["Arnd Bergmann" <arnd@arndb.de>]

On Sat, Apr 18, 2026, at 18:24, David Lechner wrote:
> On 4/18/26 9:47 AM, Svyatoslav Ryhel wrote:
>> Document Avago APDS9900/9901 ALS/Proximity sensor in schema and modernize
>> its driver to support OF bindings.
>> 
>> Svyatoslav Ryhel (5):
>>   dt-bindings: iio: light: Document Avago APDS9900/9901 ALS/Proximity
>>     sensor
>>   misc: apds990x: Use more device managed approach in the probe
>>   misc: apds990x: Drop Vled supply
>>   misc: apds990x: Convert to use OF bindings
>>   misc: apds990x: Drop IRQF_TRIGGER_LOW trigger
>> 
>>  .../bindings/iio/light/avago,apds9900.yaml    |  83 ++++++++
>>  drivers/misc/apds990x.c                       | 197 +++++++++---------
>
> As mentioned in my reply to the dt-bindings patch, there is already an
> IIO driver that looks like it could be compatible. I'm guessing that
> this misc driver pre-dates the IIO subsystem. I would have a look at it
> instead (drivers/iio/light/tsl2772.c).

I see that we have a number of ALS drivers like this one in drivers/misc:

drivers/misc/apds9802als.c
drivers/misc/apds990x.c
drivers/misc/bh1770glc.c
drivers/misc/isl29020.c
drivers/misc/isl29003.c

As far as I can tell, all of these are entirely unused, with nothing
in the kernel creating the platform devices. The drivers that used
instead have all been converted to drivers/iio a long time ago.

Is it time to remove all of the above?

The notable exception is drivers/misc/tsl2550.c, which is instantiated
from both arch/arm/boot/dts/ti/omap/am335x-evm.dts and
drivers/i2c/busses/i2c-taos-evm.c. There is a similarly named
drivers/iio/light/tsl2563.c driver, but unfortunately that uses
a completely different register level interface.

      Arnd